Received-SPF: pass (google.com: domain of linux-kernel+bounces-90672-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
From: Will Deacon <will@kernel.org>
To: catalin.marinas@arm.com,
	nathan@kernel.org,
	mark.rutland@arm.com,
	broonie@kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	llvm@lists.linux.dev,
	Puranjay Mohan <puranjay12@gmail.com>
Cc: kernel-team@android.com,
	Will Deacon <will@kernel.org>
Subject: Re: [PATCH] arm64: prohibit probing on arch_kunwind_consume_entry()
Date: Mon,  4 Mar 2024 13:41:16 +0000
Message-Id: <170955720098.2136218.47711104039103934.b4-ty@kernel.org>
In-Reply-To: <20240229231620.24846-1-puranjay12@gmail.com>
References: <20240229231620.24846-1-puranjay12@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

On Thu, 29 Feb 2024 23:16:20 +0000, Puranjay Mohan wrote:
> Make arch_kunwind_consume_entry() as __always_inline otherwise the
> compiler might not inline it and allow attaching probes to it.
> 
> Without this, just probing arch_kunwind_consume_entry() via
> <tracefs>/kprobe_events will crash the kernel on arm64.
> 
> The crash can be reproduced using the following compiler and kernel
> combination:
> clang version 19.0.0git (https://github.com/llvm/llvm-project.git d68d29516102252f6bf6dc23fb22cef144ca1cb3)
> commit 87adedeba51a ("Merge tag 'net-6.8-rc7' of git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net")
> 
> [...]

Applied to arm64 (for-next/fixes), thanks!

[1/1] arm64: prohibit probing on arch_kunwind_consume_entry()
      https://git.kernel.org/arm64/c/2c79bd34af13

Cheers,
-- 
Will

https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev