Received: by 2002:ab2:3141:0:b0:1ed:23cc:44d1 with SMTP id i1csp1845133lqg; Mon, 4 Mar 2024 05:49:38 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCU/5aUC3X5fl2ocF0tUzLYpa7NrUBB+6PfbROYrlnUB5uQElVCVUXNTSd9Y8hM/TXOj0efwgx8gc0OmV5oX+5WdX6FMt6hcKkItjQLeWA== X-Google-Smtp-Source: AGHT+IEk9STGA8XYDrtnc+rrstgOMFTt/2x7AKkRNdEX2SYUMP32KXT3MDyT+3kT9fDCucVHLhAx X-Received: by 2002:a9d:6a11:0:b0:6e4:dce2:7079 with SMTP id g17-20020a9d6a11000000b006e4dce27079mr5672729otn.6.1709560178273; Mon, 04 Mar 2024 05:49:38 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709560178; cv=pass; d=google.com; s=arc-20160816; b=lJq2UC5tRGGI1MjIzKcRxNjO744x801T55xabnNp9jGXyX+r/c4OoAbAgCMVlYodwe Eu6c5W752GG8CpoWu2KE6ScBHLRCRimYTiRHhg/4bn56v6VZlCAcXduP20m91pwpWXyU 6FhHg7qm7NyzkG/QeAtvfRlfkLVaj526ZgKRs3a9rKkL6xmsa17r6Ie1fqZSwYVQQY+4 JyUC5wscUL5q6ZsVXre07F6g/K3MhC5egXmLFl7ssd28U0cIcisjhknnsdVbvm8J0BYG Jj3La9W/hASQM/G/JLWt67cztZnFKmgWz2xxfCKraDJ+bE1TzTlSP4oNgfDaw1LSTCLJ 8tUA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=1CZLYbfZD2uFt0DlBr8muQhEVQXSLcxTpka04YzR95c=; fh=YYOr7HvmekpdfXtK/LXvWl9IpNOPdy7YRwBi62LtTfQ=; b=B6Ptb6b+W0cW4x3HJHnLJkTHAbcfNf9twz5eh4miO9HUicZVyMON8O6vCwMKOCWJVY NY42/MPFakd8Xoz+IJL3AFRQZoEOOl++836KY0HvfnYZ/7KK9E46JzqsEfP43wobErIn WVt8ucMHeVqq1xj8nGZhB8Q9LWtER58Wx6sUFwcble+yQDLGruFYp+o5FpckPvm1sAeu zY7E5WXuFlgTKfuZmuIvTrWpoHwmaY5M/Lfk/3kzzoOJqEW5eStYfT1YbGiqQm/uv8yl UssIULPDUTQVRwfv12kDnOmOczR0KI5JQJg7k8nNwd2daLW4rtdlnMqcna1ZwoOECuXL qD1Q==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=EszN5Bhl; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-90637-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-90637-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id r4-20020a63d904000000b005dc4c1f8c5dsi8446393pgg.579.2024.03.04.05.49.37 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Mar 2024 05:49:38 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-90637-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=EszN5Bhl; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-90637-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-90637-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 8B8A0B2573F for ; Mon, 4 Mar 2024 13:23:58 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 8DE153D981; Mon, 4 Mar 2024 13:23:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="EszN5Bhl" Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4EA1C3D55E; Mon, 4 Mar 2024 13:23:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709558626; cv=none; b=fI+JV2IkAjvuackurYXP0LT+fTYc+SvrzyZK9XSX3sYbXd0J1gmp9mJLV2xpBhqtfiEyNCebbK+N21l6n+6fmT4o2aTQhZXbKRmIMU0GsHvccWEiMjBlJVjYXBleAaL4Nfi6Z+nYe/gRMyUk08Wn49uJed+KhczE/DIgyOvlcF4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709558626; c=relaxed/simple; bh=YsyDulOzSzx19ZpeWD5p9gxvh32LjG6ZWdvbYa2ooAY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=kSDOjiKADQdgEW8Vog4LTe3gvMZaG+dksk/o2DHHBE+2YCjq02htpO6qIsJeMqSPy2OXpMYn1L7TkjpZA7Y/Pu/vzUMuLT36vPX7OirIPgcLniQpAMWk6GzK0qtXEPU3O0CbSrNxO2JdTwSpnqH0sGZKGuZa62EwHX2F0+n4vnM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=EszN5Bhl; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=1CZLYbfZD2uFt0DlBr8muQhEVQXSLcxTpka04YzR95c=; b=EszN5BhlkHgHWqGTCQdqNI4TxO Uv67t+hBg3BhPkaFjwRro/2sCKqvWKosw+B9bI8cjiUYhPaN/h+isbKXkjYBqnDXfROyrE8QCnXS4 nASPiAGYIYG2C7gtyFsxMNwHVvu03d4ruR77xFf7H0ZYXNBMaCKL37k/KKVYA95AxLX8=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1rh8IT-009KDq-Qh; Mon, 04 Mar 2024 14:24:01 +0100 Date: Mon, 4 Mar 2024 14:24:01 +0100 From: Andrew Lunn To: Horatiu Vultur Cc: hkallweit1@gmail.com, linux@armlinux.org.uk, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, wojciech.drewek@intel.com, arun.ramadoss@microchip.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, UNGLinuxDriver@microchip.com Subject: Re: [PATCH net-next v3 1/2] net: phy: micrel: lan8814 led errata Message-ID: References: <20240304091548.1386022-1-horatiu.vultur@microchip.com> <20240304091548.1386022-2-horatiu.vultur@microchip.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240304091548.1386022-2-horatiu.vultur@microchip.com> On Mon, Mar 04, 2024 at 10:15:47AM +0100, Horatiu Vultur wrote: > Lan8814 phy led behavior is not correct. It was noticed that the led > still remains ON when the cable is unplugged while there was traffic > passing at that time. > > The fix consists in clearing bit 10 of register 0x38, in this way the > led behaviour is correct and gets OFF when there is no link. > > Reviewed-by: Wojciech Drewek > Signed-off-by: Horatiu Vultur Reviewed-by: Andrew Lunn Andrew