Received: by 2002:ab2:3141:0:b0:1ed:23cc:44d1 with SMTP id i1csp1847549lqg; Mon, 4 Mar 2024 05:54:11 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCUKi08DkIUeMXIdFz+PoLCQYizrU55m4dmK2JV3NeiOymX9Lu/741hpT2KWBnROFmU8WGb0Eqnmh4GSgWoNerx+py8cl2a9EEzyx6Mfkg== X-Google-Smtp-Source: AGHT+IFEF6L0uk+eeUw4uzQDzgRk7BVv8POYjzMsLduaTweIylWBD1rxKLX5nqscXFVlc3fyVPH3 X-Received: by 2002:a05:6808:1202:b0:3c0:72ba:64e with SMTP id a2-20020a056808120200b003c072ba064emr10602499oil.39.1709560450785; Mon, 04 Mar 2024 05:54:10 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709560450; cv=pass; d=google.com; s=arc-20160816; b=pix39IYTw7F0wKC3IMu3hqu1d5ZBp3/1NOpZR2lYD329UtzI0Ga+kMDEbcQrkQGzNS NspE/BLjaGjoiNkA4EZszKozHeLeC9MFX3Tm6fwCP9zM2ELPUF1Sl4HbocMj+KWDpVHq LXdB4z4ZJZXlnPHdzjbdu35AJX9LIlH27bBxksu9N9NKlgeA/lE9jmSvM6I13nfjfVn6 152xekq51A3vRufQYiY+CCX8otOo/azQ+YRXdp7tLtB9I4QksGlM8EEEGEpP0PVSCp1f RHW8M1ZIGGUkzOayarDg3zTJG0jP6LaTD90X4cKfacvUTycHSk5qfIx3yOlJXx3MCCcp HQSA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=bb8mCv500k35s1eNNgIcxxb3niCF6r/8io3LS4t9HlU=; fh=Xxb/o/VT2+KKomfD0LE+Zgi4TAqBo+pdc9fL7MZP4UA=; b=QiBol4waCvp3Vdi8JnczxwiLo5myTd27LiMmQhdGnSSFbICBUhXtOJRj6TXXv+UF8w 2Aw/PY5WNgoVYDzYObXMQ+pLEAg7qNR07dchv5v/iZlvSF8cbuF89CeQ93nGb1SIOIko AiCjCK2wiQwPAezVwGzhoHALYpcL8ackZjLXSMp56N2TkbW3ERNVz1zMEbmH4VQ2CWJq NdLE/Ir/5+oNavcocOYKp61DyHtts7mUqCd51pVtUDIJu10RL+eFamcBlSeEqjFJ0t75 Kdjpt/4vbi3DpXvE15wNVVrM+75lEc0b5/FKJi4aLRZpHjmC5EzQWrqxml0SoIQ24C1Z dLtQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=T7oxjHHT; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-90676-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-90676-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id g17-20020a635211000000b005e428bef548si8476852pgb.649.2024.03.04.05.54.10 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Mar 2024 05:54:10 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-90676-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=T7oxjHHT; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-90676-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-90676-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id BDCBF283749 for ; Mon, 4 Mar 2024 13:47:39 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id DE8223FB04; Mon, 4 Mar 2024 13:46:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="T7oxjHHT" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0ECDC3EA73; Mon, 4 Mar 2024 13:46:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709560018; cv=none; b=RjOANlMMgc3W5b8PbuZsCzUvXtKK65QmEGbWhRXAdX9fAJ/rdcn47f3ZfsCvydZqroE1g2GvCiLpj5RwGRcqydqUpxZeQu7AIUlgAfXQQjrs9aDgI6SehQEMZrGaMvvivruU+2Cx+cwMytS1oI9FkX61o2nWQasOuHaxtGMO9xs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709560018; c=relaxed/simple; bh=yFBwC5/sksPQ9ymeW8V7bys/1cfugBaMwQ2j7y4e7ig=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=p1McnP3cxHXbMtVEDKtYNUElzVsEfdUE5yze+3FIqWY0AxUiPbrhY1gJVxf17VyPLDiGQZThOBkSXtUHsa+IGV/YcwYMxpYfY9qTQSsD2bMXEf+LDmJpBLQ2e+A2PTj2m7cE+3hhpyprVAFQRrX3XQThaWRXe3Fbe+PwxbWQRDY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=T7oxjHHT; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 90710C433C7; Mon, 4 Mar 2024 13:46:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1709560017; bh=yFBwC5/sksPQ9ymeW8V7bys/1cfugBaMwQ2j7y4e7ig=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=T7oxjHHTg+A4+P1XacVV/zgozW0iv5PMdG9cftGboomQPo1YIj6GKGh4/h2ptKC6k OCjbgsGsN5Ih77f9WceVMuXZVaolzxr2VXagSUfJcRTkmWGjY82/hW3zkFwWp4moab 5yJ/rRF5wAemWtqa/MO0OP+nb9P2czB4oqB5UUnjokrXYFpiQFHkTHj7z4wQrMBk9W zfoNwS97M1u23f3FoUqGk6X3dOf0cSNSPpv63Ov1CBrN0K2MWsxuiGnBWmxuRFowgY Ymwv+iBf1pRyd/TcP0WdTEjlLV3toexgJlqSP6ImqlcXD1LuApdQP67SlYO7BinUKq kIx3adM6gt0Vw== Received: from johan by xi.lan with local (Exim 4.97.1) (envelope-from ) id 1rh8eo-000000000ZF-15wE; Mon, 04 Mar 2024 14:47:06 +0100 Date: Mon, 4 Mar 2024 14:47:06 +0100 From: Johan Hovold To: Colin Ian King Cc: Greg Kroah-Hartman , linux-usb@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][next] USB: serial: ftdi_sio: Remove redundant assignment to variable cflag Message-ID: References: <20240207104936.2441424-1-colin.i.king@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240207104936.2441424-1-colin.i.king@gmail.com> On Wed, Feb 07, 2024 at 10:49:36AM +0000, Colin Ian King wrote: > The variable cflag is being assigned a value that is not being read > afterwards, it is being re-assigned later on. The assignment is > redundant and can be removed. > > Cleans up clang scan warning: > drivers/usb/serial/ftdi_sio.c:2613:15: warning: Value stored to 'cflag' > during its initialization is never read [deadcode.DeadStores] > > Signed-off-by: Colin Ian King Applied, thanks. Johan