Received-SPF: pass (google.com: domain of linux-kernel+bounces-90693-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Subject: Re: [PATCH net-next v2] net/nlmon: Cancel setting the fields of
 statistics to zero.
To: Jason Xing <kerneljasonxing@gmail.com>, yuanli fu <fuyuanli0722@gmail.com>
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
 pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
 fuyuanli@didiglobal.com
References: <20240303114139.GA11018@didi-ThinkCentre-M920t-N000>
 <CAL+tcoDAmA4q+FxJchgA1LQ2fxhD8oRdjDOmVPeJ1-eSnkSt5Q@mail.gmail.com>
 <CABbqxmcJ+bybv0e-Rby9Q1jVR59Na_XE9MBee+f_zu0HUTmvqA@mail.gmail.com>
 <CAL+tcoDkTPLFksXWReGXNjujOQbgtiTKN0_-MW1f7Yhj8+CzgA@mail.gmail.com>
From: Daniel Borkmann <daniel@iogearbox.net>
Message-ID: <df93a088-e8f8-3708-8009-b0560c0d07f7@iogearbox.net>
Date: Mon, 4 Mar 2024 14:57:14 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.7.2
Precedence: bulk
MIME-Version: 1.0
In-Reply-To: <CAL+tcoDkTPLFksXWReGXNjujOQbgtiTKN0_-MW1f7Yhj8+CzgA@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit

On 3/4/24 2:25 PM, Jason Xing wrote:
> On Mon, Mar 4, 2024 at 7:14 PM yuanli fu <fuyuanli0722@gmail.com> wrote:
>> Jason Xing <kerneljasonxing@gmail.com> 于2024年3月4日周一 15:05写道：
>>> On Sun, Mar 3, 2024 at 7:43 PM fuyuanli <fuyuanli@didiglobal.com> wrote:
>>>>
>>>> Since fields of rtnl_link_stats64 have been set to zero in the previous
>>>> dev_get_stats function, there is no need to set them again in the
>>>> ndo_get_stats64 function.
>>>>
>>>> Signed-off-by: fuyuanli <fuyuanli@didiglobal.com>
>>>> Link: https://lore.kernel.org/netdev/20240302105224.GA7223@didi-ThinkCentre-M920t-N000/
>>>
>>> Suggested-by: Jason Xing <kerneljasonxing@gmail.com>
>>> See https://lore.kernel.org/all/CAL+tcoA=FVBJi2eJgAELhWG_f+N-kwmrHc+XRfKXhYk2RJcPKg@mail.gmail.com/
>> OK, I will submit a v3 patch which updating commit message, thanks.
> 
> I don't think you need to send a new version of the patch unless
> someone points out other changes that should be made.

I think this patch is not needed anymore, see net-next :

4f41ce81a919 ("net: nlmon: Remove init and uninit functions")
26b5df99bf60 ("net: nlmon: Simplify nlmon_get_stats64")

Thanks,
Daniel