Received-SPF: pass (google.com: domain of linux-kernel+bounces-90732-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Precedence: bulk
MIME-Version: 1.0
References: <20240229-ad7944-mainline-v4-0-f88b5ec4baed@baylibre.com>
 <20240229-ad7944-mainline-v4-2-f88b5ec4baed@baylibre.com> <20240303134359.16d5e5f1@jic23-huawei>
In-Reply-To: <20240303134359.16d5e5f1@jic23-huawei>
From: David Lechner <dlechner@baylibre.com>
Date: Mon, 4 Mar 2024 08:28:52 -0600
Message-ID: <CAMknhBGYd8v=t-LB7PEz3OzFRKfVXhw=4Tm7RBKbxSoi_QWh-w@mail.gmail.com>
Subject: Re: [PATCH v4 2/2] iio: adc: ad7944: add driver for AD7944/AD7985/AD7986
To: Jonathan Cameron <jic23@kernel.org>
Cc: linux-iio@vger.kernel.org, 
	Michael Hennerich <Michael.Hennerich@analog.com>, Rob Herring <robh+dt@kernel.org>, 
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, 
	=?UTF-8?B?TnVubyBTw6E=?= <nuno.sa@analog.com>, 
	Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>, devicetree@vger.kernel.org, 
	linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Sun, Mar 3, 2024 at 7:44=E2=80=AFAM Jonathan Cameron <jic23@kernel.org> =
wrote:
>
> On Thu, 29 Feb 2024 10:25:51 -0600
> David Lechner <dlechner@baylibre.com> wrote:
>
> > This adds a driver for the Analog Devices Inc. AD7944, AD7985, and
> > AD7986 ADCs. These are a family of pin-compatible ADCs that can sample
> > at rates up to 2.5 MSPS.
> >
> > The initial driver adds support for sampling at lower rates using the
> > usual IIO triggered buffer and can handle all 3 possible reference
> > voltage configurations.
> >
> > Signed-off-by: David Lechner <dlechner@baylibre.com>
> >
> Hi David,
>
> Fresh read through showed up a few more things.  They are all trivial exc=
ept
> for what I think is an inverted error condition which would break
> cases where ref was not supplied in DT.

Thanks. All suggestions seems reasonable to me.

> >
> > +
> > +     /*
> > +      * Sort out what is being used for the reference voltage. Options=
 are:
> > +      * - internal reference: neither REF or REFIN is connected
> > +      * - internal reference with external buffer: REF not connected, =
REFIN
> > +      *   is connected
> > +      * - external reference: REF is connected, REFIN is not connected
> > +      */
> > +
> > +     ref =3D devm_regulator_get_optional(&spi->dev, "ref");
> > +     if (IS_ERR(ref)) {
> > +             if (PTR_ERR(ref) !=3D -ENODEV)
>
> Confused. Isn't this inverse of what we want?

Yes, thanks for catching.

> return an error if we got anything other than -ENODEV.
>                 if (PTR_ERR(ref) |=3D -ENODEV)
>                         return dev_err_probe(&spi->dev, PTR_ERR(ref),
>                                              "failed to get REF supply\n"=
);
>                 ref =3D NULL;
>         }
>
> > +                     ref =3D NULL;
> > +             else
> > +                     return dev_err_probe(&spi->dev, PTR_ERR(ref),
> > +                                          "failed to get REF supply\n"=
);
> > +     }
> > +
>
> > +
> > +     adc->cnv =3D devm_gpiod_get(&spi->dev, "cnv", GPIOD_OUT_LOW);
> > +     if (IS_ERR(adc->cnv))
> > +             return dev_err_probe(&spi->dev, PTR_ERR(adc->cnv),
> > +                                  "failed to get CNV GPIO\n");
>
> Is this optional?  If we don't yet support the case the dt binding talks
> about worth a comment here to say we don't yet support XYZ so this
> is not optional.

For now, it is required since we have only implemented 4-wire mode.