Received: by 2002:ab2:3141:0:b0:1ed:23cc:44d1 with SMTP id i1csp1875581lqg; Mon, 4 Mar 2024 06:33:50 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCWpiIwlQKQAXYrOoGxbbtyKVt8Yg2/a0hfcwXoLuJqESiBa3lyrmoKKnZuaZDQZAmav/1PO5uchv9+dpb5qzhvA+Cflp2YbUr7KMT1nOA== X-Google-Smtp-Source: AGHT+IHFvarU+NWha2nIU0HehZXvJouCnG+1TTJWM5ytPn6uaVOwgB43AQKtDGNFPLZLZdTESXEY X-Received: by 2002:a17:903:228f:b0:1db:9ff1:b59b with SMTP id b15-20020a170903228f00b001db9ff1b59bmr19040158plh.23.1709562830422; Mon, 04 Mar 2024 06:33:50 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709562830; cv=pass; d=google.com; s=arc-20160816; b=gVwcyJ2arnwukdNGaP/i6KfKAPsyBd668tZjayrzmAFghYJzfUz8u+1fVW4XmNrlYh +fb+lT4vm4UGz8QjUtE+1pFc+ayRtzQteLs1Btr1rkjpOrsbrAHvyNjqWxRSvWsCSnsJ QK4lk+NsLGsaT+ifPYTGwdD7h0vqHk/i7xSzlupHgJECJBbomO60ofseS730nuTUZnT2 iBDgehVAarW8RY7RTqfxYzzvfUNHTU9SWPVnPOyLW9Qy/tnsJIv1tByvo4o1PTNIkmKw b0Tm/41QoxEtKGIvo+ID2Ba7OnlO6qw9lNKpxkn1/fpAxTTHn+1JMrc1Id+Mgh3BVFfF zlpg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:subject :references:in-reply-to:cc:to:from:dkim-signature; bh=RGjoSJECsdJPm9gD16FJs5j25b1G2qpElVEQ1b0Ywq4=; fh=inFhDSw7YVv9DdJztd23DJOtjWQfLESLg44S9yjkCiM=; b=yLFz/528KNm2lvFGKeip+phptAaPv1H7v6HJ1lSkBWxaKLqZWTdb2QVhbuXoxyh5qm SQ3slCnJpeEarvjc5O6IST701+1a/Nhjf3eWNHD/4HGlIHcJSZwJMdJ6S+OYPm1p1P1G 2vrKrg7S7H2YLBqy0D5qJD/su6vdyGBWdeo07/5QkUouFCjyT7XIOhYMSb8PWZBQV91n 6Sk9UVHpRe/DsDgN/jmDCyFvm5akfEExZnjrsGcuIqzht+HDgdeOT1bW0B7Ri+3Apvbm aSJgq+RqBBLHvRUNkYXO/dqevJH/d4jYfQPsTEG3ERy0uLgRrkmlUTgX/WRgdrglEeIR vQlw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=URjhSu7S; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-90631-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-90631-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id q10-20020a170902f78a00b001dd013c74dasi3372043pln.39.2024.03.04.06.33.49 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Mar 2024 06:33:50 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-90631-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=URjhSu7S; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-90631-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-90631-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 95D11B275B2 for ; Mon, 4 Mar 2024 13:18:15 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 7B4923D57C; Mon, 4 Mar 2024 13:17:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="URjhSu7S" Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4384E3DBBA; Mon, 4 Mar 2024 13:17:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.14 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709558249; cv=none; b=fPtP7+IFHIG3tic0ICZv1BhB7FhYd5K0YwJYWP94bYT2lkucv+/EY9j8kzhay6MMUNm+5up/z9m5w8DsnK47V3tnHcLgeOj6S7s1REZ3kWTWPRO/yo62KWo/Z+5hvKIanDX/1CQ5vZ3dvzs+9KAXVXn8U9B28164iPdfUxFxiEU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709558249; c=relaxed/simple; bh=a+T5eK5lZetFEjh26lp8lg1Xv27AgHSDJz1gUWzsTqQ=; h=From:To:Cc:In-Reply-To:References:Subject:Message-Id:Date: MIME-Version:Content-Type; b=idKazh5CBt644xgtwuRljyEB6m5RnbnshWuu6IVmGChoEGLcLhuh7tzzm4tGqGcWjteVQL1QlUFEt2ZZrkubtVAla2hYeUVWGGSorLbEoX3oThPm67n/iEgBsy+hG5xD3xoZYka3XCrSER9VhwfnznnAXXmdOcrpG8aI/ZNaXqg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=URjhSu7S; arc=none smtp.client-ip=192.198.163.14 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1709558248; x=1741094248; h=from:to:cc:in-reply-to:references:subject:message-id: date:mime-version:content-transfer-encoding; bh=a+T5eK5lZetFEjh26lp8lg1Xv27AgHSDJz1gUWzsTqQ=; b=URjhSu7Sm5h5UhvUeWfuylJF3nYniNWqpzWVmBDF3nDPyVEk2nuUKd1c V3fMBMMFrOpAi1xSrTYvvmor3G2grqPFkEqykoVHhvN5tvATJQdTS3M2R CRu8zLQWNW0Lv57MWsnARPnKRZLKrVAdnVSLJT85iEMCVcDqgAj0nPeXK qUuzivhqxBDA6comrwb6VdjO+3ACThBIsXNSsOOMxkHyJyOvnf2fNl1FG 2mwmH+IwhAhJKDcgLHs4694SdIvsFMzXA9boSWkilCFtzv6WP6xAcp1KI /iAEhzpAlvih6I0oAVpvEuL3SWSYHvCx5IQmcb8ymD9d+6wmbWfzfc5CE g==; X-IronPort-AV: E=McAfee;i="6600,9927,11002"; a="4213901" X-IronPort-AV: E=Sophos;i="6.06,203,1705392000"; d="scan'208";a="4213901" Received: from orviesa004.jf.intel.com ([10.64.159.144]) by fmvoesa108.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Mar 2024 05:17:27 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.06,203,1705392000"; d="scan'208";a="13656413" Received: from ekohn-mobl1.ger.corp.intel.com (HELO localhost) ([10.246.49.145]) by orviesa004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Mar 2024 05:17:24 -0800 From: =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= To: hdegoede@redhat.com, markgross@kernel.org, andriy.shevchenko@linux.intel.com, Srinivas Pandruvada Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <20240229002659.1416623-1-srinivas.pandruvada@linux.intel.com> References: <20240229002659.1416623-1-srinivas.pandruvada@linux.intel.com> Subject: Re: [PATCH] platform/x86: ISST: Allow reading core-power state on HWP disabled systems Message-Id: <170955823884.5357.9018605202965437681.b4-ty@linux.intel.com> Date: Mon, 04 Mar 2024 15:17:18 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: b4 0.12.3 On Wed, 28 Feb 2024 16:26:59 -0800, Srinivas Pandruvada wrote: > When HWP (Hardware P-states) is disabled, dynamic SST features are > disabled. But user should still be able to read the current core-power > state, with legacy P-states. This will allow users to read current > configuration with static SST enabled from BIOS. > > To address this, do not call disable_dynamic_sst_features() when the > request is for reading the state. > > [...] Thank you for your contribution, it has been applied to my local review-ilpo branch. Note it will show up in the public platform-drivers-x86/review-ilpo branch only once I've pushed my local branch there, which might take a while. The list of commits applied: [1/1] platform/x86: ISST: Allow reading core-power state on HWP disabled systems commit: 959e640cf7b2d456052b346fa50574242ca56aaa -- i.