Received-SPF: pass (google.com: domain of linux-kernel+bounces-90738-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <ae6b1114-1c71-46f0-82e5-23b9f05df1bf@intel.com>
Date: Mon, 4 Mar 2024 15:32:51 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] netdev: Use flexible array for trailing private bytes
Content-Language: en-US
To: Jakub Kicinski <kuba@kernel.org>
CC: Eric Dumazet <edumazet@google.com>, Kees Cook <keescook@chromium.org>,
	"David S. Miller" <davem@davemloft.net>, Paolo Abeni <pabeni@redhat.com>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>, "Gustavo A. R. Silva"
	<gustavoars@kernel.org>, <netdev@vger.kernel.org>,
	<linux-hardening@vger.kernel.org>, Simon Horman <horms@kernel.org>, "Jiri
 Pirko" <jiri@resnulli.us>, Daniel Borkmann <daniel@iogearbox.net>, Coco Li
	<lixiaoyan@google.com>, Amritha Nambiar <amritha.nambiar@intel.com>,
	<linux-kernel@vger.kernel.org>
References: <20240229213018.work.556-kees@kernel.org>
 <20240229225910.79e224cf@kernel.org>
 <CANn89iKeJGvhY0K=kLhhR39NVbaizP2UBk0Vk0r_XCe2XMBZHg@mail.gmail.com>
 <9050bdec-b34a-4133-8ba5-021dfd4b1c75@intel.com>
 <CANn89iLSLPn5PyXNQcA2HO0e5jGYvHKhTh_9_EMmfbTJKZPfbg@mail.gmail.com>
 <77d3f074-8cb6-466b-ab31-a7b0bac659d0@intel.com>
 <20240301093517.428e5b5d@kernel.org>
From: Alexander Lobakin <aleksander.lobakin@intel.com>
In-Reply-To: <20240301093517.428e5b5d@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?d1h1d0tkZUdWa0txZVloeEZmQnYvMS9KSXBWMFFXcmoxM0VNVWs0dFkwQ0VI?=
 =?utf-8?B?RFVva2VHYXh3NVJMNmtsVTI0cTI5b0wzelF1MFZDYnJHNjZWaUVrVW9QMklP?=
 =?utf-8?B?cDc3NXZvSDlURHIzU3o1WTVMdXRjeVRHNW03YmJTZDFnNms1dTZlY2FlejJZ?=
 =?utf-8?B?VUpyd1hPR2pYcGp0Q0RUb2E2L0NCblVCZVBiZm9EOWxmQnFldTdEYk1UVHMv?=
 =?utf-8?B?TXR0dXludlFtU09iVlYvblZKcE9zbllFcWdoTjA2QldpVTdnTnFSSUhGYkZO?=
 =?utf-8?B?YndMSHpUcEt2c2F3b3Y4WTVsWDJhYzVUbmlSRkZiN1diMG90S25hMnpHSGl4?=
 =?utf-8?B?cEo1VTA3WWZKRTd1TTF6ZTVtSDRyQ2JQYkQ3TEdIaFl6RjNuUTFoUmRFTEFJ?=
 =?utf-8?B?Wkx5NytQOXFNQlNaeFNtdUdobVBxZFpZcjNNMGsyTnpDL0VrQWV5QzhQd3VZ?=
 =?utf-8?B?M3A0VjdXZWFNMTQ5ajhKa2Y0WkViRDVZZWI1NUxublMvZ3dYTTNabU5ZZTBw?=
 =?utf-8?B?QkJYazErS3JFVmNLc0ZBMk5tL0pFNDhCeFdjbEgwY0IrZTNUdldhVWdIRnU4?=
 =?utf-8?B?cU9IZ3A4cGI2QkNOeHlkNkZJMC9jb2ZwNFc2SHcxa3lSem9QTGxLbzYydHB2?=
 =?utf-8?B?eGFGcGpjdjRGTlo4MHVleEpZb2hZZWNCVGxzL2czSUhENFdZcFZ1bFp1TG9u?=
 =?utf-8?B?Vmo0Q0JJcFpKQ3EzM2diandmc2wreS9yT3ppR1ZYbDRBZVNoUVVIQzJ2RFhF?=
 =?utf-8?B?S2V5aEo0OGRZeU9hcm41bmdHRFI4RlllUzVzNzJvNmliblIyWmFiTW1Wb3F3?=
 =?utf-8?B?VnZPR2dpbzNDS3BPOWM3QzJJV3pGN29RZ2FvTTJZcTZzL3J4QUdndDZkdFJL?=
 =?utf-8?B?bFg1Q00yR0RZRjhqOHFQcm8vc0Zoc1o3VndTWnlacUdsaDlOdU9FcVpXUy9P?=
 =?utf-8?B?d1pFNFlHTlhoMk1HdTE0dlo0V24xRHZzNGQrSDRsTWVpMmNpcVNXVWN0WUM2?=
 =?utf-8?B?YmRqM0Q4bjR6dkl3aEMvOFFTMndLZVMzT2N1OTJJeFdkMkZDV0ZCY2QvTFp3?=
 =?utf-8?B?K1hNbUxQYmVsN2tyNUFqem4wUUVNNWxOYy8vckl2YVVpMjk2NXRIaWVScHM0?=
 =?utf-8?B?MVpRejJKZUVaaHBQSDNxam5rS1BYOUFOVTVnc0xLbzRMSzJua3dwdzFvTDBn?=
 =?utf-8?B?ZzNCTk56U3ZtTW9HZnhXV3BKOUNYWUptYmpnWExjdXhwbHBicEpkTjdvOXhq?=
 =?utf-8?B?WVptL2NndHVZOGJRbW4yTmRSODVVREhEdWh4eHA2Q09hQm81REQxbGJJdzEv?=
 =?utf-8?B?SEJVM2hFN2w1ejQ2OGVmakR5MlJRemFpUDVuU1lBUVY0M24ybktsV2MvTkdu?=
 =?utf-8?B?YS9hSm5iWXlaMWtHZ3dONHo3b1BQTVVFYmc2Y3dqcGZQQktMMmcybElNanJh?=
 =?utf-8?B?Nk94VXc2SERIZ25wMHFKbUlhemRjY0MrQ2V5UVFNTWFzWWlLK1piT21VTS9P?=
 =?utf-8?B?UkUrTUZqWnJ6WWoyeVFUa2pNK1BTQ1dEdUxhMFN2dFEyNVBzWHBUdHNQTkg3?=
 =?utf-8?B?UlJrQXY1bXFGT3VRVkhzQ1pVNWNncUNNajhKZEV4cWFPd00xaC9YelRrYThF?=
 =?utf-8?B?NzRKeGxWNm94SVJPMmQyK3V2bHpaLzZRSktnWU9NbkZwcnRqelZIV3J6ckZu?=
 =?utf-8?B?V1Fhd3dpN0R2UGx6RUIvSmgrTkk5MDQ4RHVtOUhZYTVFZHRDRHVuSGc4VmI0?=
 =?utf-8?B?NWtlYXQrS0ttYThHM2t2UXRjTmRxMmlodHlkRUF5Y1Y2d1RZTHRycHFUL00x?=
 =?utf-8?B?VmlxbW4wYnpHak9Bb2wvVTZoMTQzMXlzaTkzbmRzM25pd283Wnp4ODRadGg4?=
 =?utf-8?B?dWZGSUhYVDBYSHphM2lvUkxJdXQ5MERDUnNxSmd6QkswbFN2TUlTRVdXTVhm?=
 =?utf-8?B?dW5JbFRjSjR6dmlCRWg0VE9OSjFzZGY2cU5QNms1Smthbm5RN1lyeFI4UGNh?=
 =?utf-8?B?SGRaNG9ObVJhKzVEenB6YllHTyt4ZGlBRGk5Ukxwa1NVaFFyUGlaS01DcHlz?=
 =?utf-8?B?NG5CNE01b3lGdWdkL1Z0Y0JuSFdiYXRMaTd2WHBtRzhlbVdkRDVHUjg0aldy?=
 =?utf-8?B?eWpxbXdCR1VRd3NiTzJlUTUwKzNaemw1RDg4OHBpbGJRTUVGS2tod3k4K0J6?=
 =?utf-8?B?TlE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: a7ba5a97-62e6-4110-fd33-08dc3c581ffd
X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB8718.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Mar 2024 14:33:57.3960
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: E1ECCZrC49g1UqobHA9f5XFC4nxu/bZgBjlBtnWSAmuB0+7cE0ISkXnyez+P2irAfCSm7sbu03buY3mV/JBTAmpDYziJgwO9ciiMgMh1XiY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB6906
X-OriginatorOrg: intel.com

From: Jakub Kicinski <kuba@kernel.org>
Date: Fri, 1 Mar 2024 09:35:17 -0800

> On Fri, 1 Mar 2024 15:30:03 +0100 Alexander Lobakin wrote:
>> I like the idea of declaring priv explicitly rather than doing size +
>> ptr magic. But maybe we could just add this flex array to struct
>> net_device and avoid introducing a new structure.
> 
> 100% I should have linked to the thread that led to Kees's work.
> Adding directly to net_device would be way better but there's
> a handful of drivers which embed the struct.

I think it's okay to embed a struct with flex array at the end as long
as it's not used? Or the compiler will say that the flex array is not at
the end of the structure?

> If we can switch them to dynamic allocation, that'd be great.

It's mega weird to embed &net_device rather than do alloc_*dev() >_<

> And, as you may be alluding to, it removes the need for the WARN_ON()
> entirely as well.

Thanks,
Olek