Received: by 2002:ab2:3141:0:b0:1ed:23cc:44d1 with SMTP id i1csp1893429lqg; Mon, 4 Mar 2024 07:02:41 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCUHKxpoLYzMKX1/qGi2sCfgBAJxqMm1BKiCnVJtKOK2YyHYZ84ipWdXBM1JxZE5IfMPEzNhvgWegSXGsQQZk5elkrD9lSfU4A9k4AcggQ== X-Google-Smtp-Source: AGHT+IFYglTJrxphyfD2HGLPPvl2ye2zUW10okHc+swb/dNMNoO9CNcGANSb9yy4GwoN9XFRQxjS X-Received: by 2002:a05:6102:2a74:b0:472:693b:d8c with SMTP id hp20-20020a0561022a7400b00472693b0d8cmr4721464vsb.23.1709564561175; Mon, 04 Mar 2024 07:02:41 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709564561; cv=pass; d=google.com; s=arc-20160816; b=ZIShKSg514nLPmK592q2Fgf7U5fG3h1zLRLIsPt804tw2USI1mG/5qaTpmgTobZgSg prtl4/OHOIp7VgtsDo4ritkGLs8UU9hoS/7EE0PARxSRSfdwlWYN7dCtOiNkEpGZEdes oQUNHDjaqNS4NboZcHjDw/51Q/6qe1VmqItcJmKuIBGzZlTTE/NHUEhXriCLjPEmI/0t tTTqw+EbTCZZd7uJvNT79UCZ/ohSp515YZffSxdKRI2nVh4Hjz8qTUTJNO8v0tT8MDIX BmBxacb3plukwBNtLwJFhDTyj5fNUXYWZ7QbeCAOPdhPo1Zc/SjkJvXabRxr4BDeRR4z 5Mew== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=8sztT78mA4ZXeKKIX005xkpR3DIfUvvOXL3CwBXH6s8=; fh=RuNgEoURqFrCVMoi4bJ1UZ2A9FZKv+cWBr7TniMooqk=; b=VrVottpa7XTKrexqqZEtFkrpu0GfI+LbyQ+i3yyECkwiNNgm9Ce+ltfrKZJAd3JggI gQnGmaeLKD/nhSqVoskUgL+S9U1+Aw9TneJxewXDj1aYYyvmdEKGfc+oo0RTqs16mqOU Y8bqHp74x8sjqDhr15IMFDyVrjPY/ELFb7TZR3pzLCss+NOh7jvFDMDvx5zy2+TwRrxp tzhjGNlBUXfOjuxDehV5TytIxSywqfg5/kO482P7uuTW+dAS7lOkY5fO9fl5kqT7PAXM DSMy/yBWLfm0UY4Rd4FkUw6TbAhrfqSmDsauLrEzwJVZXD2+KWCWEGSbTs22DHWiYF8T zaLw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=q3AhMCVW; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-90770-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-90770-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id dc32-20020a05610255a000b004729883a4fcsi1010161vsb.707.2024.03.04.07.02.40 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Mar 2024 07:02:41 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-90770-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=q3AhMCVW; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-90770-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-90770-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 0110D1C2138E for ; Mon, 4 Mar 2024 15:02:34 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 27D984654E; Mon, 4 Mar 2024 15:02:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="q3AhMCVW" Received: from mail-lj1-f171.google.com (mail-lj1-f171.google.com [209.85.208.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 74B6945945 for ; Mon, 4 Mar 2024 15:02:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709564547; cv=none; b=QYQ5q8Vo3h+bG0Vg/cLAk39Lu+3Wk/fJMOgo7HGxTV2+vH8V/Vfj5SUz7jAZ3xxKd5dCbdiN81Q2x4euH+otXdIaCe+UJiNpzANVwXVV0nbaqBtGiIq1eUPHV/ZVSmP0prVoQpZ9Bf945gqcZyuEi1vOPAJUQPeuDy/eI+7UT0M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709564547; c=relaxed/simple; bh=A76FdofcX5bcO2jPo3YyAVMPAw8wYMo2MIlnOzf6Tek=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=UYPT+e+f+0HV1+93Lu6zyjevY0Xq77B+KhBHJCmYz3Mv1B9Z/BWIDy3uBUUTX6MMhtltWQDoFw2TAythDnRbgNuB2hX/NZiFXUz7/wmjQ+kgGmjX6kx8VbEDqZNqLpU1bXjjuJLZE2eUkS0artiO4HQb+3d0uFq/WONOczDPcUQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=q3AhMCVW; arc=none smtp.client-ip=209.85.208.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-lj1-f171.google.com with SMTP id 38308e7fff4ca-2d288bac3caso54275461fa.2 for ; Mon, 04 Mar 2024 07:02:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1709564542; x=1710169342; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=8sztT78mA4ZXeKKIX005xkpR3DIfUvvOXL3CwBXH6s8=; b=q3AhMCVWdVcqS6FwV3zLYFG+qZbpNDBWsUeZSAXOZEjXYfBaHI/rO0B2Cr3L2o95ev cFBcRGTy+fKVHrcXUg2S5gc1oETOEr5o+bnvKqYjTZ6Ri94ze6BcQMbULn59Eu49KseX c7kxWjykf3eDTDH4qRwRJK8mdsmyKDowP9LdOZevMHRMwzHqF9+EKpa1bsNjq/cKKz46 QHP4i1EMNntee6w+E4kyApX9d9piqTJGYDN92VfGc3WbNx83FNz/GY2z98S4RHBu472f i2qFaknGkkkJOb5UcyytJmADJeWftle2YGJzUFNG+P06tmXOH2f4nS+o3EavQ4CSCcsY UfpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709564542; x=1710169342; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8sztT78mA4ZXeKKIX005xkpR3DIfUvvOXL3CwBXH6s8=; b=mbPz3tEc4hPqixHl2pYBHD6smjqtOjTXTnfJii+620NhoNwjqCifOCrXmWwGwKIR0+ ZgSuTGsSlCKUHyDZK5COrs9ZNZ4uKJAYN0ReqfX+VsksHEuXW7izrawvho/3XJPNBagO LPnKmRPDE9kAnL9F2LEikDN9CXWjlYhYpVOiXR5/wgkUhbqaixQtVOLc229t/OQHjK24 0ijiRZjn6MMBC9G1cu4GzQkMg/gCK5+Xua60Eh9eW5xsQqGrnxuJK4EaMRWC/N61y3L+ xPnNDChCNZvnh48a9XCMLcqk20E7LN7acYXupbM8fQcHJYv0kMHctViA/Y5cdgDnVeVq Y3PQ== X-Forwarded-Encrypted: i=1; AJvYcCViYiLQBYWESCSKOaDdUYseaQU1cqtqe/HxxSUHqhs47/JdavzBbkOCtk/BytwohVe+N5cXF6mcUJgDWxW64TurIGJucOj0Woq9Dqo7 X-Gm-Message-State: AOJu0Yw0rcvEyeIwhEoSa5R5Uk2WGixjPx3C0joVmcxKKyhs0b66oS+j lsTcgX2HWcBZsJ5sS0u0KEqAb9DeWGfXbtQVMGLLYVMvtjbgTckMEvM534kMHgg= X-Received: by 2002:a19:f603:0:b0:513:2137:a231 with SMTP id x3-20020a19f603000000b005132137a231mr5552748lfe.67.1709564542511; Mon, 04 Mar 2024 07:02:22 -0800 (PST) Received: from [192.168.1.20] ([178.197.222.97]) by smtp.gmail.com with ESMTPSA id w11-20020a17090652cb00b00a44879da0f3sm3934073ejn.143.2024.03.04.07.02.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 04 Mar 2024 07:02:21 -0800 (PST) Message-ID: <0c957a95-9f82-41c2-8e2c-0b5bf4b061a4@linaro.org> Date: Mon, 4 Mar 2024 16:02:18 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 2/2] pwm: sophgo: add pwm support for Sophgo CV1800 SoC Content-Language: en-US To: Jingbao Qiu Cc: u.kleine-koenig@pengutronix.de, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, linux-pwm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, dlan@gentoo.org, inochiama@outlook.com References: <20240304085933.1246964-1-qiujingbao.dlmu@gmail.com> <20240304090248.1247215-1-qiujingbao.dlmu@gmail.com> <91f0a339-ac0e-49df-bd26-dbfe1485308f@linaro.org> From: Krzysztof Kozlowski Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 04/03/2024 14:40, Jingbao Qiu wrote: > On Mon, Mar 4, 2024 at 6:15 PM Krzysztof Kozlowski > wrote: >> >> On 04/03/2024 10:02, Jingbao Qiu wrote: >>> Implement the PWM driver for CV1800. >>> >>> Signed-off-by: Jingbao Qiu >> >> ... >> >>> + >>> + ret = devm_add_action_or_reset(&pdev->dev, devm_clk_rate_exclusive_put, >>> + priv->clk); >>> + if (ret) { >>> + clk_rate_exclusive_put(priv->clk); >>> + return ret; >> >> Please test this path - you have double put. >> > > Thank you for your reply. You're right. If the > devm_add_action_or_reset() function > fails to add an action, it will call the action. > > By the way, if I need to resend the patch, should I wait for the > maintainer to review it, or > should I immediately correct this error and resend it. I recommend one patchset per day. Best regards, Krzysztof