Received-SPF: pass (google.com: domain of linux-kernel+bounces-90916-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Mon, 4 Mar 2024 17:15:52 +0100
From: Alejandro Colomar <alx@kernel.org>
To: Oliver Crumrine <ozlinuxc@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-man@vger.kernel.org,
	netdev@vger.kernel.org
Subject: Re: [PATCH] ip.7: Add not supported by SOCK_STREAM to socket options
Message-ID: <ZeXzuWVmC9AnsECt@debian>
References: <hxiq3upwxs3j5mc5arwlx4jriqm7fq5z54wroc4h4kqcq4gq7m@uwnoq2vnkhup>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="ux3VpOsCkBw0zK1k"
Content-Disposition: inline
In-Reply-To: <hxiq3upwxs3j5mc5arwlx4jriqm7fq5z54wroc4h4kqcq4gq7m@uwnoq2vnkhup>


--ux3VpOsCkBw0zK1k
Content-Type: text/plain; protected-headers=v1; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Date: Mon, 4 Mar 2024 17:15:52 +0100
From: Alejandro Colomar <alx@kernel.org>
To: Oliver Crumrine <ozlinuxc@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-man@vger.kernel.org,
	netdev@vger.kernel.org
Subject: Re: [PATCH] ip.7: Add not supported by SOCK_STREAM to socket options

Hi Oliver,

On Sat, Mar 02, 2024 at 01:19:42PM -0500, Oliver Crumrine wrote:
> It was not made clear in several socket options that they were not
> supported by SOCK_STREAM; this patch fixes that.
>=20
> Socket options not supported by SOCK_STREAM are handled in the
> ip_cmsg_recv_offset function in net/ipv4/ip_sockglue.c. The function is
> called for udp sockets, and indirectly by ping and raw sockets, but not
> for TCP sockets, as they don't support these options.
>=20
> Signed-off-by: Oliver Crumrine <ozlinuxc@gmail.com>

Could you write some small example programs demonstrating that these are
not supported?  I'd like to check it with a small program, if possible.

Have a lovely say!
Alex

> ---
>  man7/ip.7 | 9 +++++++++
>  1 file changed, 9 insertions(+)
>=20
> diff --git a/man7/ip.7 b/man7/ip.7
> index 2b4b06324..104e65feb 100644
> --- a/man7/ip.7
> +++ b/man7/ip.7
> @@ -828,6 +828,9 @@ is not zero, the primary local address of the interfa=
ce specified by the
>  index overwrites
>  .I ipi_spec_dst
>  for the routing table lookup.
> +Not supported for
> +.B SOCK_STREAM
> +sockets.
>  .TP
>  .BR IP_RECVERR " (since Linux 2.2)"
>  .\" Precisely: since Linux 2.1.15
> @@ -989,6 +992,9 @@ in which the kernel returns the original destination =
address
>  of the datagram being received.
>  The ancillary message contains a
>  .IR "struct sockaddr_in" .
> +Not supported for
> +.B SOCK_STREAM
> +sockets.
>  .TP
>  .BR IP_RECVTOS " (since Linux 2.2)"
>  .\" Precisely: since Linux 2.1.68
> @@ -998,6 +1004,9 @@ ancillary message is passed with incoming packets.
>  It contains a byte which specifies the Type of Service/Precedence
>  field of the packet header.
>  Expects a boolean integer flag.
> +Not supported for
> +.B SOCK_STREAM
> +sockets.
>  .TP
>  .BR IP_RECVTTL " (since Linux 2.2)"
>  .\" Precisely: since Linux 2.1.68
> --=20
> 2.44.0
>=20

--=20
<https://www.alejandro-colomar.es/>
Looking for a remote C programming job at the moment.

--ux3VpOsCkBw0zK1k
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIyBAABCgAdFiEE6jqH8KTroDDkXfJAnowa+77/2zIFAmXl87gACgkQnowa+77/
2zJe2Q/3SJ6w3CPhRqqEtV98dUTnuRY47cAGYcQKTUTLUii6nI32EPqc2+jBRIQx
SEUqj/JK1aRQ72wr9cAIaSHV6qu6Xuk2NXtO7+Abur+njoBuQDwq7Az9nspihvnE
txUmwZJqWOewqcpTZdgqWa5AuQbF9ksd12lsAPAO+eU3vJGSFJTCc/dRXrsM5d6r
8d9VEmVIskDJoTWDnt88bpt3ozxWhaFK217VpOiR0L5o/6OTV1Ho4xfUOujRnysf
AKqT1L95b9RhtpmRSaCTAkl7NIDf5UIfEeLKK1gJOBO19w11g0wi9TvICEGMvopH
GuKvdsPvkO6iQp83WUVK7SeYY3c7TcG2sk6A2JJpIvvkc3CzbxibE4X0lBRceqQj
oVkb5xLiQ91qpNlQY2P4Ixo1AvwSJjkFzvnnbOvM6/lYducs425tcBAsNsAwp0a5
xXm7crlvxXmBxsqfmddIGuCMjilLb0sCn0gaCKk9bYVaOTwWLSUsx2H0gdRMVhcH
RthLFZyDJoHNvocwOsgwKBCtMf1wBgRI5be4qlE8X6yTYSl+gF3+3ujevU/8e7bK
k+3VVShtn22ycP23Tj0oU9jyVhx9IUIcP+7xwxEpnQle34FSVl4JNK/faZpZLlAz
Jh9FjkFDfUzsd/w7j6QjC8UZY8/h7J56y86bWzZd7IqQe9jOvQ==
=AgFf
-----END PGP SIGNATURE-----

--ux3VpOsCkBw0zK1k--