Received: by 2002:ab2:3141:0:b0:1ed:23cc:44d1 with SMTP id i1csp1956594lqg; Mon, 4 Mar 2024 08:36:33 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCV847poZwuf+TR1xWYF9WPWxNNSyQkxqMK97qTP/lfUeldNiZfvURpxI5U7Fr11T7OGptyPungfO4mMJa4t91LA5azJITCfgEel2y+AAw== X-Google-Smtp-Source: AGHT+IEXp6qZSx/ZJOnm+wLeH6g2LV7RuYqrqXndNWRIVWeKFgrhfrJ/2349Y61d6vh9KOQnd4Ve X-Received: by 2002:a05:6214:4a5a:b0:690:7032:ddca with SMTP id ph26-20020a0562144a5a00b006907032ddcamr3259082qvb.9.1709570193298; Mon, 04 Mar 2024 08:36:33 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709570193; cv=pass; d=google.com; s=arc-20160816; b=qHlZyVVejvLZyPEgHA6HLhri9IcQTAo32dyVvmKFpW0LQ/LRSw8Hhf4ZeATGX49l8e G1qyPCtX1rFR01IwuX3vKFGUJhr7FW21MpHyxyprE1UHsY/whzvgnFwNXMSm2yKJqCLb Z+eKy4RZ1jpVFaSZCPod1JKGmIeSZEw5Fs/hvhbiQQkpq8gwwj0+NNCCjVRmt8XdSXqa bR7olFv6BnwqeYDBWwlQDw/kq5sjfwVzPnshJ7C72AD5Nihdm8mSY0ObHJi3oiPselnS 1cbesWEl7OD7hgTRlkr5Mp5ghZS9OmW+Bo1R6ii14fqnqdwG1mFLB3XSuw8X8U1G22WL fP/Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=LzcPKxdLfxDJDaEM0sz7dr8HR9JOszPehXHWEMW+Aow=; fh=7zD1SnScMEhYWd1NpcoS5xUxoP7QycdhDV/SmPULW4Q=; b=MoDC93PZLglRq47ezByGykD7Acl5jDMxLcrJ0iy2MfeMM8pQFPDP5AQloWlSbHDaGE SCnU0Fmj7SJfCGB/SvPe8dYxyI46v7yXNPk8cixN5y1WI/L9xP4tD9OifNZFJW6JTGek BXZhSmoygX54YBMUSqIYpLiOHsrvBVV33mdwOzp9D0RhpVTuGIDPW2Ezppdu0HWYtQHu yfxE2ca62SVuZZ6QsMRzJDcszDuQwWGMUpuoBtG2Su9YO1aVZQ9C2dNgTIQYzR71iyZb ssslggFH91dYHoqQ9+V3wk++zAZ60Y4gtfjqyHIEYDftD9hahkdvbSAzmXREz57pHW7/ EZ/Q==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="iF/urOTz"; arc=pass (i=1 dkim=pass dkdomain=linuxfoundation.org); spf=pass (google.com: domain of linux-kernel+bounces-90942-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-90942-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id jm10-20020ad45eca000000b006903e283168si9823448qvb.251.2024.03.04.08.36.33 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Mar 2024 08:36:33 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-90942-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="iF/urOTz"; arc=pass (i=1 dkim=pass dkdomain=linuxfoundation.org); spf=pass (google.com: domain of linux-kernel+bounces-90942-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-90942-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id E81851C20CE6 for ; Mon, 4 Mar 2024 16:36:32 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 3CC8E4CB54; Mon, 4 Mar 2024 16:36:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="iF/urOTz" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4DEC42562F; Mon, 4 Mar 2024 16:36:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709570185; cv=none; b=n4+mvXxvSdLuV3FWbE2psRpMTnYZrpo3uYDMthWntdWZqj2btYBRYtnOxj4T1J85wkOXmeBH26uA1xrjiPPv5YPntVMc7Lo1zYpEdJggwQskBL77bjE6xLghxEjt4Qt0doA1YIHe/OBd+gH2MBgRuRXWFOh8zpPrpUJmNyOdohE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709570185; c=relaxed/simple; bh=7M33YsntfZa4IiNprZkqRmmM+5r+jQjCaEFeJP0s3ws=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=kNq33lE1s0amrK9u5r0R6C+/8OG2I/EQq8+2m/8JeQGVZJpF1VcySpid+zz2QvSHWBG1lt86TU1TqaQxiqUFT4L6KEFAZvpPFvvKotDEuzuiLj8nViT8caUBxyHv2fu3KOhCiwpD5BOgFOyWvzE3ADD57cYmhOUas7Lc7uKzXko= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=iF/urOTz; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6ACD0C43390; Mon, 4 Mar 2024 16:36:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1709570185; bh=7M33YsntfZa4IiNprZkqRmmM+5r+jQjCaEFeJP0s3ws=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=iF/urOTz40HrKXMc+wCyCU7K3MS6wYFdCWzG2fGrbgIZSd6LSCZfC24mgfbBiEoAZ m6v9cVX7vrATsDc4MB3EZ2gwAnKMb5aUW6j7xTc6LSeMyJ5Q/F+0myLq4zYFPNv4xW 1UUSusN1DjfOVqmq0BCrqmd43OY2A8rNSwxnQKxg= Date: Mon, 4 Mar 2024 17:36:19 +0100 From: Greg KH To: Alan Stern Cc: Sam Sun , Tejun Heo , linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, "xrivendell7@gmail.com" , hgajjar@de.adit-jv.com, quic_ugoswami@quicinc.com, stanley_chang@realtek.com, heikki.krogerus@linux.intel.com Subject: Re: [Bug] INFO: task hung in hub_activate Message-ID: <2024030428-graph-harmful-1597@gregkh> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, Mar 04, 2024 at 11:15:24AM -0500, Alan Stern wrote: > Third, this must be a generic problem. It will occur any time a sysfs > attribute callback tries to lock its device while another process is > trying to unregister that device. > > We faced this sort of problem some years ago when we were worrying > about "suicidal" attributes -- ones which would unregister their own > devices. I don't remember what the fix was or how it worked. But we > need something like it here. > > Greg and Tejun, any ideas? Is it possible somehow for an attribute file > to be removed while its callback is still running? Yes, it's a pain, and I hate it, but I think SCSI does this somehow for one of their attributes. I don't remember how at the moment, and I can't look it up (am traveling), but this should be a good hint. thanks, greg k-h