Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753273AbYADNmP (ORCPT ); Fri, 4 Jan 2008 08:42:15 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751825AbYADNmE (ORCPT ); Fri, 4 Jan 2008 08:42:04 -0500 Received: from gepetto.dc.ltu.se ([130.240.42.40]:44873 "EHLO gepetto.dc.ltu.se" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751522AbYADNmD (ORCPT ); Fri, 4 Jan 2008 08:42:03 -0500 Message-ID: <477E379F.4000103@student.ltu.se> Date: Fri, 04 Jan 2008 14:41:51 +0100 From: Richard Knutsson User-Agent: Thunderbird 2.0.0.9 (X11/20071115) MIME-Version: 1.0 To: Mathieu Segaud CC: akpm@linux-foundation.org, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] [Coding Style]: fs/ext{3,4}/ext{3,4}_jbd{,2}.c References: <1199452896-20145-1-git-send-email-mathieu.segaud@regala.cx> <1199452896-20145-2-git-send-email-mathieu.segaud@regala.cx> <1199452896-20145-3-git-send-email-mathieu.segaud@regala.cx> <1199452896-20145-4-git-send-email-mathieu.segaud@regala.cx> <1199452896-20145-5-git-send-email-mathieu.segaud@regala.cx> In-Reply-To: <1199452896-20145-5-git-send-email-mathieu.segaud@regala.cx> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 4706 Lines: 134 Mathieu Segaud wrote: > Misc style fixes from checkpatch.pl > > Signed-off-by: Mathieu Segaud > --- > fs/ext3/ext3_jbd.c | 12 ++++++------ > fs/ext4/ext4_jbd2.c | 12 ++++++------ > 2 files changed, 12 insertions(+), 12 deletions(-) > > diff --git a/fs/ext3/ext3_jbd.c b/fs/ext3/ext3_jbd.c > index e1f91fd..6c96260 100644 > --- a/fs/ext3/ext3_jbd.c > +++ b/fs/ext3/ext3_jbd.c > @@ -9,7 +9,7 @@ int __ext3_journal_get_undo_access(const char *where, handle_t *handle, > { > int err = journal_get_undo_access(handle, bh); > if (err) > - ext3_journal_abort_handle(where, __FUNCTION__, bh, handle,err); > + ext3_journal_abort_handle(where, __FUNCTION__, bh, handle, err); > return err; > } > > @@ -18,7 +18,7 @@ int __ext3_journal_get_write_access(const char *where, handle_t *handle, > { > int err = journal_get_write_access(handle, bh); > if (err) > - ext3_journal_abort_handle(where, __FUNCTION__, bh, handle,err); > + ext3_journal_abort_handle(where, __FUNCTION__, bh, handle, err); > return err; > } > > @@ -27,7 +27,7 @@ int __ext3_journal_forget(const char *where, handle_t *handle, > { > int err = journal_forget(handle, bh); > if (err) > - ext3_journal_abort_handle(where, __FUNCTION__, bh, handle,err); > + ext3_journal_abort_handle(where, __FUNCTION__, bh, handle, err); > return err; > } > > @@ -36,7 +36,7 @@ int __ext3_journal_revoke(const char *where, handle_t *handle, > { > int err = journal_revoke(handle, blocknr, bh); > if (err) > - ext3_journal_abort_handle(where, __FUNCTION__, bh, handle,err); > + ext3_journal_abort_handle(where, __FUNCTION__, bh, handle, err); > return err; > } > > @@ -45,7 +45,7 @@ int __ext3_journal_get_create_access(const char *where, > { > int err = journal_get_create_access(handle, bh); > if (err) > - ext3_journal_abort_handle(where, __FUNCTION__, bh, handle,err); > + ext3_journal_abort_handle(where, __FUNCTION__, bh, handle, err); > return err; > } > > @@ -54,6 +54,6 @@ int __ext3_journal_dirty_metadata(const char *where, > { > int err = journal_dirty_metadata(handle, bh); > if (err) > - ext3_journal_abort_handle(where, __FUNCTION__, bh, handle,err); > + ext3_journal_abort_handle(where, __FUNCTION__, bh, handle, err); > return err; > } > diff --git a/fs/ext4/ext4_jbd2.c b/fs/ext4/ext4_jbd2.c > index d6afe4e..2256c43 100644 > --- a/fs/ext4/ext4_jbd2.c > +++ b/fs/ext4/ext4_jbd2.c > @@ -9,7 +9,7 @@ int __ext4_journal_get_undo_access(const char *where, handle_t *handle, > { > int err = jbd2_journal_get_undo_access(handle, bh); > if (err) > - ext4_journal_abort_handle(where, __FUNCTION__, bh, handle,err); > + ext4_journal_abort_handle(where, __FUNCTION__, bh, handle, err); > return err; > } > > @@ -18,7 +18,7 @@ int __ext4_journal_get_write_access(const char *where, handle_t *handle, > { > int err = jbd2_journal_get_write_access(handle, bh); > if (err) > - ext4_journal_abort_handle(where, __FUNCTION__, bh, handle,err); > + ext4_journal_abort_handle(where, __FUNCTION__, bh, handle, err); > return err; > } > > @@ -27,7 +27,7 @@ int __ext4_journal_forget(const char *where, handle_t *handle, > { > int err = jbd2_journal_forget(handle, bh); > if (err) > - ext4_journal_abort_handle(where, __FUNCTION__, bh, handle,err); > + ext4_journal_abort_handle(where, __FUNCTION__, bh, handle, err); > return err; > } > > @@ -36,7 +36,7 @@ int __ext4_journal_revoke(const char *where, handle_t *handle, > { > int err = jbd2_journal_revoke(handle, blocknr, bh); > if (err) > - ext4_journal_abort_handle(where, __FUNCTION__, bh, handle,err); > + ext4_journal_abort_handle(where, __FUNCTION__, bh, handle, err); > return err; > } > > @@ -45,7 +45,7 @@ int __ext4_journal_get_create_access(const char *where, > { > int err = jbd2_journal_get_create_access(handle, bh); > if (err) > - ext4_journal_abort_handle(where, __FUNCTION__, bh, handle,err); > + ext4_journal_abort_handle(where, __FUNCTION__, bh, handle, err); > return err; > } > > @@ -54,6 +54,6 @@ int __ext4_journal_dirty_metadata(const char *where, > { > int err = jbd2_journal_dirty_metadata(handle, bh); > if (err) > - ext4_journal_abort_handle(where, __FUNCTION__, bh, handle,err); > + ext4_journal_abort_handle(where, __FUNCTION__, bh, handle, err); > return err; > } > Hi Mathieu What about changing the __FUNCTION__ to __func__, while you are at it? Richard Knutsson -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/