Received-SPF: pass (google.com: domain of linux-kernel+bounces-90955-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Content-Type: text/plain; charset="utf-8"
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <20240229165333.227484-7-mike.rudenko@gmail.com>
References: <20240229165333.227484-1-mike.rudenko@gmail.com> <20240229165333.227484-7-mike.rudenko@gmail.com>
Subject: Re: [PATCH v3 06/20] media: i2c: ov4689: Refactor ov4689_set_ctrl
From: Kieran Bingham <kieran.bingham@ideasonboard.com>
Cc: Sakari Ailus <sakari.ailus@linux.intel.com>, Laurent Pinchart <laurent.pinchart@ideasonboard.com>, Jacopo Mondi <jacopo@jmondi.org>, Tommaso Merciai <tomm.merciai@gmail.com>, Christophe JAILLET <christophe.jaillet@wanadoo.fr>, Dave Stevenson <dave.stevenson@raspberrypi.com>, Mauro Carvalho Chehab <mchehab@kernel.org>, Mikhail Rudenko <mike.rudenko@gmail.com>
To: Mikhail Rudenko <mike.rudenko@gmail.com>, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org
Date: Mon, 04 Mar 2024 16:49:46 +0000
Message-ID: <170957098683.566498.5256791258269936446@ping.linuxembedded.co.uk>
User-Agent: alot/0.10

Hi Mikhail,

I love this series. ;-)

Quoting Mikhail Rudenko (2024-02-29 16:53:19)
> Introduce local variable for regmap within the ov4689_set_ctrl
> function. This adjustment eliminates repetition within the function.
>=20
> Signed-off-by: Mikhail Rudenko <mike.rudenko@gmail.com>

Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

> ---
>  drivers/media/i2c/ov4689.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
>=20
> diff --git a/drivers/media/i2c/ov4689.c b/drivers/media/i2c/ov4689.c
> index 56bf1d964e43..1bc00404f3fb 100644
> --- a/drivers/media/i2c/ov4689.c
> +++ b/drivers/media/i2c/ov4689.c
> @@ -580,10 +580,11 @@ static int ov4689_set_ctrl(struct v4l2_ctrl *ctrl)
>  {
>         struct ov4689 *ov4689 =3D
>                 container_of(ctrl->handler, struct ov4689, ctrl_handler);
> +       struct regmap *regmap =3D ov4689->regmap;
>         struct device *dev =3D ov4689->dev;
>         int sensor_gain;
>         s64 max_expo;
> -       int ret;
> +       int ret =3D 0;
> =20
>         /* Propagate change of current control to all related controls */
>         switch (ctrl->id) {
> @@ -603,16 +604,15 @@ static int ov4689_set_ctrl(struct v4l2_ctrl *ctrl)
>         switch (ctrl->id) {
>         case V4L2_CID_EXPOSURE:
>                 /* 4 least significant bits of exposure are fractional pa=
rt */
> -               ret =3D cci_write(ov4689->regmap, OV4689_REG_EXPOSURE,
> -                               ctrl->val << 4, NULL);
> +               cci_write(regmap, OV4689_REG_EXPOSURE, ctrl->val << 4, &r=
et);
>                 break;
>         case V4L2_CID_ANALOGUE_GAIN:
>                 ret =3D ov4689_map_gain(ov4689, ctrl->val, &sensor_gain);
> -               cci_write(ov4689->regmap, OV4689_REG_GAIN, sensor_gain, &=
ret);
> +               cci_write(regmap, OV4689_REG_GAIN, sensor_gain, &ret);
>                 break;
>         case V4L2_CID_VBLANK:
> -               ret =3D cci_write(ov4689->regmap, OV4689_REG_VTS,
> -                               ctrl->val + ov4689->cur_mode->height, NUL=
L);
> +               cci_write(regmap, OV4689_REG_VTS,
> +                         ctrl->val + ov4689->cur_mode->height, &ret);
>                 break;
>         case V4L2_CID_TEST_PATTERN:
>                 ret =3D ov4689_enable_test_pattern(ov4689, ctrl->val);
> --=20
> 2.43.0
>