Received: by 2002:ab2:3141:0:b0:1ed:23cc:44d1 with SMTP id i1csp1966253lqg; Mon, 4 Mar 2024 08:53:42 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCUgNaT7RW4T555bsBRy7xuwztxt4g720r88gbKzvpUp+0PV9yiEmWkB7R1nrRE3u/OScJi3wyvpi5aZiC4FKj5trnLdxPpL+zwKftRU+g== X-Google-Smtp-Source: AGHT+IG2y574gAvwGbHwCWoSbZUWyb8vBtLzfY+6rloZW6/sitAeU1lYKfyhtg3FYPV+3SBWqZt5 X-Received: by 2002:aa7:c3d9:0:b0:567:38db:8076 with SMTP id l25-20020aa7c3d9000000b0056738db8076mr3188560edr.21.1709571222465; Mon, 04 Mar 2024 08:53:42 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709571222; cv=pass; d=google.com; s=arc-20160816; b=jWxyyPIjpDEnhw2A8a+iiNXmHmO8/emBUNzDKkZPbPSFPEkKURPQl2g1oDqL+4AWZj qYac7xp4QsB9cZMqYXrDOjgxFPMZfcul91muLi3fJViJ0WXL2cV2QxIsyYIEikPE1FCn Cw/W1NqBPZDjNIs6NZK/G5Jahm0JfvE724o4FRcj5a8XQA/Kvm90uMiImmvQ8qZ3aLKF W0oxQDem5J51JMJ2HlK8xc0PfZTygKrcvDhdVEhbfOCQhiT4Ln9WtyC7ewICTxiuPDCY Iq717eT9mSvmgtzsGbDB+lXYXyp3SoXvVnb4Ndljdb7V6ABjpdihrukY5S+/zuTrTuoL lTmw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:list-unsubscribe:list-subscribe :list-id:precedence:dkim-signature; bh=lmfK1qwaZeZanYojHD0RUbXhDuCbIKpAYEoB7wzNyKE=; fh=iFrrRg/RXtcslUwJNnxltE6qe98cHohRT7GkqkIe/YQ=; b=pm+ap3hCrV9arwMiAqNHur8kZn6j7ly7499Q/RKvOpBS/sx3f5FHZYmzgOb1wFP5ZP Sghw6cJOqzpXzGmeqRhzOnIX7mo1d73MgQLW5/4t+Oz1CY3rx5zQxvJ9cZa+SOIXC8lz 8lXtUcVcKBSfq3B1uwhMXPXeoNNz8mvMzbNhzSWq37tVS56JnUMEBzMVqwbXpjM0FjU0 CP90Fimg/m8axhpg9CL29qv078wI3IP6IFA0YVeBRA6mhJ9C/HDLPvV+A84L+J6BnhcL W/MfLIoQA9aXIhRgGKFOa5/dlr3lflgQXT4WdvA8bJcQtRbRwThn3AjvBtEXi/djZxjX 4KnQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=oJHNJCZy; arc=pass (i=1 spf=pass spfdomain=google.com dkim=pass dkdomain=google.com dmarc=pass fromdomain=google.com); spf=pass (google.com: domain of linux-kernel+bounces-90964-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-90964-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id k11-20020aa7d8cb000000b005677a468cefsi171987eds.458.2024.03.04.08.53.42 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Mar 2024 08:53:42 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-90964-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=oJHNJCZy; arc=pass (i=1 spf=pass spfdomain=google.com dkim=pass dkdomain=google.com dmarc=pass fromdomain=google.com); spf=pass (google.com: domain of linux-kernel+bounces-90964-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-90964-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 2E9AA1F213FC for ; Mon, 4 Mar 2024 16:53:42 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 953BA5CDC8; Mon, 4 Mar 2024 16:53:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="oJHNJCZy" Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 159B75BAFA for ; Mon, 4 Mar 2024 16:53:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709571197; cv=none; b=jOMi7AnWT0Zs1T2OvE1WwSMTHmkIVO3Cdt8/IIIv8X/fA1xsSd2KH8oN+pHmWIxsLd9SZBaw6amYhja+D1qOVvEEcZF+LXBihWNkEVe5a4NA0YiE6UGKE3d8Wt+Nc17c0Wa7QTZSN+WiUeqzdzE3YwtC26D/8jsQ5EozPBUYlQU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709571197; c=relaxed/simple; bh=uirtXHt2GRmTN/MJHpx0AE7MnBAQPCAKYbtW//3AYqI=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=IiGC0WfS/zb/rtuXtSUuwG65LexIopUgldEE+uksHfjd6+H/ZwpkTFhNC9enYwqeYL9yQgBgYeu0KIXh9ZrBtmRvROBwFZjZLEa+NCVwdOH3ubOzZkXTm4XGLJTEryx/1B41s+iO9rPfo7ZsVEBJ1YmoMqDbaaqWVPqEVzHqaHo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=oJHNJCZy; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-412e6bb2181so6001355e9.0 for ; Mon, 04 Mar 2024 08:53:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1709571194; x=1710175994; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=lmfK1qwaZeZanYojHD0RUbXhDuCbIKpAYEoB7wzNyKE=; b=oJHNJCZydzgvwwg0pPpvODiubSxP83AXeOYfrOvYNRX1745RjAPD07MslMP/m9h9bf e3eDlVl9yBqdMb56ueaTtMcFXIm6+iauxnmcIbZSo70xHzjrHHcJZoBrHJNMJ/kForqH 7TwD0b1oxFKSEclLU8+bJEcic3qG/iwr3vCfCVSwpde71J5EFyF/LwtqfR4/P8hqGyCo XGxokaKsOuEQ4FpVgFLgDw5Yj9THP2+COyHlHzt1l3i08sMq1+CSWRRxcUtsexcvjJtg LIcdGmRXl+GqZXv0Gmz6P1mDaryOOIdIRdRI7zWrREMx6cm6huCsUc7hQObUGD63hDXi t7Rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709571194; x=1710175994; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lmfK1qwaZeZanYojHD0RUbXhDuCbIKpAYEoB7wzNyKE=; b=PAgMz7bP2ogDVGmsTLokqwXtyd6Z2GDJVJX+9c9LojxKvzMvDZJxa7njMDSctRTXjo hjgm80jQJgCkL2+omPznvatLgKP7hRCDcYedJ/8aQzj4tvI/Hw/S2siKnPAOkqk5FQFO +SkuCN8Ut0CdhfyhWZAVP/OJPU+3h3jQUP6N/TZXPXGDdoEByX4H1ynowXHS28vEEP1S vb20Low6uc+Y3Apj5lhHDLBipe//Bo4vZZldxKgE8kusORee3mMZ3rWvrABUms2EsiHX r2Zv8/OeQvfh0o4GBkxU8JoRPyiu3YJBzB4BN/iDJBVtWbidceKEKZlz4HSio2KkMAWt NWFg== X-Forwarded-Encrypted: i=1; AJvYcCUd83Jz96e4REh4LIoAXhgYoVMDYvrjHvye+dXx2nm9OgdPFoWHzDOWXLTgP5oWExZZCrYSUNO0wCPLhuaSVPnbj/F3nzLwQ7kiuQrK X-Gm-Message-State: AOJu0YxXwYuuhVe5Wrr0gbUuqmCZQjajeWIRyfD13tKjmbtZT2jN0TQ8 jgGWV2O1s+3tObovZpnIScpLEeqfbPjW89+21HH3OjlSsx1bd3bJvtRQeTw1Aij8Ocd6eD1+pYf guFdg85l6GoEwGXN4+xDgslxkdMaNzrf4QYBK X-Received: by 2002:adf:a441:0:b0:33e:4524:e473 with SMTP id e1-20020adfa441000000b0033e4524e473mr993953wra.50.1709571194160; Mon, 04 Mar 2024 08:53:14 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240301044428.work.411-kees@kernel.org> In-Reply-To: <20240301044428.work.411-kees@kernel.org> From: Nick Desaulniers Date: Mon, 4 Mar 2024 08:52:58 -0800 Message-ID: Subject: Re: [PATCH] compiler.h: Explain how __is_constexpr() works To: Kees Cook Cc: Rasmus Villemoes , "Gustavo A . R . Silva" , Miguel Ojeda , Jani Nikula , David Laight , Martin Uecker , Jonathan Corbet , linux-doc@vger.kernel.org, Miguel Ojeda , linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Feb 29, 2024 at 8:44=E2=80=AFPM Kees Cook w= rote: > > The __is_constexpr() macro is dark magic. Shed some light on it with > a comment to explain how and why it works. > > Acked-by: Gustavo A. R. Silva > Signed-off-by: Kees Cook Is Documentation/kernel-hacking/hacking.rst perhaps a more appropriate place for this block of text? Perhaps as another :c:macro: in that file? You know I'm not a big fan of increasing header size, even if it is just a comment. --=20 Thanks, ~Nick Desaulniers