Received-SPF: pass (google.com: domain of linux-kernel+bounces-90982-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <8b412f69-a08a-51cb-8223-ed1933031d5e@amd.com>
Date: Mon, 4 Mar 2024 11:07:21 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.1
Subject: Re: [PATCH v7 0/9] x86: Confine early 1:1 mapped startup code
To: Ard Biesheuvel <ardb+git@google.com>, linux-kernel@vger.kernel.org
Cc: Ard Biesheuvel <ardb@kernel.org>,
 Kevin Loughlin <kevinloughlin@google.com>,
 Dionna Glaze <dionnaglaze@google.com>, Thomas Gleixner <tglx@linutronix.de>,
 Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
 Dave Hansen <dave.hansen@linux.intel.com>, Andy Lutomirski
 <luto@kernel.org>, Brian Gerst <brgerst@gmail.com>
References: <20240227151907.387873-11-ardb+git@google.com>
Content-Language: en-US
From: Tom Lendacky <thomas.lendacky@amd.com>
In-Reply-To: <20240227151907.387873-11-ardb+git@google.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?RUdzVitCR2g0VUpEYUZrOFcvdDJ3UHFoZGpEaW44ZWZuSFZXa1U2a1p4ays2?=
 =?utf-8?B?R2FxTGZSWHVQOXpqNmZwamNidUNORFR2dEN3cXZ4d01pbjJLNUhTZzU1UG8y?=
 =?utf-8?B?WWFtZHYrNFJHL1dCdVpvWkNjcU5nUVFESTR5VVhxVTZWWGRaSkQ4M0dwTlJk?=
 =?utf-8?B?R0tXTy83WFlGUmFFbnhoWXVVNU9MVlF4WTlFWHhrYVBnNlNoUW9ZNERaNUg3?=
 =?utf-8?B?UCt3NXR4emR2anJLbjFsTGt6ajJabmZYRjl1SVF0bXFkTzVZQjBIUlBPUVhG?=
 =?utf-8?B?Tk42V2pxK0M5c3V6MkdublFKTDEwOTh5d1N4azZqeDFtSXJZTS83c0dtSm40?=
 =?utf-8?B?NmxuOEVoVDkzOWk4Yk54NE9LaXdiZjQweTJlU2ZWcTdXRlNpbmpnaURrWEtQ?=
 =?utf-8?B?RmxxY3ZWYTlUYXRqV1lNWVNxdXZLazl6cnhnSExwTE1BUEpTNjF4OGJJZUEr?=
 =?utf-8?B?Sks1RFNkN2NHeTMyUVNqMFhGdHRuZitPUFh4ZEJGUGUxSk1vMEJNdVFjNDJi?=
 =?utf-8?B?YVZnYll6cUJBaEJISlJYMjdlVGpma2hCUDMyeVFTVkNURDVFcXlUamp4a1Ra?=
 =?utf-8?B?WmFqcnIxcys5WmpRbUNiMlVuUU1iYWVMcnBXOW1zZ1ZEbWtxZlpwYytYL0dU?=
 =?utf-8?B?Nzltc25iUTFkNzNiSWRnUXlTZVBrUXJ3OW92eDM4VTUvT2t4T1dacDA4d01z?=
 =?utf-8?B?cmlyNlc5K28vSnYrVG1VZG5lNkVaK2cwa09kdEJQVFA1dmtEZEZlOC9RSE5G?=
 =?utf-8?B?SGpObXdmN1JQazFQZmoyZ2Erbk4zcG5YR0p2Z0JrRTdUakJwN1JkeW9ML1hz?=
 =?utf-8?B?R0tGd1VNU2lOZXFXcDJXWjBmQnlpTGN5bWRxaHF6WU4yVkd5ZEp5eG5zZWdy?=
 =?utf-8?B?S1NXNmVvaEhPOWpOaFJsa1g0Q3YwTFY3SEJQeE9QK0tJbXkzWWlzTnJZYmhh?=
 =?utf-8?B?Q3NZZFluR3dGaVZJaDBQQTBpT2lET0FYR25YMlp3eTdScDZrQ28vemFqQ3pJ?=
 =?utf-8?B?cHA0R2lIc3VBQ0lnUUJidUkveElEdTlIMnhxSVgvQ09TYUVRc2pSdzhhQWpk?=
 =?utf-8?B?T2tTMzNEdjJOZWlDWkZFQ0RCaEZvR0NyNnl1OTEyMU5wZFdob2F1V1NHR0JJ?=
 =?utf-8?B?MGN3U2VtUTNJcFV1SlM0ZW9mdThRVlNFVU1wY2dTWlliZElIb09YUDF0QXZm?=
 =?utf-8?B?UEJFc3RNRnlqdXZNVlZrUmpucGtsZEplbnhhcGJXdFdjUHZpK2FEODVLMVpX?=
 =?utf-8?B?Rm5iVE9aVFhGQ2RNMWhJSnlSSVRuYUZPaEljdCtOdDFFM3RFL2s1YWUzNm1Q?=
 =?utf-8?B?bFo2TWdpeW9kUEdWUGRRY2I0U1NTZlJKRHpWSzZEb3VOK0YzdDZ4NjFncit2?=
 =?utf-8?B?L09uay93LzhXTDBQWlNFQlovUFlYOTdlc2ZnNDZ6TFlYRkV2dHRLWmlSTDFJ?=
 =?utf-8?B?elQ1bHF0SXlPVzdNeXBNSkNvK05VVzRLenhJY1NUTkg0V2cvUTJILzlvNElK?=
 =?utf-8?B?TkxtUnp2eFRHSysvUGdyeWY0cTVVWUhHMW1JT1RXNHRuaTdvRGZSWTFCai90?=
 =?utf-8?B?bDJpWWtxNEp0YU1iYTZHaXJsYTMxd05zcGFJTmhJRU1nak1JSVdhZklsZFV1?=
 =?utf-8?B?UjB0cGpDUlJoajV2bVZrY1VWQUNmZTB2Y2dPcis5MU9hcUFDZU83UnNMYzVt?=
 =?utf-8?B?ZTE2RHQ2NGJ6RllEd3A3N2NhWUhYMlBTQkkrUFE4VlMxaGRWUXFjN2tMQS9D?=
 =?utf-8?B?MlZiYkNmT2pPY1l0OWJSVHNHTUl0dDBjVkZOdFdIMllKYnZ6U3lLenY3OHhG?=
 =?utf-8?B?blhGY1lIeFJUZm1kTkUzdTVOL2VDVHRNbHQvdnAxOGxNejVSdjJyQmx1Yjhz?=
 =?utf-8?B?RUp2Y2s1WlFNRm9tSW1PWGl2S2x4V21uWXZxREhWbUNxQlk3Y252N0FzVzBW?=
 =?utf-8?B?WnZwdkcvR01Pc3lKNDAweFdpOHNPMnY3RXhtSVEwNjZrWlp0N0RpNGxMWWlR?=
 =?utf-8?B?cWhERysvNHJGN0EvODYzQU9odnBodlE4QkJHdElYUFp5LzdZeUMrbG5aNXEz?=
 =?utf-8?B?Rk84eTVuVDNkSll5WjRHdUtiZUg5NmR4NC92WEZGcEc4N0RtVVkxNVJBakZ2?=
 =?utf-8?Q?ouXll/U76TZId60M/0l/MO3ai?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 41acd1e2-fded-4d0f-874b-08dc3c6d9002
X-MS-Exchange-CrossTenant-AuthSource: BL1PR12MB5732.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Mar 2024 17:07:24.6283
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: kdUHZwfPIjPLSR8+pHvnZWlZ83HlygBRA7HcLgrvF22ksET38g139LUNJud+sFUpUccQSn28p2ojEb6n1/7/nw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB7150

On 2/27/24 09:19, Ard Biesheuvel wrote:
> From: Ard Biesheuvel <ardb@kernel.org>
> 
> This is resend #2 of v5 [0] with some touchups applied.
> 
> Changes since v6:
> - Drop flawed patch to move some SME/SEV related calls out of the early
>    boot path to avoid the potential need for backporting patches #6/#7
>    to kernels where SEV support may not be crucial. This problem will be
>    dealt with if/when it arises while doing those backports.
> 
> Changes since v5:
> - drop patches that have been merged
> - rebase onto latest tip/x86/boot
> - fix comment regarding CR4.PGE wrt flushing of global TLB entries
> - avoid adding startup code to .noinstr.text as it triggers objtool
>    warnings
> 
> [0] https://lore.kernel.org/all/20240221113506.2565718-18-ardb+git@google.com/
> 
> Cc: Kevin Loughlin <kevinloughlin@google.com>
> Cc: Tom Lendacky <thomas.lendacky@amd.com>
> Cc: Dionna Glaze <dionnaglaze@google.com>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: Borislav Petkov <bp@alien8.de>
> Cc: Dave Hansen <dave.hansen@linux.intel.com>
> Cc: Andy Lutomirski <luto@kernel.org>
> Cc: Brian Gerst <brgerst@gmail.com>

For the series, tested bare metal boots with mem_encrypt=on / 
mem_encrypt=off and boots of SVM, SEV, SEV-ES and SEV-SNP guests.

Tested-by: Tom Lendacky <thomas.lendacky@amd.com>

> 
> Ard Biesheuvel (9):
>    x86/startup_64: Simplify CR4 handling in startup code
>    x86/startup_64: Defer assignment of 5-level paging global variables
>    x86/startup_64: Simplify calculation of initial page table address
>    x86/startup_64: Simplify virtual switch on primary boot
>    efi/libstub: Add generic support for parsing mem_encrypt=
>    x86/boot: Move mem_encrypt= parsing to the decompressor
>    x86/sme: Move early SME kernel encryption handling into .head.text
>    x86/sev: Move early startup code into .head.text section
>    x86/startup_64: Drop global variables keeping track of LA57 state
> 
>   arch/x86/boot/compressed/misc.c                | 15 ++++
>   arch/x86/boot/compressed/misc.h                |  4 -
>   arch/x86/boot/compressed/pgtable_64.c          | 12 ---
>   arch/x86/boot/compressed/sev.c                 |  3 +
>   arch/x86/boot/compressed/vmlinux.lds.S         |  1 +
>   arch/x86/include/asm/mem_encrypt.h             |  8 +-
>   arch/x86/include/asm/pgtable_64_types.h        | 43 ++++-----
>   arch/x86/include/asm/sev.h                     | 10 +--
>   arch/x86/include/uapi/asm/bootparam.h          |  1 +
>   arch/x86/kernel/cpu/common.c                   |  2 -
>   arch/x86/kernel/head64.c                       | 61 ++-----------
>   arch/x86/kernel/head_64.S                      | 93 ++++++++------------
>   arch/x86/kernel/sev-shared.c                   | 23 +++--
>   arch/x86/kernel/sev.c                          | 14 +--
>   arch/x86/lib/Makefile                          | 13 ---
>   arch/x86/mm/kasan_init_64.c                    |  3 -
>   arch/x86/mm/mem_encrypt_identity.c             | 83 +++++------------
>   drivers/firmware/efi/libstub/efi-stub-helper.c |  8 ++
>   drivers/firmware/efi/libstub/efistub.h         |  2 +-
>   drivers/firmware/efi/libstub/x86-stub.c        |  3 +
>   20 files changed, 147 insertions(+), 255 deletions(-)
>