Received-SPF: pass (google.com: domain of linux-kernel+bounces-91096-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Precedence: bulk
MIME-Version: 1.0
References: <20240304090649.833953-1-usama.anjum@collabora.com>
In-Reply-To: <20240304090649.833953-1-usama.anjum@collabora.com>
From: Justin Tee <justintee8345@gmail.com>
Date: Mon, 4 Mar 2024 10:27:28 -0800
Message-ID: <CABPRKS9KtaD6O61__3Vv73cvd1bxJT+zkeroGnStbPz8pYhmgA@mail.gmail.com>
Subject: Re: [PATCH v2] scsi: lpfc: correct size for wqe for memset
To: Muhammad Usama Anjum <usama.anjum@collabora.com>
Cc: Justin Tee <justin.tee@broadcom.com>, James Smart <james.smart@broadcom.com>, 
	Dick Kennedy <dick.kennedy@broadcom.com>, "James E.J. Bottomley" <jejb@linux.ibm.com>, 
	"Martin K. Petersen" <martin.petersen@oracle.com>, Hannes Reinecke <hare@suse.com>, kernel@collabora.com, 
	kernel-janitors@vger.kernel.org, James Smart <jsmart2021@gmail.com>, 
	linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"

> The wqe is of type lpfc_wqe128. It should be memset with the same type.
>
> Fixes: 6c621a2229b0 ("scsi: lpfc: Separate NVMET RQ buffer posting from IO resources SGL/iocbq/context")
> Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
> ---
> Changes since v1:
> - Use *wqe instead of type to find sizeof
> ---
>  drivers/scsi/lpfc/lpfc_nvmet.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/lpfc/lpfc_nvmet.c b/drivers/scsi/lpfc/lpfc_nvmet.c
> index 8258b771bd009..561ced5503c63 100644
> --- a/drivers/scsi/lpfc/lpfc_nvmet.c
> +++ b/drivers/scsi/lpfc/lpfc_nvmet.c
> @@ -1586,7 +1586,7 @@ lpfc_nvmet_setup_io_context(struct lpfc_hba *phba)
>                 wqe = &nvmewqe->wqe;
>
>                 /* Initialize WQE */
> -               memset(wqe, 0, sizeof(union lpfc_wqe));
> +               memset(wqe, 0, sizeof(*wqe));
>
>                 ctx_buf->iocbq->cmd_dmabuf = NULL;
>                 spin_lock(&phba->sli4_hba.sgl_list_lock);
> --
> 2.39.2

Reviewed-by: Justin Tee <justintee8345@gmail.com>