Received-SPF: pass (google.com: domain of linux-kernel+bounces-91100-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
From: Zi Yan <ziy@nvidia.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: "\"Pankaj Raghav (Samsung)\"" <kernel@pankajraghav.com>,
 linux-mm@kvack.org, "\"Matthew Wilcox (Oracle)\"" <willy@infradead.org>,
 David Hildenbrand <david@redhat.com>, Yang Shi <shy828301@gmail.com>,
 Yu Zhao <yuzhao@google.com>,
 "\"Kirill A . Shutemov\"" <kirill.shutemov@linux.intel.com>,
 Ryan Roberts <ryan.roberts@arm.com>,
 =?utf-8?q?=22Michal_Koutn=C3=BD=22?= <mkoutny@suse.com>,
 Roman Gushchin <roman.gushchin@linux.dev>,
 "\"Zach O'Keefe\"" <zokeefe@google.com>, Hugh Dickins <hughd@google.com>,
 Luis Chamberlain <mcgrof@kernel.org>, linux-kernel@vger.kernel.org,
 cgroups@vger.kernel.org, linux-fsdevel@vger.kernel.org,
 linux-kselftest@vger.kernel.org, Mark Brown <broonie@kernel.org>,
 Aishwarya TCV <aishwarya.tcv@arm.com>
Subject: Re: [PATCH v5 8/8] mm: huge_memory: enable debugfs to split huge
 pages to any order.
Date: Mon, 04 Mar 2024 13:31:19 -0500
Message-ID: <C18F1F9F-A4FC-4F37-9414-A7ED5233E913@nvidia.com>
In-Reply-To: <262E4DAA-4A78-4328-B745-1355AE356A07@nvidia.com>
References: <20240226205534.1603748-1-zi.yan@sent.com>
 <20240226205534.1603748-9-zi.yan@sent.com>
 <082e48c8-71b7-4937-a5da-7a37b4be16ba@arm.com>
 <A111EB95-0AF5-4715-82A4-70B8AD900A93@nvidia.com>
 <7E498B77-6CC9-4FC6-B980-D79EEC548CD0@nvidia.com>
 <0685EC19-CDB8-4CD3-BC39-82DE59B5D10C@nvidia.com>
 <0be630f0-ce8e-4a80-b42f-697ea603cfc6@arm.com>
 <1829EABB-7966-4686-A5E0-F6B6D26C510E@nvidia.com>
 <bd51b366-60b3-4ca5-9634-95dfbc3d1829@arm.com>
 <262E4DAA-4A78-4328-B745-1355AE356A07@nvidia.com>
Content-Type: multipart/signed;
 boundary="=_MailMate_75486190-527B-4A39-BF10-080618AA967A_=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?4q8YuqBttk3Mw/zivQ23A0AUs0KcJc8g+svVlA3Y/IxYJgz+70RsMqing98N?=
 =?us-ascii?Q?XY+RBjAO2/+ei+ualqlWzNfHFSS3YhjaQRYZw5D4dbxN+L2qI8yIxXuFauIW?=
 =?us-ascii?Q?ojVu6Mn2cvqplnuxjlBRvWc6ZQIz9yQEa5c1EDVJTF3dT9kj1cjoud5Luche?=
 =?us-ascii?Q?rkk2PyOxfwRaHOANbagyvm8cAK0KXU4fpHuFoTZQ/xJTGq9VRfWrmtS6oUMu?=
 =?us-ascii?Q?ogTDFLlT7FW+4GHiA5ribYZOdbwvwFonhRMNDjj+ke7pdDSx4ClJX8g8/OTL?=
 =?us-ascii?Q?eYUgENGVhmDX2b56/3rG7Xgt8pVX1/9AKfbuqZKrT6mzsB3VbDLir82O0OvL?=
 =?us-ascii?Q?I7DZirSW+8I1D4ZD4bnRILotQNGjsSDpyK+hqkwjR+Q53LYxAJr3qF1SmSEQ?=
 =?us-ascii?Q?w7dUY34OswBQCkcYIzKI+MSXCUgvYmCxI6BGhTjncuAY/Axe7Rsvu8apgX7L?=
 =?us-ascii?Q?hERwr4qB7X7i+OuZDF5ffysW9VUVt9xLSZwpNqviMHJN54hpLFb8BM2x343z?=
 =?us-ascii?Q?p/Zy2K5oHtsNMnqHARG7CJ6Tj61KBduRgb+9MVJ3ikh8kHu/VX/+Dh4pda0S?=
 =?us-ascii?Q?qriWWEqCRltq33fn9VChtuOCEmzJcW2iiGd4CImFnjbKlwRPqACQi4TjCR8E?=
 =?us-ascii?Q?+dhEHVE26XjZCLO7QCs0lR1scmCWGMlNMa/5+Ygh/7409/jTtqZAxG3IVJm5?=
 =?us-ascii?Q?oqqiAG7AAG0dXDh6u1A2FFGvLpdtpZijf+RwLuhoFKjdo9yYnoIlKI5Yojrh?=
 =?us-ascii?Q?sIoUfY8v0zdm8VaLP/XZE1IkTpGBM13c0I4wHysIsbRWu2isuAGRrIoj2yXu?=
 =?us-ascii?Q?KtyxlkVmwvLeErv5XRcQ84pw2r92m+dresOiHDNyE283sSjcyHyz8mG31383?=
 =?us-ascii?Q?t4AEjQ7lLKX7+QMXgP7Gg3WWBimdKndgORVLREz+lVcOO4MsFY7M3D/hJX4M?=
 =?us-ascii?Q?I1U67SbXcS4ECeoRXSj/madJLzZLJPaxZWQ2pT+pA3V37fygCiZHq7zZYl08?=
 =?us-ascii?Q?oLygxljFgGn6kVXESA2Aa/rHw/bUqpEzPQPxjBNuw5LIhnU3XyZvcPSQ133S?=
 =?us-ascii?Q?/fymz/iJo4wOJI87V2f6pXlJ1ECW9rZYPhEh2KMAZTHtma52ILArJprjHBVw?=
 =?us-ascii?Q?lTtTCaAQR8EmzyWyxNwE0IiC0mhaR559Mv2zbNeVI2nQCsC3jAMt5zy61GwJ?=
 =?us-ascii?Q?p5AIyju+N+jYDuhBgp60iPYcG8755/FozKXw9wlWchGdjJ4Fi69vceLSyrJU?=
 =?us-ascii?Q?5spIDDl2Z1jRwXrAjaeEUV8EeV2aK2k0qe5CbGFYk7vzVJtTG8ggIhC4fifX?=
 =?us-ascii?Q?owFu4q4Vz6fwrMHqk7QmxwGj69nmJ5DpMcT4kRgUDLO3bfeDdCOK29vQovxk?=
 =?us-ascii?Q?tI7g+zYQHaioX3JayACSPxMaFbqoR8GK3oKgOxl5XRCeaRZrH5Gnc8Pa+gsu?=
 =?us-ascii?Q?qFTOcJHwmqNmRbFCPRf/KJ+hT+nWx8mi/w+V798vxExffBTbGsPJh/Dzu+pr?=
 =?us-ascii?Q?RY+l9G8VcguSejRvot5mrCQnztDnBPLe66NwVQbpGulw06trsjoBjMXhSmTm?=
 =?us-ascii?Q?KAz55B0VcllGfc77LqVEmRaDnz8wlSazgvdTJPAN?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 11ef0979-ce77-4310-4257-08dc3c794a7e
X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB5744.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Mar 2024 18:31:21.9372
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: dRgsp0leHWm/oAdMALg3gWdWOVINL055iAkiyZGSceoMwUOFfB68VCYWmyOM+wqS
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB5882

--=_MailMate_75486190-527B-4A39-BF10-080618AA967A_=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

On 4 Mar 2024, at 10:57, Zi Yan wrote:

> On 4 Mar 2024, at 10:44, Aishwarya TCV wrote:
>
>> On 04/03/2024 14:58, Zi Yan wrote:
>>> On 4 Mar 2024, at 4:50, Aishwarya TCV wrote:
>>>
>>>> On 01/03/2024 21:10, Zi Yan wrote:
>>>>> On 1 Mar 2024, at 15:02, Zi Yan wrote:
>>>>>
>>>>>> On 1 Mar 2024, at 14:37, Zi Yan wrote:
>>>>>>
>>>>>>> On 1 Mar 2024, at 4:51, Aishwarya TCV wrote:
>>>>>>>
>>>>>>>> On 26/02/2024 20:55, Zi Yan wrote:
>>>>>>>>> From: Zi Yan <ziy@nvidia.com>
>>>>>>>>>
>>>>>>>>> It is used to test split_huge_page_to_list_to_order for pagecac=
he THPs.
>>>>>>>>> Also add test cases for split_huge_page_to_list_to_order via bo=
th
>>>>>>>>> debugfs.
>>>>>>>>>
>>>>>>>>> Signed-off-by: Zi Yan <ziy@nvidia.com>
>>>>>>>>> ---
>>>>>>>>>  mm/huge_memory.c                              |  34 ++++--
>>>>>>>>>  .../selftests/mm/split_huge_page_test.c       | 115 ++++++++++=
+++++++-
>>>>>>>>>  2 files changed, 131 insertions(+), 18 deletions(-)
>>>>>>>>>
>>>>>>>>
>>>>>>>> Hi Zi,
>>>>>>>>
>>>>>>>> When booting the kernel against next-master(20240228)with Arm64 =
on
>>>>>>>> Marvell Thunder X2 (TX2), the kselftest-mm test 'split_huge_page=
_test'
>>>>>>>> is failing in our CI (with rootfs over NFS). I can send the full=
 logs if
>>>>>>>> required.
>>>>>>>>
>>>>>>>> A bisect (full log below) identified this patch as introducing t=
he
>>>>>>>> failure. Bisected it on the tag "next-20240228" at repo
>>>>>>>> "https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next=
=2Egit".
>>>>>>>>
>>>>>>>> This works fine on  Linux version 6.8.0-rc6
>>>>>>>
>>>>>>> Hi Aishwarya,
>>>>>>>
>>>>>>> Can you try the attached patch and see if it fixes the failure? I=
 changed
>>>>>>> the test to accept XFS dev as input, mount XFS on a temp folder u=
nder /tmp,
>>>>>>> and skip if no XFS is mounted.
>>>>>>
>>>>>> Please try this updated one. It allows you to specify a XFS device=
 path
>>>>>> in SPLIT_HUGE_PAGE_TEST_XFS_PATH env variable, which is passed to
>>>>>> split_huge_page_test in run_vmtests.sh. It at least allow CI/CD to=
 run
>>>>>> the test without too much change.
>>>>>
>>>>> OK. This hopefully will be my last churn. Now split_huge_page_test =
accepts
>>>>> a path that is backed by XFS and run_vmtest.sh creates a XFS image =
in /tmp,
>>>>> mounts it in /tmp, and gives the path to split_huge_page_test. I te=
sted
>>>>> it locally and it works. Let me know if you have any issue. Thanks.=

>>>>>
>>>>> --
>>>>> Best Regards,
>>>>> Yan, Zi
>>>>
>>>> Hi Zi,
>>>>
>>>> Tested the patch by applying it on next-20240304. Logs from our CI w=
ith
>>>> rootfs over nfs is attached below. "Bail out! cannot remove tmp dir:=

>>>> Directory not empty" is still observed.
>>>
>>> Hi Aishwarya,
>>>
>>> Do you have the config file for the CI kernel? And /tmp is also on nf=
s?
>>> Any detailed information about CI machine environment? I cannot repro=
duce
>>> the error locally, either on bare metal or VM. Maybe because my /tmp =
is
>>> not NFS mounted?
>>>
>>
>> Hi Zi,
>>
>> Please find the details below. Hope it helps.
>>
>> Do you have the config file for the CI kernel?
>> - We are using:
>> defconfig+https://github.com/torvalds/linux/blob/master/tools/testing/=
selftests/mm/config
>>
>> And /tmp is also on nfs?
>> - Yes
>>
>> Any detailed information about CI machine environment?
>> - We are running the test using LAVA device Cavium Thunder X2 (TX2),
>> - We have very similar rootfs as - nfsrootfs:
>> https://storage.kernelci.org/images/rootfs/debian/bullseye-kselftest/2=
0240129.0/arm64/full.rootfs.tar.xz
>> - We are using grub boot method over nfs
>> - Additionally Ryan mentioned "Looks like it is failing because he is
>> trying to delete the temp dir with rmdir() but rmdir() requires the
>> directory to be empty, which it is not."
>
> Hi Aishwarya,
>
> Thank you for the information and I am able to reproduce it on a NFS fo=
lder.
> The error comes from that the opened test files are not munmapped and t=
heir
> file descriptors are not closed in the skip path. NFS creates .nfsXXX f=
iles
> for them, making the temp folder not empty.
>
> The attached patch cleans up properly and works on a NFS folder. Let me=
 know
> if it works on your side. Thanks.

Hi Andrew,

Could you fold the patch from [1] to this one (i.e., Patch 8)? Let me kno=
w
if you want me to send it separately or resend the entire patchset. Thank=
s.

[1] https://lore.kernel.org/linux-mm/57259BE4-D4A1-4F57-8AEA-DE526C43DE44=
@nvidia.com/

--
Best Regards,
Yan, Zi

--=_MailMate_75486190-527B-4A39-BF10-080618AA967A_=
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename=signature.asc
Content-Type: application/pgp-signature; name=signature.asc

-----BEGIN PGP SIGNATURE-----

iQJDBAEBCgAtFiEE6rR4j8RuQ2XmaZol4n+egRQHKFQFAmXmE3cPHHppeUBudmlk
aWEuY29tAAoJEOJ/noEUByhUZZ4QAJG+bs1nfanzdPMNhrPjE8hniTxe3LVvQk4b
TBVuCGAbYg9TN3/r0leb5fp5coVDy+dz8w0dt/ejWJ7rKFcbmADeBHYwozUG3zJc
c46zirWuiib8AsAgbPcE9vb5R0nRPW+Rrv+dvtq6tWFpx0R4gCkq/Fiub0xRei2L
o4h4+3o4RHxShiUzLM9Ju6f3QIJ9gQ8DJMyWaZz7RlYl7HVPPnyeYjFz3dRLIxwQ
h3L6+4QP/jLpsoz9xpOoeEicfI1Ic6ob4/lGbYBuE8bFnYEE+Mt2z8IngFi393kn
jpkO53WMdLp7KxeIpVltuaGTsY65E1RbHy9zHlYneUheOK2RxNd5XRsSyZBI3L3a
NUNslNbdh5DCiRUL8hu6J2oQim9b82wg4QGR36vGFK54CxBh1kstmGp/gAGAQzCn
BDcu2qTnyMYpSmx2DKx/Xw7bnA91ESYqClxzZWOkXyyWzHe0+JKPEV5xa2r8eTSy
dnP6d5CfH//apAZ8EC9mNnubL2Nw1EVIlLi2e19hID7DU13afQYXB+/WcxV677vK
ygSVxc2/5POqyoUi39oC5kSbB7z6GbqRucS93bzqsnqkrtf6x7rV8gJxrVmeSpQe
Wh3F5OPSvXqA7OkTYlLGkyr7TMXv8dYq1Lw1YupUH3PbrurqlJOiB9SmH9qR/Vks
oNqKHKIS
=fXyx
-----END PGP SIGNATURE-----

--=_MailMate_75486190-527B-4A39-BF10-080618AA967A_=--