Received-SPF: pass (google.com: domain of linux-kernel+bounces-91140-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Precedence: bulk
MIME-Version: 1.0
References: <20240228170529.4035675-1-irogers@google.com> <36449491-c17b-4d85-a1a0-f5101bdb42e7@linux.intel.com>
In-Reply-To: <36449491-c17b-4d85-a1a0-f5101bdb42e7@linux.intel.com>
From: Namhyung Kim <namhyung@kernel.org>
Date: Mon, 4 Mar 2024 10:58:56 -0800
Message-ID: <CAM9d7cj4R+f3eV2SkDCpLH-X1M6xVqYhY-oyJAAeSvCzdhUf6A@mail.gmail.com>
Subject: Re: [PATCH v2] perf vendor events intel: Add umasks/occ_sel to PCU events.
To: "Liang, Kan" <kan.liang@linux.intel.com>
Cc: Ian Rogers <irogers@google.com>, Peter Zijlstra <peterz@infradead.org>, 
	Ingo Molnar <mingo@redhat.com>, Arnaldo Carvalho de Melo <acme@kernel.org>, Mark Rutland <mark.rutland@arm.com>, 
	Alexander Shishkin <alexander.shishkin@linux.intel.com>, Jiri Olsa <jolsa@kernel.org>, 
	Adrian Hunter <adrian.hunter@intel.com>, linux-perf-users@vger.kernel.org, 
	linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, Feb 28, 2024 at 12:46=E2=80=AFPM Liang, Kan <kan.liang@linux.intel.=
com> wrote:
>
>
>
> On 2024-02-28 12:05 p.m., Ian Rogers wrote:
> > UMasks were being dropped leading to all PCU
> > UNC_P_POWER_STATE_OCCUPANCY events having the same encoding. Don't
> > drop the umask trying to be consistent with other sources of events
> > like libpfm4 [1]. Older models need to use occ_sel rather than umask,
> > correct these values too. This applies the change from [2].
> >
> > [1] https://sourceforge.net/p/perfmon2/libpfm4/ci/master/tree/lib/event=
s/intel_skx_unc_pcu_events.h#l30
> > [2] https://github.com/captain5050/perfmon/commit/cbd4aee81023e5bfa0967=
7b1ce170ff69e9c423d
> >
> > Signed-off-by: Ian Rogers <irogers@google.com>
> > ---
> > v2 corrects BDW-DE, BDX, HSX and JKT to not use umask but occ_sel.
>
> Thanks Ian for the fix.
>
> Reviewed-by: Kan Liang <kan.liang@linux.intel.com>

Applied to perf-tools-next, thanks!

Namhyung