Received-SPF: pass (google.com: domain of linux-kernel+bounces-91164-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Mon, 4 Mar 2024 14:13:27 -0500
From: Frank Li <Frank.li@nxp.com>
To: Manivannan Sadhasivam <mani@kernel.org>
Cc: Niklas Cassel <Niklas.Cassel@wdc.com>,
	"imx@lists.linux.dev" <imx@lists.linux.dev>,
	Jingoo Han <jingoohan1@gmail.com>,
	Gustavo Pimentel <gustavo.pimentel@synopsys.com>,
	Lorenzo Pieralisi <lpieralisi@kernel.org>,
	Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= <kw@linux.com>,
	Rob Herring <robh@kernel.org>, Bjorn Helgaas <bhelgaas@google.com>,
	Jon Mason <jdmason@kudzu.us>,
	"open list:PCI DRIVER FOR SYNOPSYS DESIGNWARE" <linux-pci@vger.kernel.org>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/1] PCI: dwc: Fix BAR0 wrong map to iATU6 after root
 complex reinit endpoint
Message-ID: <ZeYdV3xMWa0nbz3k@lizhi-Precision-Tower-5810>
References: <20231219044844.1195294-1-Frank.Li@nxp.com>
 <ZYFrUWM7JXdv7rtb@x1-carbon>
 <ZYGmpaf18pJgM/qj@lizhi-Precision-Tower-5810>
 <ZYGq6RdCfdhXFF/9@x1-carbon>
 <20240304084841.GJ2647@thinkpad>
 <ZeX7KDuwLWxwb5Kw@lizhi-Precision-Tower-5810>
 <20240304181005.GF31079@thinkpad>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20240304181005.GF31079@thinkpad>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?cU9aVk50MG81eldyaTh2RENJNXV1RU83NStOeXVtcnJuNlN6cFV6Nm5kVFdy?=
 =?utf-8?B?eFpxYzFUYzVmbXk0b25lSHMxVTRzcU4rcVlOZzJ5b2dsTTF3WkRjWVlweW5m?=
 =?utf-8?B?dmZWU2VvM3FnVGRFTTFwV2ZlQ1FOSmdHS2pGSXZVd2dGMU4wZFBQTklXeXRn?=
 =?utf-8?B?MFQyeUNXcVVWb0dzZ0N5RGVsQVcrRFpJOVRyYzFhRkpkeUlwN1I4a2Foa1FT?=
 =?utf-8?B?VzEyRk13cS9uRHZYTHZ2WmJzT0lUdHpTNzZFZGZiTDZwSks0YnNKU3FZdEV2?=
 =?utf-8?B?R3AzK291RDM1bWJZTmxZbS9CckFJWnFEWlJpc1g3ZXcySnZmSXFxTFI1OFgx?=
 =?utf-8?B?ZXJ1ZkF0MURRK1Mvb0pVMXFRZ3lwZXh1dDhvWjRZUUw2ZXFxMGxETjJzUUlM?=
 =?utf-8?B?cFdMWXcyZGUyZkpqYVNtRk55MUdFVHF5MHFRbVF2Nm90Y01kdUNLSDlYSUlP?=
 =?utf-8?B?UFB2RVVPSUVxVmRGZk81bXAzT3kwTTI4WmhhWlR0K3V0N0lYUVVwN1dTblJ0?=
 =?utf-8?B?Q05UNjE4VFUxd2NqTXRmelROeGgxcGRUc0JzS0dBT1JMSU0vbDVha3RNWDU0?=
 =?utf-8?B?WFhzYWZRVlpQK1FjODhBM0Y0OFNpZmwvQmluOExCSDFhQVR0dDJQSWR6T1Qw?=
 =?utf-8?B?RjNZbEdHMWorYlpVZ2VZSkNFL09ER3dCT1dDSVd5WnZoR2kreXVVMy93UjNF?=
 =?utf-8?B?Wm94NGNPR1dFZGdpUkpRWDJEOHl0VnJhUzZ2bXBvNGR0Q0tVNGowS29BQm0r?=
 =?utf-8?B?cDJuNTRXOTh4aEhDSlBENDdLYzZ2QVVTVkNxb2xLN1Jqb2x3V1RRWXpKNEsy?=
 =?utf-8?B?TWt1TFI1clhUMVZtajk3NmpBTjhsR1ZMODZ5eE9nOTJmSVh0N3ZUbWpxeHgr?=
 =?utf-8?B?MTNRVEZDZmpaQmVxYzVpemhvTC9TVktLR2hpSXV2d1c5dEVCbWJRbGlyWlRU?=
 =?utf-8?B?VytCcjh0NWZxQ2ZlWVBnZm4rR2RQaHBpSnBrNWErVXVVQ2tFYk8vdXJlMGgr?=
 =?utf-8?B?WE1ZaGNlYmhIVE50TzN2eHlWREV0Ky9xYUtEb3RRalEyZmkzQURJMExUNjdP?=
 =?utf-8?B?a0RRSXhQaXNDc0pCNkZTUFJPMHQraGxUZGErUTZGZDAvOWpISXdRa3Qxc25y?=
 =?utf-8?B?ZWU3QUJ6SFN1Z3AyRjRnSXpHa1BOMDNyMnNrNWJ2MVByRkFteGdyLzJhMXJJ?=
 =?utf-8?B?Mm5tb2lRMlBYSHROWkJ3Q3VGVEpVcGgvVGxyYmtEcnVaSWVwVzNQZnZGbWlK?=
 =?utf-8?B?NlJPSDMwak1PSHVVNGxVR1dtemVQK1kwNFUzS1ZvMnNDVmd1VE9GM2JVazhx?=
 =?utf-8?B?bmdKcUViM0wvZnhUcnRmYm4xR0c1bjVIcVFud1A4aWcyTXNMVndGOFdpaGhh?=
 =?utf-8?B?c3RXYUVpTkNVZjJ3UGIyZnZGWjBTTm9ZTWpadHBHbzUvNHNwVjU4NXFLYjNI?=
 =?utf-8?B?Z0JjNnBXQnNFSTV1czRpaVI1aTQrNFllM3FoTVc2RThUcXpSODJ4V2gyZ2dz?=
 =?utf-8?B?VTZPWmg3aFovNGpTVDZvUDhUT0ZDRDlwajIveFZNRThjVUQ5bGw5dyt0SGsx?=
 =?utf-8?B?Z0xiZEVnMFAwQmVSNm43dnEwSVB5WngzUFVTeGdQZjhCbmYvcnJHdENJRmtD?=
 =?utf-8?B?aWNpd0NwZ0FkVHRQMkZIN21jUllmNjBLcVlDMlJHQnVHd3NuSi85TTM3ZG8w?=
 =?utf-8?B?UXQyVkJLZEsxZG5PUndGWEx6N21QTDd3WVExWng4Mi9uYWE1VUoxM04xZHNh?=
 =?utf-8?B?SEZweWVqVFlubVZYT2o2Z3ZVOUE0ZmVUUy9rd3daMGJxQW9KVndCYUxNMU9S?=
 =?utf-8?B?bVBSR2VQd3RjVDFTdW14NlVqRzZEVmhiUnc2bjNRSjNoTVhEUGFJalhaS1dr?=
 =?utf-8?B?c0RrQjY0UzdSUUc4dk1VcFA5bCtBKzN1MUh4czN5b005TzhoODdLN3FKbHZS?=
 =?utf-8?B?WVloNzFvT0tELzBGZnloTGNKSGZUYTc3aVdjbU5HTEJqOUdlWXZhRVF3d3NV?=
 =?utf-8?B?dXBOMHErWlVxc2JhbVZ1WEZZdGNkME5meTloTmUxbEZHSC9vKzRQVFNVMStI?=
 =?utf-8?B?UVFYQmg5RWNxME5xb0dqcGF5UUxuZTdhN3FRZ2J6SGVJd3lncTZZRGt0Ny9U?=
 =?utf-8?Q?1E2YcbDP6DyR8PJNPQoa7MyHZ?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a8f33058-72ff-4ff6-11d3-08dc3c7f30a8
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Mar 2024 19:13:35.5314
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: sje5akqMisoBwwKoPM08vYiwpyD4H/SCLooyQeITtSgAEkvDF5tM3RZh9otT4e25RBNhyYqwXct5pz9lkMrcPw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1PR04MB9357

On Mon, Mar 04, 2024 at 11:40:05PM +0530, Manivannan Sadhasivam wrote:
> On Mon, Mar 04, 2024 at 11:47:36AM -0500, Frank Li wrote:
> > On Mon, Mar 04, 2024 at 02:18:41PM +0530, Manivannan Sadhasivam wrote:
> > > On Tue, Dec 19, 2023 at 02:38:34PM +0000, Niklas Cassel wrote:
> > > > On Tue, Dec 19, 2023 at 09:20:21AM -0500, Frank Li wrote:
> > > > > On Tue, Dec 19, 2023 at 10:07:14AM +0000, Niklas Cassel wrote:
> > > > > > On Mon, Dec 18, 2023 at 11:48:43PM -0500, Frank Li wrote:
> > > > > > > dw_pcie_ep_inbound_atu()
> > > > > > > {
> > > > > > > 	...
> > > > > > > 	if (!ep->bar_to_atu[bar])
> > > > > > > 		free_win = find_first_zero_bit(ep->ib_window_map, pci->num_ib_windows);
> > > > > > > 	else
> > > > > > > 		free_win = ep->bar_to_atu[bar];
> > > > > > > 	...
> > > > > > > }
> > > > > > > 
> > > > > > > The atu index 0 is valid case for atu number. The find_first_zero_bit()
> > > > > > > will return 6 when second time call into this function if atu is 0. Suppose
> > > > > > > it should use branch 'free_win = ep->bar_to_atu[bar]'.
> > > > > > > 
> > > > > > > Change 'bar_to_atu' to s8. Initialize bar_to_atu as -1 to indicate it have
> > > > > > > not allocate atu to the bar.
> > > > > > > 
> > > > > > > Reported-by: Niklas Cassel <Niklas.Cassel@wdc.com>
> > > > > > > Close: https://lore.kernel.org/linux-pci/ZXt2A+Fusfz3luQV@x1-carbon/T/#u
> > > > > > > Fixes: 4284c88fff0e ("PCI: designware-ep: Allow pci_epc_set_bar() update inbound map address")
> > > > > > > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > > > > > > ---
> > > > > > > 
> > > > > > > Notes:
> > > > > > >     @Niklas:
> > > > > > >     	I have not test your case. I should be equal to previous's fix in
> > > > > > >     mail list.
> > > > > > 
> > > > > > Hello Frank,
> > > > > > 
> > > > > > Thank you for sending a proper fix for this!
> > > > > > 
> > > > > > Personally, I slightly prefer your fix that saves the iatu index + 1, and
> > > > > > keeps 0 to mean unused. That way, you don't need the memset, and you don't
> > > > > > need to change the type to signed, but either way is fine by me, so:
> > > > > 
> > > > > index + 1 don't match hardware iATU index. It will be confused because
> > > > > other parts is 0 based.
> > > > > 
> > > > > So I choose "-1" as free iATU.
> > > > 
> > > > A s8 can hold a max value of 127.
> > > > CX_ATU_NUM_OUTBOUND_REGIONS seems to be 0-255.
> > > > 
> > > > Since the DWC code can be synthesized with 256 iATUs,
> > > > your code will not work on systems with 128 or more iATUs.
> > > > 
> > > > If we continue to use a u8, and offset the saved value by one,
> > > > we will at least be able to support 255-1 == 254 iATUs.
> > > > 
> > > 
> > > Agree. I cannot suggest a better alternative. So let's go with this. But please
> > > add a comment before bar_to_atu assignment to make it clear. Like,
> > > 
> > > 	/*
> > > 	 * Always increment free_win before assignment, since value 0 is used to
> > > 	 * identify unallocated mapping.
> > > 	 */
> > > 	ep->bar_to_atu[bar] = free_win + 1;
> > 
> > This patch already change to use "-1" as free. Only issue for this patch is
> > that use 's16' instead of 's8' becasue max ATU number is 255.
> > 
> 
> Niklas's initial suggestion of keeping u8 for the array and 0 as the unallocated
> placeholder sounds good to me. Please use that instead.
> 

It is impossible to keep u8, because 255 + 1 will 0 for u8. Previously
Niklas's initial suggestion have not consider this condition. If u8 have to
change to u16 or s16 anyways, I prefer use -1 as free.

Frank

> Even though iATU window index starts from 0, the comment I suggested will
> clarify what this bar_to_atu[] does.
> 
> - Mani
> 
> -- 
> மணிவண்ணன் சதாசிவம்