Received-SPF: pass (google.com: domain of linux-kernel+bounces-91170-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Mon, 4 Mar 2024 19:21:51 +0000
From: Conor Dooley <conor@kernel.org>
To: Dawei Li <dawei.li@shingroup.cn>
Cc: conor.dooley@microchip.com, daire.mcnamara@microchip.com,
	linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
	kernel test robot <lkp@intel.com>
Subject: Re: [PATCH v2] firmware: microchip: Fix over-requested allocation
 size
Message-ID: <20240304-rifling-nemeses-c830702266bc@spud>
References: <20240304101653.126570-1-dawei.li@shingroup.cn>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="wMKfExtoszAhgpYP"
Content-Disposition: inline
In-Reply-To: <20240304101653.126570-1-dawei.li@shingroup.cn>


--wMKfExtoszAhgpYP
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Mar 04, 2024 at 06:16:53PM +0800, Dawei Li wrote:
> cocci warnings: (new ones prefixed by >>)
> >> drivers/firmware/microchip/mpfs-auto-update.c:387:72-78:
>    ERROR: application of sizeof to pointer
>    drivers/firmware/microchip/mpfs-auto-update.c:170:72-78:
>    ERROR: application of sizeof to pointer
>=20
> response_msg is a pointer to u32, so the size of element it points to is
> supposed to be a multiple of sizeof(u32), rather than sizeof(u32 *).
>=20
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202403040516.CYxoWTXw-lkp@i=
ntel.com/
> Signed-off-by: Dawei Li <dawei.li@shingroup.cn>
> ---
>=20
> V1 -> V2:
> sizeof(u32)->sizeof(*response_msg)=20

Thanks for the quick respin. I'll send this as 6.9 material cos of the
proximity to the merge window and the fact that we just over-allocate
here. Thanks!

I added a Fixes: tag when I applied this, you should add those in the
future. I should've mentioned this earlier but forgot.

Thanks,
Conor.

https://git.kernel.org/conor/c/af1e0a7d39f98c0dea1b186a76fcee7da6a5f7bc


--wMKfExtoszAhgpYP
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZeYfTwAKCRB4tDGHoIJi
0rFuAQDxFJ5GT1qa5JLgA1JNpEJBkbxmIEMWJCYFlKSD4MOPwgD+PDtW+d26QimF
duEOvvqr8nkcTZl57I1xXjODkejCoAs=
=gP+N
-----END PGP SIGNATURE-----

--wMKfExtoszAhgpYP--