Received-SPF: pass (google.com: domain of linux-kernel+bounces-91178-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240304192244.2924407-1-robimarko@gmail.com> <ZeYglnW6/k0nvmiL@shell.armlinux.org.uk>
In-Reply-To: <ZeYglnW6/k0nvmiL@shell.armlinux.org.uk>
From: Robert Marko <robimarko@gmail.com>
Date: Mon, 4 Mar 2024 20:29:21 +0100
Message-ID: <CAOX2RU77sBWD=N7hQ+7BKQ1DOh8d=JHJBLeN6NEp-4Jv_3M7zw@mail.gmail.com>
Subject: Re: [PATCH net] net: phy: qca807x: fix compilation when
 CONFIG_GPIOLIB is not set
To: "Russell King (Oracle)" <linux@armlinux.org.uk>
Cc: andersson@kernel.org, konrad.dybcio@linaro.org, andrew@lunn.ch, 
	hkallweit1@gmail.com, davem@davemloft.net, edumazet@google.com, 
	kuba@kernel.org, pabeni@redhat.com, ansuelsmth@gmail.com, 
	linux-arm-msm@vger.kernel.org, netdev@vger.kernel.org, 
	linux-kernel@vger.kernel.org, kernel test robot <lkp@intel.com>
Content-Type: text/plain; charset="UTF-8"

On Mon, 4 Mar 2024 at 20:27, Russell King (Oracle)
<linux@armlinux.org.uk> wrote:
>
> On Mon, Mar 04, 2024 at 08:21:36PM +0100, Robert Marko wrote:
> > -     if (IS_ENABLED(CONFIG_GPIOLIB)) {
> > +#if IS_ENABLED(CONFIG_GPIOLIB)
> >               /* Make sure we don't have mixed leds node and gpio-controller
> >                * to prevent registering leds and having gpio-controller usage
> >                * conflicting with them.
> > @@ -749,7 +749,7 @@ static int qca807x_probe(struct phy_device *phydev)
> >                       if (ret)
> >                               return ret;
> >               }
> > -     }
> > +#endif
>
> I know it makes for a bigger patch, but #if is not equivalent to if()
> in terms of indentation, so the indentation also needs to be changed.

Oh, sorry for that, it completely slipped my mind.
I will fix it in v2, and will send it tomorrow afternoon to give
others time to comment.

Regards,
Robert
>
> --
> RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
> FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!