Received-SPF: pass (google.com: domain of linux-kernel+bounces-91255-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
From: Armin Wolf <W_Armin@gmx.de>
To: Shyam-sundar.S-k@amd.com
Cc: hdegoede@redhat.com,
	ilpo.jarvinen@linux.intel.com,
	platform-driver-x86@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH v3 1/4] platform/x86/amd/pmf: Fix return value of amd_pmf_start_policy_engine()
Date: Mon,  4 Mar 2024 21:50:02 +0100
Message-Id: <20240304205005.10078-2-W_Armin@gmx.de>
In-Reply-To: <20240304205005.10078-1-W_Armin@gmx.de>
References: <20240304205005.10078-1-W_Armin@gmx.de>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:U5VYaQ7x7FU=;wYUHjOSSNN8XnWDFnkZLgYocNOw
 WrzTKLqtU4LOCimTxe+Xe1jPOYob3wTUM/KfPdBVdVbyChPjbwBohFOWJf6zHpMAnogsU8abA
 8GUrTalxHX/RNHxhHU9OVrGtpzmcVhgmlH3Egfgebw7w+N8kwyRIbdMxd4PVToBH0vhHBKXP4
 uw9z/XGx1B9UR39aPUkIGLC/4Ulw7GF1Oj+IwaZnwJbpahVHUgeK7+IdmJvXKsT/OCNEYxtAO
 gEMN1ah6rziogBQ4a/u/jMXdBeTW7cXIpqZ7zH0gbLDZVYr5ZuMtSwIF1MOovfdjJBiJq8fix
 PBKSUKF11AkMEVe81K+ju5a1sXArRjSCo2b8obCdYLvGdV9ADgPrRms++0H+AO/Rh8gmMLvvC
 CqQerq2uWNLRpUAhjvjz1oZnMKLLq7yHroTFa2ozPq05O5o32dlAZsV+erZ2uE48EzVTp3aXI
 8RImwlaSx+LgY3iQLY8idOqSjdENGFggSWtttUPxhO3yel2heXcqyQVFtcvoSQm/JVuz3Xg6v
 woAskANoOqggQITOVaYTRtj9wYm8HWR7hXC7XCZ6ysWfwbUs2CCYDNwTtqjBHmOTv5qqD/79W
 ZHz+5tQa73wkzm1EntQI8oMCNeEDTl47r+Ep5rdZGCDgxep6bXySaxhUMs7tANgdq1fuuAQoX
 s/VzihG3mFOwWlSc7NEiF1MMpBQU+9CO1C7T2sZ3G+xjM2AVIEQJEvLrtBiRDxA9CaH5aAA72
 WAJaHoWWeJYxyZOV0VEkncxIug0XJC/JecYNSYfa81ny8dzWNZOY+NrNf+QgfenEDuyDnjuQS
 kwkeQQvQb3pQMz7brX33XPb6HaiQOMUavXTRWDgHOiXBg=

amd_pmf_start_policy_engine() returns an negative error code upon
failure, so the TA_PMF_* error codes cannot be used here.

Return -EIO instead. Also stop shadowing the return code in
amd_pmf_get_pb_data().

Compile-tested only.

Suggested-by: Ilpo J=C3=A4rvinen <ilpo.jarvinen@linux.intel.com>
Fixes: 7c45534afa44 ("platform/x86/amd/pmf: Add support for PMF Policy Bin=
ary")
Signed-off-by: Armin Wolf <W_Armin@gmx.de>
=2D--
 drivers/platform/x86/amd/pmf/tee-if.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/platform/x86/amd/pmf/tee-if.c b/drivers/platform/x86/=
amd/pmf/tee-if.c
index 16973bebf55f..13dd4462e1e3 100644
=2D-- a/drivers/platform/x86/amd/pmf/tee-if.c
+++ b/drivers/platform/x86/amd/pmf/tee-if.c
@@ -269,7 +269,7 @@ static int amd_pmf_start_policy_engine(struct amd_pmf_=
dev *dev)
 	} else {
 		dev_err(dev->dev, "ta invoke cmd init failed err: %x\n", res);
 		dev->smart_pc_enabled =3D PMF_SMART_PC_DISABLED;
-		return res;
+		return -EIO;
 	}

 	return 0;
@@ -309,8 +309,8 @@ static ssize_t amd_pmf_get_pb_data(struct file *filp, =
const char __user *buf,

 	amd_pmf_hex_dump_pb(dev);
 	ret =3D amd_pmf_start_policy_engine(dev);
-	if (ret)
-		return -EINVAL;
+	if (ret < 0)
+		return ret;

 	return length;
 }
=2D-
2.39.2