Received-SPF: pass (google.com: domain of linux-kernel+bounces-91257-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
From: Armin Wolf <W_Armin@gmx.de>
To: Shyam-sundar.S-k@amd.com
Cc: hdegoede@redhat.com,
	ilpo.jarvinen@linux.intel.com,
	platform-driver-x86@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH v3 2/4] platform/x86/amd/pmf: Do not use readl() for policy buffer access
Date: Mon,  4 Mar 2024 21:50:03 +0100
Message-Id: <20240304205005.10078-3-W_Armin@gmx.de>
In-Reply-To: <20240304205005.10078-1-W_Armin@gmx.de>
References: <20240304205005.10078-1-W_Armin@gmx.de>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:pEZeRv1Hvlg=;sLZliRcOysRVcz3Z6ioV6gdLwn1
 R6SQr/rVYPqlRjppHHhsXuPS3k3Evq40qI8pcqDRPrQBovIVu+j+6x134v4m5iQmZ4JEy2bm2
 cdSXuyoAyvQCvr+87Um7XO/8lfPcNJEkEjOAO0dpVpbsAK5XHk3JTuN5HOo+9+4tEm6/TBc30
 eEtTsmQh8cGWQaR2S/9GQm+3+neh4DDsWo5WtuLyOy8WPKtHt1WiXOU4EDwmHIrZi53RsZpUX
 PMadGfDsrXakY/eshIMHuxz9veYXu1YuaBse+1MQCtcJznoBNaMI25dzKrwadwwV4gUDwGmJT
 TfzLs9Hp2I9EbVq7zQ1oi6Kxbv9bJpJ5SdSJ6xyIi0MeqzOWwtTm5G8BHZPtRwPGL/j4EZDDR
 xqD2SNk2O0PDcymDa1NqqKt3opF/n4kLxE7srHgvTD0/cma8Ik3iEPzi2o+5kDZf1IriadPP6
 5bLuXTcOIhIzjAfG3C1uf+Do87lm7atIhIzLWcT+gvi63PM3IGyfWVOhPav1PHu0ZL+i15Ihz
 efx5QCD5mrIL+a2Ot91ej4TgKT9qmpnXznASngfiT6bFAWqyrDUif+dcZS6tg3u1ypZh9Grwx
 i2NzfmIzheouhdA+HflkGA7M6Eh9760KFngbwUElR8wPQ83Kewxepm5TTHBp+uLpDo6zJSAl1
 vuxchguwgh5S4NLRAyQX1ipwCIvbGE13L2h72AvJYVvK0MDQneRk7fobepeD6OM6fio39sLlK
 1DZ5yFvWC4sEx2zR0qno4QHE9/Vsi3yBMmYXNZ5kOYeQrPDgyegis2urRi4CnitQfZwfYy+yT
 Q7KPjHqSyrXAbXFT76Szqm5QwrOFu4u3qtvwsF/bwbnWs=

The policy buffer is allocated using normal memory allocation
functions, so readl() should not be used on it.

Compile-tested only.

Fixes: 7c45534afa44 ("platform/x86/amd/pmf: Add support for PMF Policy Bin=
ary")
Signed-off-by: Armin Wolf <W_Armin@gmx.de>
=2D--
 drivers/platform/x86/amd/pmf/tee-if.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/platform/x86/amd/pmf/tee-if.c b/drivers/platform/x86/=
amd/pmf/tee-if.c
index 13dd4462e1e3..58ec2c9606e1 100644
=2D-- a/drivers/platform/x86/amd/pmf/tee-if.c
+++ b/drivers/platform/x86/amd/pmf/tee-if.c
@@ -249,8 +249,8 @@ static int amd_pmf_start_policy_engine(struct amd_pmf_=
dev *dev)
 	u32 cookie, length;
 	int res;

-	cookie =3D readl(dev->policy_buf + POLICY_COOKIE_OFFSET);
-	length =3D readl(dev->policy_buf + POLICY_COOKIE_LEN);
+	cookie =3D *(u32 *)(dev->policy_buf + POLICY_COOKIE_OFFSET);
+	length =3D *(u32 *)(dev->policy_buf + POLICY_COOKIE_LEN);

 	if (cookie !=3D POLICY_SIGN_COOKIE || !length)
 		return -EINVAL;
=2D-
2.39.2