DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
  s=s1024; d=pacbell.net;
  h=Received:X-YMail-OSG:Received:Date:From:To:Subject:Cc:References:In-Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id;
  b=xqe9nezDNVtP6Ij3bmI/Sw9SsjwFovYEjcQAgLUvUJNi0RTOMDxT1sADe9l/qK6ky/c2rDikRqDjdHTnZeHanloHiw2e9Lh1g9P5cxFm6wfRw8upDEfCS6tozWx28G9k/O73MyZGyiy2+glmwpjuv4Q8a3gK2cGXGgCQOlKBKig=  ;
Date: Fri, 04 Jan 2008 08:09:33 -0800
From: David Brownell <david-b@pacbell.net>
To: yi.y.yang@intel.com, pavel@ucw.cz
Subject: Re: [linux-pm][PATCH] base: Change power/wakeup output from "" to 
 "unsupported" if wakeup feature isn't supported by a device
Cc: linux-pm@lists.linux-foundation.org, linux-kernel@vger.kernel.org
References: <1199441414.19185.9.camel@yangyi-dev.bj.intel.com>
 <20080104114832.GA4114@elf.ucw.cz>
In-Reply-To: <20080104114832.GA4114@elf.ucw.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-Id: <20080104160933.B01D81FBAB5@adsl-69-226-248-13.dsl.pltn13.pacbell.net>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 947
Lines: 23

> > This patch changes empty output to "unsupported" in order that a user knows
> > wakeup feature isn't supported by this device when he/she
> > 'cat /sys/devices/.../power/wakeup', please consider to apply,
> > thanks.
>
> What about simply removing "wakuep" file if wakeup is not supported?

It may not *stay* unsupported, so I think changing it in either
of those permanent ways would be confusing/misleading.

For example, USB devices have multiple states ... minimally, an
unconfigured state, and a configured state.  Some have multiple
configurations.  Only configured states can be wakeup-capable.
So a given device might have three states, but support wakeup
except in one of them...

- Dave

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/