Received: by 2002:a89:2c3:0:b0:1ed:23cc:44d1 with SMTP id d3csp39570lqs; Mon, 4 Mar 2024 14:17:08 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCX4+R+ENn9H63ndLhXyYXAMiDWYznaGm0jKXru7FCIqbq+mTzQFno2M25+hQJsCBZOqCx+n0Jx14qKqSz6SFoh3QRbb+0emIvRJfwzmDg== X-Google-Smtp-Source: AGHT+IFk0GWVJZaaFG9njgzerusVqYotcxPp0SFZ2D8PbmD3vYGROKRsNAZ6t1io43dsuz8KA7co X-Received: by 2002:a05:6214:580f:b0:690:4764:eff6 with SMTP id mk15-20020a056214580f00b006904764eff6mr250848qvb.6.1709590627936; Mon, 04 Mar 2024 14:17:07 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709590627; cv=pass; d=google.com; s=arc-20160816; b=woc1UXq6uRYU319vtswAW3lsTXWk/BpXN/hrW55G1a0VqYSuZxykysovDOz+wviqZn HIBB+dFtpaVzoZ29VHewfaygcAgGEqgh3Pi9HdG7sTON4KBfFKEA4ufouchYfS0fzLjz cIyS29fv6ItHHGfRyXCqpELOvG4xQkRqLs42iseX5dX446M/o0Re5ry7zDCW8f9rtMYA B9Y2nXPHlT3E+w18e2xP4Eq+9J3SgbUCWTeWDbXa3bhGpKooN5CLOVr0/ZOuceazZqL9 SA9ZtE81mGbZ/1n5ROxMKZGGSE2FgFBNWWaZmbITcPIE4WsZ+nnn+Bw2gxc367gs/mdS AT3g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=JBtZ3OmHSgfPNwmgIx/oEH2RUzgwVFTaohfToZaumF8=; fh=p1cfdyD0BUpJ5KpvU5xyRZvBSox7PY9C5V9bVpLcPS0=; b=eudK9HTD6/4f5I7a4LyUiQH5xlb7VF7i3kaTuAQnv0Uc5OHwx0g3fIV3XcIozQDqIW DosqlOP6dThHwnAPbSZ+7XQ2LGvsFbpIy7GbluqLOiyncktqCKH1mvPCnwfTyfhead13 crBWdShjOTFggkJ4XAXsUh1IZBi6O4KQS7Sn4nACv5TEiUFxkEzIwaiD6+/uWVz54qbK Jh1k1IFF9yxTJU5AHi8h1GPR89zveju/0GNOddtZ6AMwRzZ61zQeqqKIiOyqoUc6rOx2 e0besm1kiDQQSNk+xx1P1C+BgMKrJv8u7kNIK/2ad+mTHvmaYtdpRtFzMbRqvCIwKD+C e9GQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="gO//cuMW"; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-91358-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-91358-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id fn2-20020ad45d62000000b0068cb7b24a38si10753571qvb.339.2024.03.04.14.17.07 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Mar 2024 14:17:07 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-91358-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="gO//cuMW"; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-91358-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-91358-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id D4CF91C236C0 for ; Mon, 4 Mar 2024 22:17:02 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id E02AF7BAF5; Mon, 4 Mar 2024 22:16:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="gO//cuMW" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0C73478B5E; Mon, 4 Mar 2024 22:16:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709590611; cv=none; b=BOgbWTpi923spSQku40Mkwlq0kLj84QC2unjIhw5coH0/RWTGXDw5IBoQlycxlLelQtZAYLtHk2lF/vUtzB2ppqfH8URqXn+6XOLdlTEIux2trpQxFWMDwLEjZYAc1vHZl16MiAn4HqdHF/osqRLztH2HadM+846cz6sB/FJ/1o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709590611; c=relaxed/simple; bh=oMSW/l9lKinrJpplamNpwDg1l6Mk3deCCLXQTPl4Ew8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Il0Pq+WPske0hP0MXnqWofhd7AFSgGtyxpL+D8ryzoohW8Abm8soLoN5zhP7DaXsT5+K7xm+EKicNZNodUP19Koag1nZJCn1ncO2Gb8e2aQzRV3qaHPsh1LozMdEW6j5IcxrMLIH5kxSPh8YAMb0vatlG5mvneSDe86sLe/Uk98= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=gO//cuMW; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1C956C433C7; Mon, 4 Mar 2024 22:16:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1709590610; bh=oMSW/l9lKinrJpplamNpwDg1l6Mk3deCCLXQTPl4Ew8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=gO//cuMWvYrQDHWFKIz6ScWuPTxyaJMFL/e9iiHrsWfSyTgfmlagTGS08AN/ddNgJ 0X5/udRKi0nY7KKQos4k4Udc4VJLeFNscvXTHkWZaCqCSWq1nbj4y63IPRmKDp5pq2 RumO4j13a3ItcPFEUNAcx7SggcO9xRNXE6jMoM8rSu6aDEUEUdpLY2LJzw74JteThe so0bK4avvz0DoVQQ4E8BbBECxh3ia2UTz1Z+Pnl78cQG8CKqwKutmzZtpQ7fOFf1ff oRoIXYFVan0Mt7HLYc7meTHjayf03NL9hBGQkA/Vq9l+IaljmkonxBHlusdY0sFvw7 0B7AWi1Bni51w== Date: Mon, 4 Mar 2024 14:16:48 -0800 From: Eric Biggers To: Kees Cook Cc: Vlastimil Babka , Christian Brauner , Alexander Viro , Jan Kara , linux-fsdevel@vger.kernel.org, "GONG, Ruiqi" , Xiu Jianfeng , Suren Baghdasaryan , Kent Overstreet , Andrew Morton , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH 3/4] xattr: Use dedicated slab buckets for setxattr() Message-ID: <20240304221648.GA17145@sol.localdomain> References: <20240304184252.work.496-kees@kernel.org> <20240304184933.3672759-3-keescook@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240304184933.3672759-3-keescook@chromium.org> On Mon, Mar 04, 2024 at 10:49:31AM -0800, Kees Cook wrote: > xattr: Use dedicated slab buckets for setxattr() This patch actually changes listxattr(), not setxattr(). getxattr(), setxattr(), and listxattr() all allocate a user controlled size. Perhaps you meant to change all three? What is special about listxattr() (or setxattr() if you actually meant to change that one)? - Eric