Received: by 2002:a89:2c3:0:b0:1ed:23cc:44d1 with SMTP id d3csp39973lqs; Mon, 4 Mar 2024 14:18:07 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCW2RwzEyoLORyLAsAPqoQTGuJEtCjKsu0tOBrsy6llEoU+Vj86r1O1drc3J/s7lj4fyRqp1n8y+JVv+TQ/mWZFQT8HXoawSCUdK2RLVwg== X-Google-Smtp-Source: AGHT+IGDqKTJbmiY/hlNy48vFRAwD1RIXtmQ2M6J0jYcB72J1Nr0qBM5SMC41DOoo/Gk7+yMRlvq X-Received: by 2002:a17:906:da06:b0:a44:4c7e:fc07 with SMTP id fi6-20020a170906da0600b00a444c7efc07mr7425837ejb.0.1709590687644; Mon, 04 Mar 2024 14:18:07 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709590687; cv=pass; d=google.com; s=arc-20160816; b=tL1JVXqbnmSmXndOR+L0cwoQb23iqGWbeKx/E3lBfwuu4/7tB9YUGT3UlT5lnNvUqJ tSPVWT2UKkF8bgpO2kfH/bAsdesSVjsD5rSrlB8BpyjfRbP7UXOtICA2XX934g9CgOTR 4QXFPKs1aXeeVc5tumdX0RMnJ/8bo+rpzyrBoCR297hFUCmRqPDA4DLH700mc1LA2CuY tfBv3iSpFN8CZrSCJIL8DEaB/dYtm1trm3SFdyY78MYHe0i3JDI0vPxYwfqsT5aqf2rB NUqtmfgwf0jHqsc0NAySsTqpf9ZsL+x4MMy5/tAqe/yo2p/LkknMO2H/nbmXj5t4Z01a zMXA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=ui-outboundreport:content-transfer-encoding:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:references :in-reply-to:message-id:date:subject:cc:to:from:dkim-signature; bh=9C7vqhVG1Ib+BaPOqHAEN16axSLJGjfO32R6zvCZXY4=; fh=VE5ZfoJWem8it6OrnlM5ov49ej/hHjarqyIgnpICDoo=; b=X1mF2Ap6t9MdYZMSDsdR7bkRtFylOPTtaYM5s/5Z3Cgucb0+oxAkTK6UggJb0fGoba R1iFAdp5PtaYYEUIeOfi6XPTkcTyeVlZw3QYWpnm70KtgLVcvFVx541SQflMQvbq1gIE MxJY53S8OXU2vJhfXGBQVFZObJArz7PjxckJpv9ektRnrAOhGYa1t6Ew/47rr1uCnvyo PsGkxUAKaSXZNork1HcqSPKpsQ6bwkdliRU0dNHe7+aCPapbDmd0bLLC+HCvOaMZP1lq icFGPGalOaRBMCoyKrfHM6lTsHPx3aVTVMmAKfwjLogkHvu9ZvPTXwDl1zvXBpZ7MCbF n4Fw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@gmx.de header.s=s31663417 header.b=kJFvnU9b; arc=pass (i=1 spf=pass spfdomain=gmx.de dkim=pass dkdomain=gmx.de dmarc=pass fromdomain=gmx.de); spf=pass (google.com: domain of linux-kernel+bounces-91360-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-91360-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=gmx.de Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id sa1-20020a1709076d0100b00a4573afbb18si816004ejc.255.2024.03.04.14.18.07 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Mar 2024 14:18:07 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-91360-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@gmx.de header.s=s31663417 header.b=kJFvnU9b; arc=pass (i=1 spf=pass spfdomain=gmx.de dkim=pass dkdomain=gmx.de dmarc=pass fromdomain=gmx.de); spf=pass (google.com: domain of linux-kernel+bounces-91360-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-91360-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=gmx.de Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 6358E1F207C4 for ; Mon, 4 Mar 2024 22:18:07 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 91B8E7BB17; Mon, 4 Mar 2024 22:17:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmx.de header.i=w_armin@gmx.de header.b="kJFvnU9b" Received: from mout.gmx.net (mout.gmx.net [212.227.15.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A10C47A70D; Mon, 4 Mar 2024 22:17:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=212.227.15.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709590666; cv=none; b=ddB2PHBIu5TgzXqCaH9xlE+JlE7ApTRC7KkRBfrgifRojVrBzOTam49XB1I7CNLe7AM+FNp1tM+GeKFSro16n8H1bA8ht7ejBa25Xtz7KBB0wkJh6LWmNFOdwBmchQHHKCNNZuLDTpCDSoP3wmVPbBTqaVTOxM6xwgYpb2738vo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709590666; c=relaxed/simple; bh=N69BwmLeOR2BwIa3WKb1T5Fo2cdv/XGckUP8Al75eig=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=CX6FE61ZU/JAodolqNTdlRWmGkMvms8exKhugM7xSmbyKSf8mt++QG4ZdOyY7rZdO4b+klR5zuLC5/EKz45o0jbHAlqLM/U3AzlTBv1OJXNebujBMcORODu86EVyayvJ+PtMFIMROcbL0h02/HJdxHVfDZJ/oequKu2EDbkeXWU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.de; spf=pass smtp.mailfrom=gmx.de; dkim=pass (2048-bit key) header.d=gmx.de header.i=w_armin@gmx.de header.b=kJFvnU9b; arc=none smtp.client-ip=212.227.15.18 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1709590657; x=1710195457; i=w_armin@gmx.de; bh=N69BwmLeOR2BwIa3WKb1T5Fo2cdv/XGckUP8Al75eig=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:In-Reply-To: References; b=kJFvnU9boms2Z7GpjBTRcbYllti7GVGLaK8ycED8g/k3JAXUrC8gNdKIhLGUt2Lp uqRiAULZHW08PxpQoEJGD4QEg3LL8CifY0HVSkNCtPmo26+BEFLaIPIx8lywoZaxV r6duU14XftSNKAuFOOMCWHj5uplZlB+A2MAIb5PMEskz1FeIehyZankYx0OOO6u+5 C77ATZGKtkFCeJBWwctbZORkY0UR5MGIl3IvfMii6OE1Bf/78nhkpZvpv6dXZzHfo fSxh1hQQtaR4aUkk1CN1GEKbTo5TABj6C1b7SNorcaY8ORX4Cvrro53XYOsfVDM+2 lhDKrfYC4ogn4NbDnQ== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from mx-amd-b650.users.agdsn.de ([141.30.226.129]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MBDjA-1rZ3AU47kE-00Clku; Mon, 04 Mar 2024 23:17:37 +0100 From: Armin Wolf To: hdegoede@redhat.com, ilpo.jarvinen@linux.intel.com Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/2] platform/x86: wmi: Avoid returning AE_OK upon unknown error Date: Mon, 4 Mar 2024 23:17:32 +0100 Message-Id: <20240304221732.39272-2-W_Armin@gmx.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240304221732.39272-1-W_Armin@gmx.de> References: <20240304221732.39272-1-W_Armin@gmx.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:IkVjgd3JgIQlLQO2ZiyszhLHhBFvXMgE/tjmIKdzZ5l5y71bKzc +99avk5zC8ZQpBFKQCg3qvTXUwWr/8HqdaNHj3w1DNvFFAGrGePHReHT3x/sYIfTp0kLKtp og9bp5QwPXHrTz7h0SBi7vNopy0Wkvsc9ETaFwhEmif+Rlyyr4oVxQxcGaEIANm9lM+AXy9 l9b+JCbQBA2VvP/VbvT/Q== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:D9sspd2i+2k=;O2NRNAjApf6ySKwwK8zws3+M9K5 fSmi0jxQQvaveX/VGYWm8/Ce20SfpSwVi+3SjzZYhtyagsdNwFLnUg3kPbgwhdMsk0E5LEyjH Nay2xwdKWQfykbzlX6YZIEvHHfjWLDz6S9oMERL2eSPLWG/ROCOApjrpEMEcS7x5xqFGK/mri 7Q2g/aCzvrLKvVrVgSufVUTnukWZ2VKKOi1hpWorT4HxgAdEYnWpwV9NW0Quo8qDBYTjxR7ba MZ5azfY59xYXNNlfhN+WoNZo8rddcf2i69ivr1kKG8CJWAF8MEsi0OKGSVYzfqkXhsIBZtkfO DevKTsm1Tp+XzJUoZTLlPYLgzHQIfP43ZFDzxX225z33NPn+kfEV4U+O9nmVtz4M7mmCTnH3E HrqQ1P2maawiyjftgeowjNgSjGYuDUjTRNphSXZj3EsTHNbCj6GJX9q0zI6Wojx8S9ZUts7fh 8qWXC5kNbhL2Mcbo/1H5tCt/gdA6PTTJpj76DaTzVxwS90d6+Iv4fbNA8XieNjJTSu5ot6yAx NeEzmlu+R1f4VDOjO0WIJev34Ov0bRx8WdmgIbOBDjZcfEY89J2F3i2tL779Y5QgjQKScEmgX 51FSE1XfDFiuq1LuCbNrx8g+b/mpcI+HTwJnH7ei5HiUJ9n+fKtSfwLgXwnujnpybbZySIcET k4PeAIkX4DS71En1dotMCNISb2SCERdVhQvOVlskclhH3fUealYqceTYbS2jBV8Txh9zCB4EL 2s2KA4djkG0aqvUFy9AWbUn6jOtiJ2O9VW9B3BST0QtBVYEvOdRNXI6D19p7Fm3HjfBdjC49l vSGGojH8QllsAvjvVGDrXQ9DZv62JD6b/OMqfRBd6ak4w= If an error code other than EINVAL, ENODEV or ETIME is returned by ec_read()/ec_write(), then AE_OK is wrongly returned. Fix this by only returning AE_OK if the return code is 0, and return AE_ERROR otherwise. Tested on a Dell Inspiron 3505 and a Asus Prime B650-Plus. Signed-off-by: Armin Wolf =2D-- drivers/platform/x86/wmi.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/platform/x86/wmi.c b/drivers/platform/x86/wmi.c index 900e0e52a5fa..be0e772a87c8 100644 =2D-- a/drivers/platform/x86/wmi.c +++ b/drivers/platform/x86/wmi.c @@ -1213,8 +1213,10 @@ acpi_wmi_ec_space_handler(u32 function, acpi_physic= al_address address, return AE_NOT_FOUND; case -ETIME: return AE_TIME; - default: + case 0: return AE_OK; + default: + return AE_ERROR; } } =2D- 2.39.2