Received-SPF: pass (google.com: domain of linux-kernel+bounces-91369-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <1e40efa3-3d16-4fc6-8686-2bcb254c7c5e@amd.com>
Date: Mon, 4 Mar 2024 16:41:24 -0600
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v7 0/9] x86: Confine early 1:1 mapped startup code
To: Ard Biesheuvel <ardb@kernel.org>
Cc: Ard Biesheuvel <ardb+git@google.com>, linux-kernel@vger.kernel.org,
 Kevin Loughlin <kevinloughlin@google.com>,
 Dionna Glaze <dionnaglaze@google.com>, Thomas Gleixner <tglx@linutronix.de>,
 Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
 Dave Hansen <dave.hansen@linux.intel.com>, Andy Lutomirski
 <luto@kernel.org>, Brian Gerst <brgerst@gmail.com>
References: <20240227151907.387873-11-ardb+git@google.com>
 <8b412f69-a08a-51cb-8223-ed1933031d5e@amd.com>
 <CAMj1kXFgUNDusUzVKh=2Mn802+x+0iop7O-aEZH0iuQtdOAFcw@mail.gmail.com>
Content-Language: en-US
From: Tom Lendacky <thomas.lendacky@amd.com>
Autocrypt: addr=thomas.lendacky@amd.com; keydata=
 xsFNBFaNZYkBEADxg5OW/ajpUG7zgnUQPsMqWPjeAxtu4YH3lCUjWWcbUgc2qDGAijsLTFv1
 kEbaJdblwYs28z3chM7QkfCGMSM29JWR1fSwPH18WyAA84YtxfPD8bfb1Exwo0CRw1RLRScn
 6aJhsZJFLKyVeaPO1eequEsFQurRhLyAfgaH9iazmOVZZmxsGiNRJkQv4YnM2rZYi+4vWnxN
 1ebHf4S1puN0xzQsULhG3rUyV2uIsqBFtlxZ8/r9MwOJ2mvyTXHzHdJBViOalZAUo7VFt3Fb
 aNkR5OR65eTL0ViQiRgFfPDBgkFCSlaxZvc7qSOcrhol160bK87qn0SbYLfplwiXZY/b/+ez
 0zBtIt+uhZJ38HnOLWdda/8kuLX3qhGL5aNz1AeqcE5TW4D8v9ndYeAXFhQI7kbOhr0ruUpA
 udREH98EmVJsADuq0RBcIEkojnme4wVDoFt1EG93YOnqMuif76YGEl3iv9tYcESEeLNruDN6
 LDbE8blkR3151tdg8IkgREJ+dK+q0p9UsGfdd+H7pni6Jjcxz8mjKCx6wAuzvArA0Ciq+Scg
 hfIgoiYQegZjh2vF2lCUzWWatXJoy7IzeAB5LDl/E9vz72cVD8CwQZoEx4PCsHslVpW6A/6U
 NRAz6ShU77jkoYoI4hoGC7qZcwy84mmJqRygFnb8dOjHI1KxqQARAQABzSZUb20gTGVuZGFj
 a3kgPHRob21hcy5sZW5kYWNreUBhbWQuY29tPsLBmQQTAQoAQwIbIwcLCQgHAwIBBhUIAgkK
 CwQWAgMBAh4BAheAAhkBFiEE3Vil58OMFCw3iBv13v+a5E8wTVMFAmWDAegFCRKq1F8ACgkQ
 3v+a5E8wTVOG3xAAlLuT7f6oj+Wud8dbYCeZhEX6OLfyXpZgvFoxDu62OLGxwVGX3j5SMk0w
 IXiJRjde3pW+Rf1QWi/rbHoaIjbjmSGXvwGw3Gikj/FWb02cqTIOxSdqf7fYJGVzl2dfsAuj
 aW1Aqt61VhuKEoHzIj8hAanlwg2PW+MpB2iQ9F8Z6UShjx1PZ1rVsDAZ6JdJiG1G/UBJGHmV
 kS1G70ZqrqhA/HZ+nHgDoUXNqtZEBc9cZA9OGNWGuP9ao9b+bkyBqnn5Nj+n4jizT0gNMwVQ
 h5ZYwW/T6MjA9cchOEWXxYlcsaBstW7H7RZCjz4vlH4HgGRRIpmgz29Ezg78ffBj2q+eBe01
 7AuNwla7igb0mk2GdwbygunAH1lGA6CTPBlvt4JMBrtretK1a4guruUL9EiFV2xt6ls7/YXP
 3/LJl9iPk8eP44RlNHudPS9sp7BiqdrzkrG1CCMBE67mf1QWaRFTUDPiIIhrazpmEtEjFLqP
 r0P7OC7mH/yWQHvBc1S8n+WoiPjM/HPKRQ4qGX1T2IKW6VJ/f+cccDTzjsrIXTUdW5OSKvCG
 6p1EFFxSHqxTuk3CQ8TSzs0ShaSZnqO1LBU7bMMB1blHy9msrzx7QCLTw6zBfP+TpPANmfVJ
 mHJcT3FRPk+9MrnvCMYmlJ95/5EIuA1nlqezimrwCdc5Y5qGBbbOwU0EVo1liQEQAL7ybY01
 hvEg6pOh2G1Q+/ZWmyii8xhQ0sPjvEXWb5MWvIh7RxD9V5Zv144EtbIABtR0Tws7xDObe7bb
 r9nlSxZPur+JDsFmtywgkd778G0nDt3i7szqzcQPOcR03U7XPDTBJXDpNwVV+L8xvx5gsr2I
 bhiBQd9iX8kap5k3I6wfBSZm1ZgWGQb2mbiuqODPzfzNdKr/MCtxWEsWOAf/ClFcyr+c/Eh2
 +gXgC5Keh2ZIb/xO+1CrTC3Sg9l9Hs5DG3CplCbVKWmaL1y7mdCiSt2b/dXE0K1nJR9ZyRGO
 lfwZw1aFPHT+Ay5p6rZGzadvu7ypBoTwp62R1o456js7CyIg81O61ojiDXLUGxZN/BEYNDC9
 n9q1PyfMrD42LtvOP6ZRtBeSPEH5G/5pIt4FVit0Y4wTrpG7mjBM06kHd6V+pflB8GRxTq5M
 7mzLFjILUl9/BJjzYBzesspbeoT/G7e5JqbiLWXFYOeg6XJ/iOCMLdd9RL46JXYJsBZnjZD8
 Rn6KVO7pqs5J9K/nJDVyCdf8JnYD5Rq6OOmgP/zDnbSUSOZWrHQWQ8v3Ef665jpoXNq+Zyob
 pfbeihuWfBhprWUk0P/m+cnR2qeE4yXYl4qCcWAkRyGRu2zgIwXAOXCHTqy9TW10LGq1+04+
 LmJHwpAABSLtr7Jgh4erWXi9mFoRABEBAAHCwXwEGAEKACYCGwwWIQTdWKXnw4wULDeIG/Xe
 /5rkTzBNUwUCZYMCBQUJEqrUfAAKCRDe/5rkTzBNU7pAD/9MUrEGaaiZkyPSs/5Ax6PNmolD
 h0+Q8Sl4Hwve42Kjky2GYXTjxW8vP9pxtk+OAN5wrbktZb3HE61TyyniPQ5V37jto8mgdslC
 zZsMMm2WIm9hvNEvTk/GW+hEvKmgUS5J6z+R5mXOeP/vX8IJNpiWsc7X1NlJghFq3A6Qas49
 CT81ua7/EujW17odx5XPXyTfpPs+/dq/3eR3tJ06DNxnQfh7FdyveWWpxb/S2IhWRTI+eGVD
 ah54YVJcD6lUdyYB/D4Byu4HVrDtvVGUS1diRUOtDP2dBJybc7sZWaIXotfkUkZDzIM2m95K
 oczeBoBdOQtoHTJsFRqOfC9x4S+zd0hXklViBNQb97ZXoHtOyrGSiUCNXTHmG+4Rs7Oo0Dh1
 UUlukWFxh5vFKSjr4uVuYk7mcx80rAheB9sz7zRWyBfTqCinTrgqG6HndNa0oTcqNI9mDjJr
 NdQdtvYxECabwtPaShqnRIE7HhQPu8Xr9adirnDw1Wruafmyxnn5W3rhJy06etmP0pzL6frN
 y46PmDPicLjX/srgemvLtHoeVRplL9ATAkmQ7yxXc6wBSwf1BYs9gAiwXbU1vMod0AXXRBym
 0qhojoaSdRP5XTShfvOYdDozraaKx5Wx8X+oZvvjbbHhHGPL2seq97fp3nZ9h8TIQXRhO+aY
 vFkWitqCJg==
In-Reply-To: <CAMj1kXFgUNDusUzVKh=2Mn802+x+0iop7O-aEZH0iuQtdOAFcw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?YWhqQVRJdDJBTnA1aEhUamNvUmFrOUxlemtXVitKUG92cnF4a04xWS94cTlp?=
 =?utf-8?B?QkEwR2JKR2FqMEtsN0s4YlAveWQxa0lsWTJkT1N3RHN2Y1dNYzJwbzRxbTdo?=
 =?utf-8?B?R25zSWhHbzExZmNKTlB6QTNPMTBiNTN4dDZJVkE4Vnh3RUNrUkZlc0lSbnlU?=
 =?utf-8?B?KzAvR01pWmJjS0dtNUhiZkdleVJQQjFVb2F3aGlTL3IzZUxXbjd3TFBSV0Q4?=
 =?utf-8?B?OG1vN2Y3L1ZBcjk5SGRzSVRaaUVDWEZxQjdLTFF4ZzF1UVBNakRPYkhRRXd3?=
 =?utf-8?B?VlNUQUQ5dS9sUTd5S3NId2ZwYW0xSm9LcDREWWJPR2RkVUMzMjNVV3d3MlZx?=
 =?utf-8?B?R1pmaThFNEt5UElaYmNRcUd3T1RQODdjeDZ6ZnBjN2k2eXpadzhKOFRRMVBy?=
 =?utf-8?B?NTA4UTNOSVBmQ2Y4VHRFMHlzYTdCMlFxeEJSVXRub3N3VG9wZEpHcVVmOXJv?=
 =?utf-8?B?aVZOcE9NK2NST0kvZSs3Q1o3Y055amFUSlJTekFLREhkRWJwWHN2NWR2VzRJ?=
 =?utf-8?B?Njd0VlQ0RkdzYU16YnZRVGtLa0xVSlJncm1BY0JtRHduWnR6QVplZHVkUDhR?=
 =?utf-8?B?b3V6RnZaOXhwQ1NKamsvbnNDOE51T3RQUFdDZDVRa05oY2V2bUsrS0lZdGwz?=
 =?utf-8?B?cktIcGZzUmFPcTNEQ2hXZlNwUFFISW0wczc1SXdxVGxGdWdUMytKK2VCQTND?=
 =?utf-8?B?aWdMMWlsaHBPSy9XeXk2cE5rU0l6SG1EV2Y1UVdzcTdLYXl6cDAyQWF4V0NU?=
 =?utf-8?B?Mk45eHBibit4bnNJNE5TQnBGMkFWZXhCR0JyTXNpcGFYTG9UY2IvRVdmZmpk?=
 =?utf-8?B?WDdHdFZnL0hpdisxdlVFUnFQVFYrazR0eFoxcG9XUlhYR3dHaVovK1lYTUd4?=
 =?utf-8?B?SS84KzRQZ1VEUnVndDdqaSt6TUc4MjdVd1RQYXFyc2J3YldpMzI3NzcrclA3?=
 =?utf-8?B?VjZEZ05tLy9iRUF2U09qUzRjU1pDK29XaGEvSTJvUGNyblhSQW82dGJ6b0J4?=
 =?utf-8?B?S28rL0ZoTEovb1ZHQXNvRkNoM3dKbm90ckZYMmF5NFlDVkQzMVI1eEdoT3o2?=
 =?utf-8?B?NENMaDhrclJXTkc0WVBHTjFpUG1wdEdxMEROck05bVRNQ1dzZFY0TklkSW5D?=
 =?utf-8?B?WmxwUkRkVmNEU1VJRXFVZkx1VHJlWUpEb3hhd2xIaHd5VVFncnZ2SmptcU1q?=
 =?utf-8?B?d0Q4Tkd5SkZ3NHF5dllxZ0RsL2M5WVJyNGs1OFJtY3ZGSDNIcDBFeTlQVnJH?=
 =?utf-8?B?NVBHazRJVmxhd2pwcjliV3RLdTczWkJuZ2JwMUprWlJ1YTR1Q3NsYzlhRFVK?=
 =?utf-8?B?ajA4Z2djRUJ4UWN2bkZqY2tEUml2Ylh0L3J5VktxdkZQRGpCRXJONTJFY1Zv?=
 =?utf-8?B?VWd5M1VPOEQzRkEveFhPWklPZjQxOElsSmJkUmdPUWh6c2FiR2JZaGh0RDdY?=
 =?utf-8?B?bHZZT29vWDRlcitKd0VkcytCSU9BMTlVNkh6M2plWEtKWW9TdWZkSDdsWmc5?=
 =?utf-8?B?N2IwTm1vdmVud2RkM3pKRk9xamV6VjZhUnhYQ252YXF3WTlCZ1p5eU0zZk1i?=
 =?utf-8?B?SU9rYkNtUnZqSU95bjlCbkNYNWRyYkxtSWkyS3VzVlozSWd6dHRvVzZVbDBL?=
 =?utf-8?B?V2N1czBUbG1wUnV4T2JrY0lRTWhLT1Buc2VOTGFyOUR2blhHYmlEQUs5T2s0?=
 =?utf-8?B?V3o3L3BuQzdKb1orK25XVitwZ2N4ZXJEN2JXKzRVUEFBUVc2K1R3d09rRGc1?=
 =?utf-8?B?eUEwVUFEY3pOaHQrNENnQ1F2ZVdZblRmcUJqazkzTDEycjVBVE0yM01oRGpL?=
 =?utf-8?B?V0h3OXFWejhoZmQ0aDlSelNEYUtUR0p5eVBiZ3l0OU95dy9PNHduWHpUem01?=
 =?utf-8?B?WWdhUkl3aVVqMm9WTGZOeGdrRW05TnFwVHZ1bXFnUTNaSW1rQUFMdk0wVnRy?=
 =?utf-8?B?c0o4MXVWcW51SDM1SWRqN24xaTVhdk5pQnVsY2Y3eE01S3ZlZUJ5WlpVcm9R?=
 =?utf-8?B?QngwenNYd3NiaGJXcWZYQTBZcExhbm5KUU03VWVRUE9EK096RUNXOHN1dkYr?=
 =?utf-8?B?b2h3cmtIcW1xYXVjcXJCRytJTTUrbUQzeEV2bjN5UUxka0xRbTFaUS9aaUNN?=
 =?utf-8?Q?6ofiI0EFo4vQ/FPP/RWwS0gt+?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1aa427e0-4079-47f4-1a5a-08dc3c9c39f0
X-MS-Exchange-CrossTenant-AuthSource: BL1PR12MB5732.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Mar 2024 22:41:26.5505
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: qBhlrfe0F6tJcynO/ca+9NAzkwvryZQUIIPuOht41A5auRYN22CQvtXGLfKl81oj+Zm2iexsN6U/VCzjwC5KDg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR12MB8050

On 3/4/24 13:13, Ard Biesheuvel wrote:
> On Mon, 4 Mar 2024 at 18:07, Tom Lendacky <thomas.lendacky@amd.com> wrote:
>>
>> On 2/27/24 09:19, Ard Biesheuvel wrote:
>>> From: Ard Biesheuvel <ardb@kernel.org>
>>>
>>> This is resend #2 of v5 [0] with some touchups applied.
>>>
>>> Changes since v6:
>>> - Drop flawed patch to move some SME/SEV related calls out of the early
>>>     boot path to avoid the potential need for backporting patches #6/#7
>>>     to kernels where SEV support may not be crucial. This problem will be
>>>     dealt with if/when it arises while doing those backports.
>>>
>>> Changes since v5:
>>> - drop patches that have been merged
>>> - rebase onto latest tip/x86/boot
>>> - fix comment regarding CR4.PGE wrt flushing of global TLB entries
>>> - avoid adding startup code to .noinstr.text as it triggers objtool
>>>     warnings
>>>
>>> [0] https://lore.kernel.org/all/20240221113506.2565718-18-ardb+git@google.com/
>>>
>>> Cc: Kevin Loughlin <kevinloughlin@google.com>
>>> Cc: Tom Lendacky <thomas.lendacky@amd.com>
>>> Cc: Dionna Glaze <dionnaglaze@google.com>
>>> Cc: Thomas Gleixner <tglx@linutronix.de>
>>> Cc: Ingo Molnar <mingo@redhat.com>
>>> Cc: Borislav Petkov <bp@alien8.de>
>>> Cc: Dave Hansen <dave.hansen@linux.intel.com>
>>> Cc: Andy Lutomirski <luto@kernel.org>
>>> Cc: Brian Gerst <brgerst@gmail.com>
>>
>> For the series, tested bare metal boots with mem_encrypt=on /
>> mem_encrypt=off and boots of SVM, SEV, SEV-ES and SEV-SNP guests.
>>
>> Tested-by: Tom Lendacky <thomas.lendacky@amd.com>
>>
> 
> Thanks a lot! I take it this was a kernel built with GCC?

Yes, it was a GCC build, so I went back and rebuilt with Clang-14 and 
everything was fine there, too.

Thanks,
Tom