Received-SPF: pass (google.com: domain of linux-kernel+bounces-91394-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <58c936af-b338-4951-97d4-4af9185babd4@intel.com>
Date: Mon, 4 Mar 2024 15:07:51 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v4 2/2] x86/resctrl: Simplify call convention for MSR
 update functions
Content-Language: en-US
To: Tony Luck <tony.luck@intel.com>, Fenghua Yu <fenghua.yu@intel.com>, "Peter
 Newman" <peternewman@google.com>, Jonathan Corbet <corbet@lwn.net>, Shuah
 Khan <skhan@linuxfoundation.org>, <x86@kernel.org>
CC: Shaopeng Tan <tan.shaopeng@fujitsu.com>, James Morse
	<james.morse@arm.com>, Jamie Iles <quic_jiles@quicinc.com>, Babu Moger
	<babu.moger@amd.com>, Randy Dunlap <rdunlap@infradead.org>, Drew Fustini
	<dfustini@baylibre.com>, <linux-kernel@vger.kernel.org>,
	<linux-doc@vger.kernel.org>, <patches@lists.linux.dev>
References: <20240228112215.8044-tony.luck@intel.com>
 <20240228193717.8170-2-tony.luck@intel.com>
From: Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20240228193717.8170-2-tony.luck@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UVY2MjFZY2lJd1JSVElzNHhrZm5weWZxcytNRWJ6Z29ieTR1ZUpEM0VJT0xE?=
 =?utf-8?B?TFlKd0FtaUFqTk9hUXVpcG84d2w5RmxKZU5HQ2c3V0lzZUNIUzdwMnNFejJU?=
 =?utf-8?B?eUlvZm9FRE5BcFA0WmJyeHlnekpSeXR1TlFrblRlSzVFcExEK2FDTitDYWRN?=
 =?utf-8?B?ZGl4bDhHMjdSdkJRekpBVDhNVG5FMSsxbkl2NW85Y2U2L0grVFdCbkdnT29P?=
 =?utf-8?B?UVdFWlhQWlc3RzhMMytnTXlheTNEaDFONzdzK2tYQkVNdkx2dHVuQXBmZmlJ?=
 =?utf-8?B?NHRXTnhGZkNkTWlFNGQ4V0xvcTFSY3lOUmlxQ2ZtV3NtaU1BNjFkSFVPTTJU?=
 =?utf-8?B?ME5iUDFHVVJCZjkvdVZHalNCUzdsNU51K1doUW5CazFZMTltTWRKd3FNV3Yz?=
 =?utf-8?B?NFBqM1FNb25sdE90d25yK2RRZXIyUk5aeTFGUm4zTkdxS1JlbHpXZzJJeksv?=
 =?utf-8?B?YUtRTnlHR2FMdTNIYzRzcXJhamtLdVFDSDJiWnB1NmNhM1R6SzFTL1YwQnhJ?=
 =?utf-8?B?UnErdkN5MkRNZm9NUXhxK3ZJMnNPRHNSMFYybTVzcm5JZFpUS3pKUjVaM2Zv?=
 =?utf-8?B?WVFuVzBndTBvTjZtS2pXSzhTaWJJNU9ZNC9FRFlWdkMxNE5sckpnV2VDb2hz?=
 =?utf-8?B?L2VxT2t3T2c0R29nV2p1czRLTjRRLzd0ajk2M3FtQnJkbE84VVQ2VHFzUWVm?=
 =?utf-8?B?bzZvdTJ0M2Q0TDJVUGp0VG5WSHorTDBJai9vRTJGUGN4NzB1RUhHejNJY1lo?=
 =?utf-8?B?ZG1ORkwyVldxdGtjeHI4RkNkd0ZNMUZONDM2NDZPbzFBZlVyMXhUUEYzb2k4?=
 =?utf-8?B?ckg5eU5aSG9VSWJiV21ncXlrUU43eEJEOHdYK0JpQ3JzVWt0Ym1lZjh3T0NM?=
 =?utf-8?B?NWtmT2VXWXhvMDdna3FoUVZ1azMrUWZoVXhIS0tIRm41V0hhSHdRVnZDYlNU?=
 =?utf-8?B?bitSSEt3UGNzNTNpbnM3U3oya0c3dzNKMXR6a3RmYUo3VUdqT0xYcGhWaXlS?=
 =?utf-8?B?Vk5ka1pIMGVIZENBakI2Y0J2c09kK3Zxa0RuSXJmdUV0VHlrZ05VUHlvNG1U?=
 =?utf-8?B?Wk9LWkk2R2E5d2VjQUJUejdRMkhOTEIrTFhSRjdXTEFhL0JvZTBpUkxUYXdZ?=
 =?utf-8?B?eldVWEZRempkRlExcmlsaDJSbStjRXBXL01HNGFrc3N1dXZDUUpvcG1kN2RJ?=
 =?utf-8?B?eHhPNmc1RzNwaDlZZkUwcjZJQlc1b0xnY0xEakJ1dHVoVnorY1IzMDh3QTNX?=
 =?utf-8?B?dWFoWXkrTldLRzBZeFUrdEIxMGQzVHB5UDNxR2crT1JWdHBJQkVLZzJyRWsv?=
 =?utf-8?B?bi9mN1kvcU9QNGk3c2ZvSFJBNDNYOHhOUjdmU0k0bm5IYklFUjY5SHptV2Qy?=
 =?utf-8?B?VmpId3FFcXArSHJtVE9aOTlHeUR3U0thTEpMb2FhWnNtb3Qrb0c2MktrZmp5?=
 =?utf-8?B?ZWtzQU5LaXRzTktuOGZhTWNVWVVUZkJ0cVo5OHBCYWc0MzZFRlVRcjNmWlA3?=
 =?utf-8?B?Nmc0NEZYL2FVUVFKN2dTRVRzdkR2TlVoVU5HTnNpYVRzZm5MR0VPazhQcUR2?=
 =?utf-8?B?MTRhK09HTGpJL0dEMElVTmJBV1Q2MUl6QUlHeVRsdEtHNUdwWHpKSElZTFFx?=
 =?utf-8?B?UUJoZW9nZ08vMDhyQ3ljLzR3akx1aU1LeW5KYW9leHN2b0p0Tm5uaFhlTExO?=
 =?utf-8?B?WGFSZmJ6SnNScVNoT2M1YktLbXNYM1k2ZFkvY0FnWXhlSUl3eHlwdTFKRWlk?=
 =?utf-8?B?QU1kejVieWdERkNoQU4yTHpGVDB4Zkx6ZDZDRWtuU2d5QUF4ZFh4eWp4QWJ2?=
 =?utf-8?B?Vk5odEVRS0hqYk4yQ1RJcFBjbHl2d1Q2Vk0wVHZYNkpINUxRMmw5d3E1WjRh?=
 =?utf-8?B?c0pYd043Z0orM3p1Yko4bENBeDc4NzkxemhyWlhYQlN4YmZuRm5xSG90VjFK?=
 =?utf-8?B?NVMrM1Brcll0bWlEYkFiQTJlTzFhV2twM1BhSDBPQlNtc0RNem5Vblg1blBZ?=
 =?utf-8?B?dXo3S0F0UzVqbnE4dGg0YVVNSzJxS2QwaFgyYXU4V0VqckdNZGI0Sis3ODFO?=
 =?utf-8?B?c2xtbCtQSkhlYXcvT3F3NkxJaS9VVTNrb1U3MVRQNVpKODdUT25PQTliemYv?=
 =?utf-8?B?UFZFQmtVRUdKOHNPT09JZm1kb21Cb0NtdGsyT2J0akZBNys3QUVrRUd4UWdq?=
 =?utf-8?B?MlE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 9f778cb7-f4e0-443a-9460-08dc3c9feb73
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Mar 2024 23:07:52.8585
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: owMEv+QLMwdZZSLNXx7XigTeeTXLi/Qsb7FPi2qn6mLM0NJMdffSERZfOpAQrGX3i/FyTnSWKd4nW4zUNasmcDNZtGeWHn6OFKxNroifyOQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB6074
X-OriginatorOrg: intel.com

Hi Tony,

On 2/28/2024 11:36 AM, Tony Luck wrote:
> The per-resource MSR update functions cat_wrmsr(), mba_wrmsr_intel(),
> and mba_wrmsr_amd() all take three arguments:
> 
>   (struct rdt_domain *d, struct msr_param *m, struct rdt_resource *r)
> 
> struct msr_param contains pointers to both struct rdt_resource and struct
> rdt_domain, thus only struct msr_param is necessary.
> 
> Pass struct msr_param as a single parameter. Clean up formatting and
> fix some fir tree declaration ordering.
> 
> No functional change.
> 
> Suggested-by: Reinette Chatre <reinette.chatre@intel.com>
> Signed-off-by: Tony Luck <tony.luck@intel.com>
> ---

Thank you.

Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>

Reinette