Received: by 2002:a89:2c3:0:b0:1ed:23cc:44d1 with SMTP id d3csp77687lqs; Mon, 4 Mar 2024 15:51:00 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCW0GLY0oF38Q2Nr4AhaPNfcYlnT7hLZHI2DVjZVw1V9gDrnlIdB9WgXiIAqfrpXnudSFOUu0M0VUtdRhUBcOfOlrW459OAkOpa1u6MGqQ== X-Google-Smtp-Source: AGHT+IGaLg7jAZH3F8wOr0t4YpjTjwhHl8caUK6qjiuKQjvjq1fApGvdviAc937XlAp6bMx8Oz6C X-Received: by 2002:a05:6000:382:b0:33e:4517:369e with SMTP id u2-20020a056000038200b0033e4517369emr1849564wrf.19.1709596260629; Mon, 04 Mar 2024 15:51:00 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709596260; cv=pass; d=google.com; s=arc-20160816; b=Dd7c5w1U3RSadnL5s+4wB1qwdGvgn3MQwxzYBFfEJHg7lmE5PeevaC8fOLVA2q0vbt GonF/mHh2OBZvlHsQ+wdS6BOuI84BEdUpoqnlAuhLsdEIa/8z8M4XoV9dYAvywOU/vAr 3fCgWJJ0FrmHJjFIlLnsX2Ww+jJlj0eOL5q+svS2ddMilgjkf+KNhOuQHm7RM+ZzPGoI J6FPaOmbUkVLd3gsUDIEytfWtJeo4gXPG1jG7WYQ/QsMh0xArOt74Qn5+kNI1tETwM1y tsYGqQmsp5zjdyZcRVs+jLMXRg5IuH9Zpy24vrGk/V9YwkCXIpDI/JwqxM/Tq/kkMpdw yAWQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date; bh=2Iyv7vCZXZDmYiIWZEyPF9Ht4oHgg59/NZd7EBwTIkA=; fh=Z4tsOB/IV38gOyR2qPehPYRd6/PjJOdZwylA30ksxfw=; b=hHRuQgNDHWWJIgn7xa3UmxVfVUQv+h8vhx8JBqU5qJcaoo1rMtuQTerlpSISkS8I1l IGF7tbvPPrBtZXoi1giRxbRnDJ31h5HChh1x7PrcjWw5eYlfUHfux4njOCkzh4pcaM1w VEjNO9m3kA5asPDW0WmDR4RRjwbm1QddvhR0evlhsk0DPrZMbcO/gXYikuR+Ne5iP8XD NZ0WJOtLWWyC5t8ry3oNBXdPDIAe1v8kyK23DmluEIOcvklxAg9vW0XbVoKWfGlxlvpZ +mxMoN4UwySLpAYW9SnzI2Rcpn2LyAR2mxfoWdqlhBWboGhOBc2tlwsXx4GjvDcpEBwD pAnQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1); spf=pass (google.com: domain of linux-kernel+bounces-91425-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-91425-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id w4-20020aa7d284000000b005675328a3basi1176702edq.300.2024.03.04.15.51.00 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Mar 2024 15:51:00 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-91425-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; arc=pass (i=1); spf=pass (google.com: domain of linux-kernel+bounces-91425-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-91425-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 5A9001F21060 for ; Mon, 4 Mar 2024 23:51:00 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 7D0517D3F1; Mon, 4 Mar 2024 23:50:54 +0000 (UTC) Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E65547D07C for ; Mon, 4 Mar 2024 23:50:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709596253; cv=none; b=U85th9VS1GYbg2rhfqSZIlzQ806izk8FC7RLrRa4k0SqUWd5/8ocz5D9Ta0Txtw9HnCwxL7F/7RRC5IZs4/G1hbfi7Rj4NVh94XHOP8IEJmq2OiIevEFHoyDresK9uhmp5SdY917Xn2CgqreScez1UO/VO7h48mQ7ab5rODMNM0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709596253; c=relaxed/simple; bh=2Iyv7vCZXZDmYiIWZEyPF9Ht4oHgg59/NZd7EBwTIkA=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=hlrGpL1MKHpgINrde7em5IlPVeYqez97U/ab3BWsSe87srtLzSZ25K31cXNl5HAbyWOYRlcr+CN87HP85YYuNTSK2BFacm0yZ+tDaqtzwvYhz8vpF6BDEPtSrzjL2mifJdfLOvL+2ibSnqAQLscmKLHg6xrrTkDMHOsrNhZnc00= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 297EAC433F1; Mon, 4 Mar 2024 23:50:53 +0000 (UTC) Date: Mon, 4 Mar 2024 18:52:41 -0500 From: Steven Rostedt To: Linus Torvalds Cc: LKML , Masami Hiramatsu , Mathieu Desnoyers , Sachin Sant Subject: Re: [GIT PULL] tracing: Prevent trace_marker being bigger than unsigned short Message-ID: <20240304185241.7ce42097@gandalf.local.home> In-Reply-To: <20240304184725.55449e70@gandalf.local.home> References: <20240302111244.3a1674be@gandalf.local.home> <20240302145958.05aabdd2@rorschach.local.home> <20240302154713.71e29402@rorschach.local.home> <20240303075937.36fc6043@rorschach.local.home> <20240303140705.0f655e36@rorschach.local.home> <20240303160024.458d4f91@rorschach.local.home> <20240304164205.3245608a@gandalf.local.home> <20240304171034.08d037aa@gandalf.local.home> <20240304184725.55449e70@gandalf.local.home> X-Mailer: Claws Mail 3.19.1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 4 Mar 2024 18:47:25 -0500 Steven Rostedt wrote: > If I remove the precision, as I did in this patch. Then adding a limit is > not fixing any bug. It's just adding a limit. Anyway, I can change the limit to 4K and also change the trace_seq size to just 8K to hold events, instead of using PAGE_SIZE. But this still isn't fixing anything. It's just adding a limit. I'll add that as a separate patch. -- Steve