Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754328AbYADQih (ORCPT ); Fri, 4 Jan 2008 11:38:37 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752677AbYADQia (ORCPT ); Fri, 4 Jan 2008 11:38:30 -0500 Received: from iolanthe.rowland.org ([192.131.102.54]:50975 "HELO iolanthe.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1752554AbYADQia (ORCPT ); Fri, 4 Jan 2008 11:38:30 -0500 Date: Fri, 4 Jan 2008 11:38:29 -0500 (EST) From: Alan Stern X-X-Sender: stern@iolanthe.rowland.org To: David Brownell cc: yi.y.yang@intel.com, , , Subject: Re: [linux-pm][PATCH] base: Change power/wakeup output from "" to "unsupported" if wakeup feature isn't supported by a device In-Reply-To: <20080104160933.B01D81FBAB5@adsl-69-226-248-13.dsl.pltn13.pacbell.net> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 811 Lines: 22 On Fri, 4 Jan 2008, David Brownell wrote: > > > This patch changes empty output to "unsupported" in order that a user knows > > > wakeup feature isn't supported by this device when he/she > > > 'cat /sys/devices/.../power/wakeup', please consider to apply, > > > thanks. > > > > What about simply removing "wakuep" file if wakeup is not supported? > > It may not *stay* unsupported, so I think changing it in either > of those permanent ways would be confusing/misleading. How about changing it to say "unavailable"? That doesn't imply permanence. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/