Received-SPF: pass (google.com: domain of linux-kernel+bounces-91452-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Tue, 5 Mar 2024 00:26:50 +0000
From: Wei Liu <wei.liu@kernel.org>
To: Saurabh Singh Sengar <ssengar@linux.microsoft.com>
Cc: Wei Liu <wei.liu@kernel.org>, kys@microsoft.com, haiyangz@microsoft.com,
	decui@microsoft.com, tglx@linutronix.de, mingo@redhat.com,
	bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org,
	hpa@zytor.com, dwmw@amazon.co.uk, peterz@infradead.org,
	linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org,
	ssengar@microsoft.com, mhklinux@outlook.com
Subject: Re: [PATCH v3] x86/hyperv: Use per cpu initial stack for vtl context
Message-ID: <ZeZmysa1x4dogjQs@liuwe-devbox-debian-v2>
References: <1709452896-13342-1-git-send-email-ssengar@linux.microsoft.com>
 <ZeVpG07p9ayjk7yb@liuwe-devbox-debian-v2>
 <20240304070817.GA501@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240304070817.GA501@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>

On Sun, Mar 03, 2024 at 11:08:17PM -0800, Saurabh Singh Sengar wrote:
> On Mon, Mar 04, 2024 at 06:24:27AM +0000, Wei Liu wrote:
> > On Sun, Mar 03, 2024 at 12:01:36AM -0800, Saurabh Sengar wrote:
> > > Currently, the secondary CPUs in Hyper-V VTL context lack support for
> > > parallel startup. Therefore, relying on the single initial_stack fetched
> > > from the current task structure suffices for all vCPUs.
> > > 
> > > However, common initial_stack risks stack corruption when parallel startup
> > > is enabled. In order to facilitate parallel startup, use the initial_stack
> > > from the per CPU idle thread instead of the current task.
> > > 
> > > Fixes: 18415f33e2ac ("cpu/hotplug: Allow "parallel" bringup up to CPUHP_BP_KICK_AP_STATE")
> > 
> > I don't think this patch is buggy. Instead, it exposes an assumption in
> > the VTL code. So this either should be dropped or point to the patch
> > which introduces the assumption.
> > 
> > Let me know what you would prefer.
> 
> The VTL code will crash if this fix is not present post above mentioned patch:
> 18415f33e2ac ("cpu/hotplug: Allow "parallel" bringup up to CPUHP_BP_KICK_AP_STATE").
> So I would prefer a fixes which added the assumption in VTL:
> 
> Fixes: 3be1bc2fe9d2 ("x86/hyperv: VTL support for Hyper-V")
> 
> Please let me know if you need V4 for it.

No need to repost. I can change the commit message.

Thanks,
Wei.