Received: by 2002:a89:2c3:0:b0:1ed:23cc:44d1 with SMTP id d3csp95922lqs; Mon, 4 Mar 2024 16:39:29 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCVFkAJQyNxfRqwCqG6JVA+wq38ORZt8VeCN/LRGfq4mFKAc8u8ctpgAb2GeXXMfnayhwIRVNdMjZXQ3xyXmnBZQQXBktGbZd6Pj8l2umw== X-Google-Smtp-Source: AGHT+IF4J9LsEp7eeYM060W0i8bBavbc9f2ndD2x75G0e9KemHXu4A49GI53aFzIAKl+Rl0o6W0y X-Received: by 2002:a05:6358:6590:b0:17b:f73c:9e0 with SMTP id x16-20020a056358659000b0017bf73c09e0mr384887rwh.12.1709599169383; Mon, 04 Mar 2024 16:39:29 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709599169; cv=pass; d=google.com; s=arc-20160816; b=nebKPLyJqNvuCDhGawY0h6XCUJjzz7pFTWG3NyLx+CTeGOj/+5e0892tVnSI76UVs0 6dcAqNRqfCQaxcWAppTYzMEzSFh6MeyBkZR/mQutBXRtfgt2INUdEqEDpqMhCheAyexL k1SQKHtEQXyEJfVYrnFy82JbMKJsi0hVSmEBuHGg2mbbR5Q0lPRQmFAxoe2gsTxkIhrx 6qG4t/gYYmlpL6hWbHcwXZ0jbY6cOCR/jquCGhBTBTbenfLuXRcEd4xvFuHy0/xav62M zBuMWgaBxxil8bD46aDejp0ODMUhjnZu5tENuE/7JuSLQlUAUJr1lO1V8aJFnhWNkjHk Meow== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:list-unsubscribe:list-subscribe:list-id:precedence :message-id:date:references:in-reply-to:subject:cc:to:from :dkim-signature; bh=O0yyXFEBHAkyNtI5CjiaTsfcPSXS8959gJlNgVluFYY=; fh=KEbARxRm9tKsYl3HByWcKPfQ4HQPGVEAd0UIvqCnAW0=; b=MuWSBfUTgqShxr9vd5GpA5deuaXQvrtjgENji5h7pg0WiG5Nrd7+P0Pn2p2guYn0Cz qCljfP5ZQGICk3p1TPzHj6Y6y5kS6GF184NfuDgY8aVLN3qGklByyrAYx5k8DOgn1Lxx yAXm1VcLbWXz99a3V7fqDP5ikw7wjF+B2v24Hxg9eKikLaQQkc2qN5pdglVpkUeY5Ms5 Ta/AIbFlXE7bxjat1zct4qHf3TQvOUA6hM1LqCj/R+nFv7XkkCjP/Jpoi+aZMNehWSx9 9Bx2McvO6/8AVX97++OMD6bczdgikvHnvI+yo6WoEYOyrKDM4hgtxLNlQgIvEx9h7ngM I8FQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@ellerman.id.au header.s=201909 header.b=L5LihVMM; arc=pass (i=1 spf=pass spfdomain=ellerman.id.au dkim=pass dkdomain=ellerman.id.au); spf=pass (google.com: domain of linux-kernel+bounces-91460-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-91460-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id r28-20020a63205c000000b005dcc036c679si8932643pgm.677.2024.03.04.16.39.29 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Mar 2024 16:39:29 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-91460-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@ellerman.id.au header.s=201909 header.b=L5LihVMM; arc=pass (i=1 spf=pass spfdomain=ellerman.id.au dkim=pass dkdomain=ellerman.id.au); spf=pass (google.com: domain of linux-kernel+bounces-91460-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-91460-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 0FB38283A9B for ; Tue, 5 Mar 2024 00:39:29 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 21659522E; Tue, 5 Mar 2024 00:39:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ellerman.id.au header.i=@ellerman.id.au header.b="L5LihVMM" Received: from gandalf.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 999747F; Tue, 5 Mar 2024 00:39:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=150.107.74.76 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709599163; cv=none; b=Tq5/774pxHqIHltsOFXrFNAuxZgWU0ipT++8TmWAJKk0ziFOHM0gpOMg28PixAqVfI9UksDm8GnOfgsaIM3cGJw31KnYSDsmFO+XRHeHd8p8KUh9TEL0nckhzRhzZehhffjwIQXodGx3xqIlknppn7IESlZ0se6V7iSABZb7ea4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709599163; c=relaxed/simple; bh=O0yyXFEBHAkyNtI5CjiaTsfcPSXS8959gJlNgVluFYY=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=kN9d/qnzuiWwOqUQuLNMHxuh8FcqkLnycCnPrMx14n2RqmYVhtuxucwFLbm0v340mbl17JVVAVew+5/wLKZlDLfuuMSxIU06JcAjrPUo2kgxp6nAhclRZ9ArbZyB1r0eQN+/3GNFvPv13bJCq+bmL/d8+LVZxwaEqKC0UWVYlYI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au; spf=pass smtp.mailfrom=ellerman.id.au; dkim=pass (2048-bit key) header.d=ellerman.id.au header.i=@ellerman.id.au header.b=L5LihVMM; arc=none smtp.client-ip=150.107.74.76 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ellerman.id.au DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ellerman.id.au; s=201909; t=1709599159; bh=O0yyXFEBHAkyNtI5CjiaTsfcPSXS8959gJlNgVluFYY=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=L5LihVMMitiNLxNXu2uwdvAv5G9pLC5oUdBu+pvYJDZ313YT8SyKPN20bPRxW4GVj /utTJNIIqFYG2T9xXeKGzbECdqAlQXpV2INu3W3M9K2sEDjHtJCC1xTQxcw4aDTaUn LeLem1wU+SnumutF4cSN6xEfhO8L2iISNF0BZGTmWmYublljLePl9zrN0qM0U1nZQY 3zjHR+/kCU+tdM61C06/119pJz9yBVmYSF9NBTYGjOuNdoKnV/LeRDgn1n1Zd5ym6S p4UmssY0/676QfbmJFkFp9KgmxO9w5mXW8AsUMO1oGPCthyKjrjzBikVQdMtXrFtK4 E/5H0SV/AJJQw== Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4TpcBt73J0z4wcv; Tue, 5 Mar 2024 11:39:18 +1100 (AEDT) From: Michael Ellerman To: Jani Nikula , linuxppc-dev@lists.ozlabs.org Cc: dri-devel@lists.freedesktop.org, lkft-triage@lists.linaro.org, linux-kernel@vger.kernel.org, Naresh Kamboju , Thomas Zimmermann , Helge Deller , linux-fbdev@vger.kernel.org Subject: Re: [PATCH] powerpc: include linux/backlight.h from asm/backlight.h In-Reply-To: <87bk7u5n9h.fsf@intel.com> References: <20240304095512.742348-1-jani.nikula@intel.com> <87bk7u5n9h.fsf@intel.com> Date: Tue, 05 Mar 2024 11:39:18 +1100 Message-ID: <87cys9pl55.fsf@mail.lhotse> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain Jani Nikula writes: > On Mon, 04 Mar 2024, Jani Nikula wrote: >> Removal of the backlight include from fb.h uncovered an implicit >> dependency in powerpc asm/backlight.h. Add the explicit include. >> >> Reported-by: Naresh Kamboju >> Closes: https://lore.kernel.org/r/CA+G9fYsAk5TbqqxFC2W4oHLGA0CbTHMxbeq8QayFXTU75YiueA@mail.gmail.com >> Fixes: 11b4eedfc87d ("fbdev: Do not include in header") >> Cc: Thomas Zimmermann >> Cc: Helge Deller >> Cc: linux-fbdev@vger.kernel.org >> Signed-off-by: Jani Nikula >> >> --- >> >> Not even compile tested! > > Naresh, please try this patch! > > Michael, if this is fine by you, ack to merge via the drm subsystem > along with the regressing commit? I prefer Thomas' patch, but I'm fine with either to go in via drm. cheers