Received-SPF: pass (google.com: domain of linux-kernel+bounces-91494-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <428622f8-8dd9-40c8-8762-6bdef6d3a785@intel.com>
Date: Mon, 4 Mar 2024 17:31:37 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v4 1/2] x86/resctrl: Pass domain to target CPU
Content-Language: en-US
To: "Luck, Tony" <tony.luck@intel.com>, "Yu, Fenghua" <fenghua.yu@intel.com>,
	Peter Newman <peternewman@google.com>, Jonathan Corbet <corbet@lwn.net>,
	Shuah Khan <skhan@linuxfoundation.org>, "x86@kernel.org" <x86@kernel.org>
CC: Shaopeng Tan <tan.shaopeng@fujitsu.com>, James Morse
	<james.morse@arm.com>, Jamie Iles <quic_jiles@quicinc.com>, Babu Moger
	<babu.moger@amd.com>, Randy Dunlap <rdunlap@infradead.org>, Drew Fustini
	<dfustini@baylibre.com>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>, "linux-doc@vger.kernel.org"
	<linux-doc@vger.kernel.org>, "patches@lists.linux.dev"
	<patches@lists.linux.dev>
References: <20240228112215.8044-tony.luck@intel.com>
 <20240228193717.8170-1-tony.luck@intel.com>
 <12766261-26b2-4aa4-a735-c2380c4963fd@intel.com>
 <SJ1PR11MB60839371908CDC17A01F2167FC222@SJ1PR11MB6083.namprd11.prod.outlook.com>
From: Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <SJ1PR11MB60839371908CDC17A01F2167FC222@SJ1PR11MB6083.namprd11.prod.outlook.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aXRHMUs0ZTh5TytlYjlpc0dXODM2b0pjVWxHT0hkNk9YemJqM2FNRG1CN0Rj?=
 =?utf-8?B?cEg1YTJKY0pWMGgwem1lNGNzWHpNb2Q3TWJLZk8vTUVoWlhhZzl6bWd0SnJI?=
 =?utf-8?B?UkhtNzdJWTlwRlBLVzJRWVk0Z2FNdENuMlVIdEJ5dW91eUxGNEE3VHJGeWpP?=
 =?utf-8?B?elFYRzB3R0xFMlpNczM1clpIN1BNT0ltNU9Ocjd1Vnpyekkxd0pidkVXb2lo?=
 =?utf-8?B?d1RYMTRzZ0RMTVZnbXhhd3NpTDZYZ0RJWDlBOE5pR2FDdU9nejc5T0tTR041?=
 =?utf-8?B?ME1zWjlyWDdKUDg5NnNYczFYb1BBbjNLTVZnelZnUWJWN0tyOGV4anB6Wk9a?=
 =?utf-8?B?ZWRyRjNVUk9MNkNtaDRPa1plUGdpMC9HQ2NEQ3B6bGtRSVhFejdVR1RpbU9O?=
 =?utf-8?B?YnVjZC9jTk9RR1JDb1NBQ0VhU1RDbmRxbEdBQXh4MmsxbFV6YW5hTEptaUdH?=
 =?utf-8?B?NlQwMWVkRmdmTTJHNmd0ZlkrR0hOQ3Y1YkJiNDBrc3ZtcjhMS2Q2eGc4RVp4?=
 =?utf-8?B?bTBzVDdLU3p4WlUxbjYrMkJyV0ZiN0pYMVVjMmVHT21oYUFWUEozMFlKWU9M?=
 =?utf-8?B?MG9pMnFKVWw1bHRJVHQzZUVjWnduL2FLV3o5VGVLckRiTTZQQVJ3aWducFVK?=
 =?utf-8?B?SkFNUEVSV0xBR1NsVVZxYXZuN1g5UjZNbWcyTGI3NHBqay9wTVYvM1duUFNs?=
 =?utf-8?B?MW5tcTYwUy9SWnpMRTltRUlsWm9lNW5JWXdQV2hUVUdpUVNTK0dvMkNnOUl3?=
 =?utf-8?B?K0V5YTdhblN4ZWd6Q2ZEbVdJTEFvR0RoellXY2hrNkxYYXF4TE5IWGVlUGRp?=
 =?utf-8?B?cGlITmlXMkZ2TlZYdU5JeGNRNENtMTRtQWpFZTBkR1lvMmJyTmNIU1FESzZ3?=
 =?utf-8?B?N05WT3pENE1yNlpaOWtmbDhtVVgxbGtKR2huWkxvTU94OVk2L1dqVW9PeStC?=
 =?utf-8?B?SVRyeFFFOThwdFluUnNvczd0UXRSbWZHaXB1WVZXcEM1WUhTaWRodVFYc0R5?=
 =?utf-8?B?SktvRUcweFI2QnovWk1ZamxScTFWVlE3SUVEay9qL2lYbkRQY3o3azRJTGEw?=
 =?utf-8?B?S2FRZSt0Q0ZITENJNzZnWllGTG9CZFVHMVJJUUpkV1VzTnM0emtDV240cmF0?=
 =?utf-8?B?UFEreHFPUEkwOXpqWWovSTlhM3B3WCtwaUw5dSsydnhEZ2RRUmhSb0VVcU1N?=
 =?utf-8?B?ejh6WkZSSWR4cnVmL3NoOGJSdWNlTEF0Ylo4U2dTcFdJdXhyTzZYdGVLbjlF?=
 =?utf-8?B?cEhaZ1VxdDhvUjdIc0hFZ0g4Y0xpZEQ3U1I5b3FmbGQ0N1MwU0c4ZzNTQ3FS?=
 =?utf-8?B?Y3I2QmMxSXpIenNMMlMwV3hmTXltWGp4NFRQMXJzbGVranpLQXNjd3gxaWlP?=
 =?utf-8?B?Z09XRm9TYjdrTXRLaUlndE9FeXViaStjMERyM2REbVRUYjBtR0sxRjczYzd2?=
 =?utf-8?B?TTV4cStxY0N6Y1BDYjZWYk5CRFVpSFJudUhkTFY2L0J2RGlybHlja1BXTEpO?=
 =?utf-8?B?cEllcHJTUkFPaWpYV3B3QWh0TnZQRVNIbmp0S1pGNTVIK2I4b0I1eHBFRWo5?=
 =?utf-8?B?VXY4UCtFM3p4SXZNZlBaVm0veEhLRWNOcTZjRDBaMFBrSlc1Y3ZIeGZ0ZmF1?=
 =?utf-8?B?Y041bDJGSE9pMTJGcUthalFSM2greml6eGlVM0JsS0g3V2lobVppWjlESjU5?=
 =?utf-8?B?NEwyZVNIRXZmZytsMGFmWStNTjc1dndkbzZibURzaTN2RzFibk5xMjgzdDhj?=
 =?utf-8?B?eHJXd2M3ZlAzYVhZeTB2czJJYlBtQStqNjNmelJoWkh1TEZRYnp6Y2o0UFRp?=
 =?utf-8?B?ZVZyZVJNbHRWUEdGL1prNVRHbXJaKzE4NHAyckh0QWRQWlRuS2U3SmZrQkh1?=
 =?utf-8?B?THpCZU1pejQxLzYwR0h0S1ZkQmUyS010djZqSXdidWlyc3QwNUZzZEs3cmJG?=
 =?utf-8?B?c2pmZzhscHVnYnZtTDZvRk1yRktjNDI5b3I4N0NSRkFOSDErMU9oV0tJaVJY?=
 =?utf-8?B?SjZBTGxUSEhmd3drM1JiRkdWYUVpNDdPWmJZaHRIZFlQQUk4QUx6L0ZjL2Rp?=
 =?utf-8?B?a2t4N1FqL241dmpVNzNJYkhtMmY4b1VFL2kzU3ZIWUF4M0cwdUFYRkpBSWp4?=
 =?utf-8?B?d0NMVEx0MkpQQU5zZFNXSy80THM2SkJUZDIrdGRyOENzb0pLL2NSNWxvK1E1?=
 =?utf-8?B?NXc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: b9f84a55-46f7-4a83-4d52-08dc3cb40295
X-MS-Exchange-CrossTenant-AuthSource: SN7PR11MB7566.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Mar 2024 01:31:41.7397
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: cuRKb9V58sLkB5tZ52p/KT2NxKbb22qMRfNoaANfct3XMZRFHPo1FGf3rfQoOGn6Ze8FPwrguJ8kxul1kESXo7u9pgvrpnUder7Ugkp9vxQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB7568
X-OriginatorOrg: intel.com

Hi Tony,

On 3/4/2024 4:17 PM, Luck, Tony wrote:
>>> +                   cpu = cpumask_any(&d->cpu_mask);
>>>
>>
>> cpu only needs to be assigned once. How about initializing cpu to
>> nr_cpu_ids at the same time msr_param.res and msr_param.dom is
>> initialized and only assign it when msr_param.res is assigned?
>> I think that will be more robust.
>>
>> If you agree and do this then please feel free to add:
>> Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>
> 
> Reinette,
> 
> I agree. I'll move the assignment to "cpu" outside the CDP_NUM_TYPES
> loop.
> 

If I understand correctly that would always look for a valid "cpu"
even when none is needed. Not quite what I proposed but should
work. Just some wasted cycles in a non critical path. 

Reinette