Received-SPF: pass (google.com: domain of linux-kernel+bounces-91509-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <ACE696AA8DB8D91B+458ebdd8-6951-4f72-a188-b21dc9863b90@shingroup.cn>
Date: Tue, 5 Mar 2024 09:43:16 +0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] arch/s390/perf: Register cpumf_pmu with type =
 PERF_TYPE_RAW
To: Mark Rutland <mark.rutland@arm.com>
Cc: Heiko Carstens <hca@linux.ibm.com>, Vasily Gorbik <gor@linux.ibm.com>,
 Alexander Gordeev <agordeev@linux.ibm.com>,
 Christian Borntraeger <borntraeger@linux.ibm.com>,
 Sven Schnelle <svens@linux.ibm.com>, linux-s390@vger.kernel.org,
 linux-kernel@vger.kernel.org
References: <20240304022701.7362-1-jialong.yang@shingroup.cn>
 <ZeWVi6pua5QVqz_y@FVFF77S0Q05N>
Content-Language: en-US
From: =?UTF-8?B?WWFuZyBKaWFsb25nIOadqOS9s+m+mQ==?= <jialong.yang@shingroup.cn>
In-Reply-To: <ZeWVi6pua5QVqz_y@FVFF77S0Q05N>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Feedback-ID: bizesmtp:shingroup.cn:qybglogicsvrgz:qybglogicsvrgz6a-1

在 2024/3/4 17:34, Mark Rutland 写道:
> On Mon, Mar 04, 2024 at 10:27:01AM +0800, JiaLong.Yang wrote:
>> The struct pmu cpumf_pmu has handled generic events. So it need some
>> flags to tell core this thing.
> 
> It's not necessary to register as PERF_TYPE_RAW in order to handle raw events,
> and PERF_TYPE_RAW is not a flag.
> 
> Have you encountered a functional problem, or was this found by inspection?
> 

As you expected, I'm trying to confirm which one pmu has the capability 
to handle generic events in registering pmus instead of test generic 
events in each pmus when opening.
We can confirm that before using. We have pay more in handling them when 
opening.
So most driver developers use PERF_TYPE_RAW. x86 and arm use 
PERF_PMU_CAP_EXTENDED_HW_TYPE. Others use struct pmu::task_ctx_nr = 
perf_hw_context.
I think PERF_TYPE_RAW will be a easily accepted way. So ...

How do you think about this?

> Mark.
> 
>> Signed-off-by: JiaLong.Yang <jialong.yang@shingroup.cn>
>> ---
>>   arch/s390/kernel/perf_cpum_cf.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/s390/kernel/perf_cpum_cf.c b/arch/s390/kernel/perf_cpum_cf.c
>> index 41ed6e0f0a2a..6ba36cf50091 100644
>> --- a/arch/s390/kernel/perf_cpum_cf.c
>> +++ b/arch/s390/kernel/perf_cpum_cf.c
>> @@ -1213,7 +1213,7 @@ static int __init cpumf_pmu_init(void)
>>   	debug_register_view(cf_dbg, &debug_sprintf_view);
>>   
>>   	cpumf_pmu.attr_groups = cpumf_cf_event_group();
>> -	rc = perf_pmu_register(&cpumf_pmu, "cpum_cf", -1);
>> +	rc = perf_pmu_register(&cpumf_pmu, "cpum_cf", PERF_TYPE_RAW);
>>   	if (rc) {
>>   		pr_err("Registering the cpum_cf PMU failed with rc=%i\n", rc);
>>   		goto out2;
>> -- 
>> 2.25.1
>>
>>
>