Received-SPF: pass (google.com: domain of linux-kernel+bounces-91511-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
From: "Tian, Kevin" <kevin.tian@intel.com>
To: Lu Baolu <baolu.lu@linux.intel.com>, Joerg Roedel <joro@8bytes.org>, "Will
 Deacon" <will@kernel.org>, Robin Murphy <robin.murphy@arm.com>, "Jason
 Gunthorpe" <jgg@ziepe.ca>, "Badger, Eric" <ebadger@purestorage.com>
CC: "iommu@lists.linux.dev" <iommu@lists.linux.dev>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v3 2/5] iommu/vt-d: Fix NULL domain on device release
Thread-Topic: [PATCH v3 2/5] iommu/vt-d: Fix NULL domain on device release
Thread-Index: AQHabp35lKyVBX8uH0CQzss8KryOc7EoYQzA
Date: Tue, 5 Mar 2024 01:48:17 +0000
Message-ID: <BN9PR11MB527680BD6A1F4E55A0DC8E298C222@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <20240305013305.204605-1-baolu.lu@linux.intel.com>
 <20240305013305.204605-3-baolu.lu@linux.intel.com>
In-Reply-To: <20240305013305.204605-3-baolu.lu@linux.intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?RFKUINX83rbH24ilXhVy3pKf3UTpBkCHmWeJQ7S2Z8vzKU2UoEG0+xR9M9nw?=
 =?us-ascii?Q?fMygjblRQyg9lLCXvxq24LXZTjwNwk1SJW1CJVaJQxrtVfoHnnlf3vaNhIwE?=
 =?us-ascii?Q?DtPyYskdZmTwxi8Fz4QqJaJspf2wTu3YfD2BjO1LwZ1WDQv4EWxtbId9gAko?=
 =?us-ascii?Q?Ksm9sL/WD+WYq7xCOO+5YGvgnXtZkX1gxwm/PvyyLGqjj0DPOpPpcoK2QGeH?=
 =?us-ascii?Q?9lcsql5XbZcBcDeeZJV7jHLK+CdeAk51hwcwyEpo9/Bi9vSWuSHfwaiEtI58?=
 =?us-ascii?Q?o0z9qUhDo3XsrW582UHg5jgnFZIszNkWh35A+FUX2r8E1amFKlT0Tb4PXbwn?=
 =?us-ascii?Q?TpNLLjmmC22/M590ormx2H6ZnZIVFft102UOwRD2GLLVwk2r0b1rYfOhjtO/?=
 =?us-ascii?Q?byHXbB9oKoOyOkuJxnxQ5l/sAUQDAOvK2djbAGwrporjgCRC4Y7i1gCqWs40?=
 =?us-ascii?Q?Ng8qXJ+r3ZsX+ydZpaeoJwhgN88StsmmhM8Jl4ZEJlkKx4HfFGcJBGSEE7iG?=
 =?us-ascii?Q?iDTc19dCw+9M4QXXH/pIbZ9meV3bGWTqsvzTW5KAmQizo+Wv3N7yggPIwupT?=
 =?us-ascii?Q?ci7QdiZsnZu2yph8kWAWyGAZ2sMJ6ZY9f7fy2qtsBbcy+w6XrQtmBhZ6hSZS?=
 =?us-ascii?Q?VurDp2Fb71YQGDrF7DPVtaHD6GYbcOgia4JGM5+TG2SxEdg4VwATxIJPZxQp?=
 =?us-ascii?Q?oKWB8DkElmADoiJCCdF49OwgLq0iijorwkUqwjnAu/hmK/f2zCAgHdRNWE8O?=
 =?us-ascii?Q?AwnSyw1I3tBrmawckjQuc/qc4w3fXm7P5/jTwfbkxYdmGrxQerzQv/c7QBBW?=
 =?us-ascii?Q?hvbM/IUZ32x1Asn4M4WsIoz3qrEPSO+sZ2N+wBgk8lfhSlPm/wqsZJy+inRZ?=
 =?us-ascii?Q?pZZ1eat7pblISiyFno1WFlgAOr40EGMXVt6MUyrm/XaTcRQHnBFsxsC/yzHu?=
 =?us-ascii?Q?PdsOZAsWDqDU1/K6e0c/poyvKY+D5pH2+2P++7Sy9ZnJ3OzZ2LgvLRG8rKpe?=
 =?us-ascii?Q?fOKCQzUBMSmN3oHlQJEzAnYh4mlzdEbRh0JaE+Hr35leCg7UzHaaVGxe6DgQ?=
 =?us-ascii?Q?ZLij3bIFnGnlcJS/iMQuF3h8lTpi8EKir2krY0BFVju7ZfkSeavjVSIW63NF?=
 =?us-ascii?Q?d2PwfzqdPuoAn+kxEBRluowjUR9dE+Z8r8/ryRCrlZ/S6NlaY+/Isv9MKb77?=
 =?us-ascii?Q?4gkWZ9qHVUHMbNZ5033g2+B8z6SBPf7mnLJOBNsJYYxjSanrFxSZQcKZ70qM?=
 =?us-ascii?Q?h/2agakTvpbSHrRHz8B2N3QXHz1ht6mwcX1e0pYVh3C6KR/t7k8riUCw4oOu?=
 =?us-ascii?Q?WzAL06OfZgFuiQQdwg1eZIy5VfgTZFXMmEdzTDdZXPykaJ5GXCY5KLiowWxG?=
 =?us-ascii?Q?E8XHnqhU8rbtFsp/ebO8lo2MSZDTvOBKX/DdhF1mi1NQ6+ZvRdMGnZ0sp3K6?=
 =?us-ascii?Q?hSQ5rjrtvE+kChOiHIxzj0eJeyf4TS4m1K+vy17j5M1wtWkNKOqCHUyafoe7?=
 =?us-ascii?Q?DiQ4ZiDrbSJ2IePWF7SWiIoV3r/q3Gq2MM+jkEiQXCRsUmiqcKIzRW+0u0G5?=
 =?us-ascii?Q?i2+vhmWp9XRSWOFxwotkrHQjKKoQK7vY6aEwWs5k?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 53f4cee9-0995-4517-3c9d-08dc3cb65404
X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Mar 2024 01:48:17.0771
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: IvDr7xYKxXSrxtMeDsdwuex5866AnGl/MvCeN0B/n/afApWbPoTZig99CY6G66fYoJISgZXe5X1Cgun3HhG9Uw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB8059
X-OriginatorOrg: intel.com

> From: Lu Baolu <baolu.lu@linux.intel.com>
> Sent: Tuesday, March 5, 2024 9:33 AM
>=20
> In the kdump kernel, the IOMMU operates in deferred_attach mode. In this
> mode, info->domain may not yet be assigned by the time the release_device
> function is called. It leads to the following crash in the crash kernel:
>=20
>     BUG: kernel NULL pointer dereference, address: 000000000000003c
>     ...
>     RIP: 0010:do_raw_spin_lock+0xa/0xa0
>     ...
>     _raw_spin_lock_irqsave+0x1b/0x30
>     intel_iommu_release_device+0x96/0x170
>     iommu_deinit_device+0x39/0xf0
>     __iommu_group_remove_device+0xa0/0xd0
>     iommu_bus_notifier+0x55/0xb0
>     notifier_call_chain+0x5a/0xd0
>     blocking_notifier_call_chain+0x41/0x60
>     bus_notify+0x34/0x50
>     device_del+0x269/0x3d0
>     pci_remove_bus_device+0x77/0x100
>     p2sb_bar+0xae/0x1d0
>     ...
>     i801_probe+0x423/0x740
>=20
> Use the release_domain mechanism to fix it. The scalable mode context
> entry which is not part of release_domain should be cleared in
> release_device().
>=20
> Fixes: 586081d3f6b1 ("iommu/vt-d: Remove DEFER_DEVICE_DOMAIN_INFO")
> Reported-by: Eric Badger <ebadger@purestorage.com>
> Closes: https://lore.kernel.org/r/20240113181713.1817855-1-
> ebadger@purestorage.com
> Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>

Reviewed-by: Kevin Tian <kevin.tian@intel.com>