Received-SPF: pass (google.com: domain of linux-kernel+bounces-91516-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Precedence: bulk
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date: Tue, 05 Mar 2024 03:52:41 +0200
Message-Id: <CZLFVTVPBFB4.3IIZULN3LKZGI@kernel.org>
Subject: Re: [PATCH] Documentation: tpm_tis
From: "Jarkko Sakkinen" <jarkko@kernel.org>
To: "Randy Dunlap" <rdunlap@infradead.org>, <linux-doc@vger.kernel.org>
Cc: "Jonathan Corbet" <corbet@lwn.net>, "Daniel P . Smith"
 <dpsmith@apertussolutions.com>, "Lino Sanfilippo"
 <l.sanfilippo@kunbus.com>, "Jason Gunthorpe" <jgg@ziepe.ca>, "Peter Huewe"
 <peterhuewe@gmx.de>, "James Bottomley"
 <James.Bottomley@HansenPartnership.com>, "Alexander Steffen"
 <Alexander.Steffen@infineon.com>, <keyrings@vger.kernel.org>,
 <linux-kernel@vger.kernel.org>, <linux-integrity@vger.kernel.org>
References: <20240304212734.43213-1-jarkko@kernel.org>
 <aed28265-d677-491a-a045-24b351854b24@infradead.org>
In-Reply-To: <aed28265-d677-491a-a045-24b351854b24@infradead.org>

On Tue Mar 5, 2024 at 12:53 AM EET, Randy Dunlap wrote:
>
>
> On 3/4/24 13:27, Jarkko Sakkinen wrote:
> > Based recent discussions on LKML, provide preliminary bits of tpm_tis_c=
ore
> > dependent drivers. Includes only bare essentials but can be extended la=
ter
> > on case by case. This way some people may even want to read it later on=
.
> >=20
> > Cc: Jonathan Corbet <corbet@lwn.net>
> > CC: Daniel P. Smith <dpsmith@apertussolutions.com>
> > Cc: Lino Sanfilippo <l.sanfilippo@kunbus.com>
> > Cc: Jason Gunthorpe <jgg@ziepe.ca>
> > Cc: Peter Huewe <peterhuewe@gmx.de>
> > Cc: James Bottomley <James.Bottomley@HansenPartnership.com>
> > Cc: Alexander Steffen <Alexander.Steffen@infineon.com>
> > Cc: keyrings@vger.kernel.org
> > Cc: linux-doc@vger.kernel.org
> > Cc: linux-kernel@vger.kernel.org
> > Cc: linux-integrity@vger.kernel.org
> > Signed-off-by: Jarkko Sakkinen <jarkko@kernel.org>
> > ---
> >  Documentation/security/tpm/index.rst   |  1 +
> >  Documentation/security/tpm/tpm_tis.rst | 30 ++++++++++++++++++++++++++
> >  2 files changed, 31 insertions(+)
> >  create mode 100644 Documentation/security/tpm/tpm_tis.rst
> >=20
>
> > diff --git a/Documentation/security/tpm/tpm_tis.rst b/Documentation/sec=
urity/tpm/tpm_tis.rst
> > new file mode 100644
> > index 000000000000..3cec0216a169
> > --- /dev/null
> > +++ b/Documentation/security/tpm/tpm_tis.rst
> > @@ -0,0 +1,30 @@
> > +.. SPDX-License-Identifier: GPL-2.0
> > +
> > +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D
> > +TPM FIFO interface Driver
> > +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D
> > +
> > +FIFO (First-In-First-Out) is the name of the hardware interface used b=
y the
> > +`tpm_tis_core` dependent drivers. The prefix "tis" is named after TPM
> > +Interface Specification, which is the hardware interface specification=
 for
> > +TPM 1.x chips.
> > +
> > +Communication is based on a 5 KiB buffer shared by the TPM chip throug=
h a
> > +hardware bus or memory map. The buffer is further split to five equal =
size
> > +buffers, which provide equivalent sets of registers for communication
> > +between CPU and TPM. The communication end points are called *localiti=
es*
> > +in the TCG terminology.
> > +
> > +When a kernel wants to send a commands to the TPM chip, it first reser=
ves
> > +locality 0 by setting `requestUse` bit in `TPM_ACCESS` register. The b=
it is
> > +cleared by the chip when the access is granted. Once completed its
> > +communication, it sets `activeLocity` bit in the same register.
>
>       Is that              activeLocality ?

Yes.

>
> > +
> > +Pending localities are served in order by the chip descending orderm a=
nd
> > +one at a time:
> > +
> > +- Locality 0 has the lowest priority.
> > +- Locality 5 has the highest priotiy.
>
>                                 priority.
>
> > +
> > +Further information on purpose and meaning of the localities can be fo=
und
> > +from section 3.2 of TCG PC Client Platform TPM Profile Specification.

Thanks for the remarks. Too many typos but at least I think the story is
is understandable and describes pretty well key elements of tpm_tis_core.

BR, Jarkko