Received-SPF: pass (google.com: domain of linux-kernel+bounces-91519-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Precedence: bulk
MIME-Version: 1.0
References: <20240111081743.2999210-1-chao@kernel.org> <ae43ed8a-49b5-44bf-8fea-a222091e9790@kernel.org>
 <ed3eecaf9e2f4c8fae2fd01241aa097e@BJMBX02.spreadtrum.com>
In-Reply-To: <ed3eecaf9e2f4c8fae2fd01241aa097e@BJMBX02.spreadtrum.com>
From: Zhiguo Niu <niuzhiguo84@gmail.com>
Date: Tue, 5 Mar 2024 09:56:56 +0800
Message-ID: <CAHJ8P3JzanzGqjuJ8ODMxE4rguxrQ-yd4Ho16RCDH9u975gOEA@mail.gmail.com>
Subject: Re: [PATCH v3] f2fs: reduce expensive checkpoint trigger frequency
To: =?UTF-8?B?54mb5b+X5Zu9IChaaGlndW8gTml1KQ==?= <Zhiguo.Niu@unisoc.com>
Cc: "jaegeuk@kernel.org" <jaegeuk@kernel.org>, 
	"linux-f2fs-devel@lists.sourceforge.net" <linux-f2fs-devel@lists.sourceforge.net>, 
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Chao Yu <chao@kernel.org>, 
	=?UTF-8?B?6YeR57qi5a6HIChIb25neXUgSmluKQ==?= <hongyu.jin@unisoc.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Dear  Jaegeuk,

Let me describe the problem process, it is reproduced by monkey stability t=
est:

 1.SBI_NEED_CP flag bit is set=EF=BC=8C
 set_sbi_flag(F2FS_I_SB(inode), SBI_NEED_CP);

 2.Ckpt thread is blocked by IO busy when it is doing CP,  it can not
get request tag from block queue,
 PID: 505      TASK: ffffff80ed7f49c0  CPU: 4    COMMAND: "f2fs_ckpt-254:4"
 #0 [ffffffc015fcb330] __switch_to at ffffffc010196350
 #1 [ffffffc015fcb390] __schedule at ffffffc01168e53c
 #2 [ffffffc015fcb3f0] schedule at ffffffc01168ed7c
 #3 [ffffffc015fcb450] io_schedule at ffffffc01168f7a0
 #4 [ffffffc015fcb4c0] blk_mq_get_tag at ffffffc0101008a4
 #5 [ffffffc015fcb530] blk_mq_get_request at ffffffc0109241b0
 #6 [ffffffc015fcb5f0] blk_mq_make_request at ffffffc0109233bc
 #7 [ffffffc015fcb680] generic_make_request at ffffffc0100fc6ec
 #8 [ffffffc015fcb700] submit_bio at ffffffc0100fc3b8
 #9 [ffffffc015fcb750] __submit_bio at ffffffc01081a2e0
 #10 [ffffffc015fcb7d0] __submit_merged_bio at ffffffc01081b07c
 #11 [ffffffc015fcb8a0] f2fs_submit_page_write at ffffffc0100ecd3c
 #12 [ffffffc015fcb990] f2fs_do_write_meta_page at ffffffc010845738
 #13 [ffffffc015fcb9d0] __f2fs_write_meta_page at ffffffc01080a8f4
 #14 [ffffffc015fcbb60] f2fs_sync_meta_pages at ffffffc01080a684
 #15 [ffffffc015fcbca0] do_checkpoint at ffffffc01080f0a8
 #16 [ffffffc015fcbd10] f2fs_write_checkpoint at ffffffc01080e50c
 #17 [ffffffc015fcbdb0] __checkpoint_and_complete_reqs at ffffffc010810f54
 #18 [ffffffc015fcbe40] issue_checkpoint_thread at ffffffc0108113ec
 #19 [ffffffc015fcbe80] kthread at ffffffc0102665b0

 3.Subsequent regular file fsync will trigger ckpt because SBI_NEED_CP
has not been cleared.
 In fact, these cases should not trigger ckpt.

 4.If some processes that perform f2fs_do_sync_file are important processes
 in the system(such as init) and are blocked for too long, it will
cause other problems in the system, ANR or android reboot
 PID: 287      TASK: ffffff80f9eb0ec0  CPU: 2    COMMAND: "init"
 #0 [ffffffc01389bab0] __switch_to at ffffffc010196350
 #1 [ffffffc01389bb10] __schedule at ffffffc01168e53c
 #2 [ffffffc01389bb70] schedule at ffffffc01168ed7c
 #3 [ffffffc01389bbc0] wait_for_completion at ffffffc011692368
 #4 [ffffffc01389bca0] f2fs_issue_checkpoint at ffffffc010810cb0
 #5 [ffffffc01389bd00] f2fs_sync_fs at ffffffc0107f4e1c
 #6 [ffffffc01389bdc0] f2fs_do_sync_file at ffffffc0107d4d44
 #7 [ffffffc01389be20] f2fs_sync_file at ffffffc0107d492c
 #8 [ffffffc01389be30] __arm64_sys_fsync at ffffffc0105d31d8
 #9 [ffffffc01389be70] el0_svc_common at ffffffc0101aa550
 #10 [ffffffc01389beb0] el0_svc_handler at ffffffc0100886fc

and I tested Chao's patch can avoid the above case, please help
consider this patch or
any comment/suggestions about this?

thanks!

On Mon, Feb 26, 2024 at 9:22=E2=80=AFAM =E7=89=9B=E5=BF=97=E5=9B=BD (Zhiguo=
 Niu) <Zhiguo.Niu@unisoc.com> wrote:
>
>
> Hi Jaegeuk
>
> Sorry for disturbing you, Do you have any comments about this patch from =
Chao, I=E2=80=99ve met this issue several times on our platform when do mon=
key test.
> Thanks!
>
> -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6-----
> =E5=8F=91=E4=BB=B6=E4=BA=BA: Chao Yu <chao@kernel.org>
> =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2024=E5=B9=B42=E6=9C=8819=E6=97=A5 =
15:19
> =E6=94=B6=E4=BB=B6=E4=BA=BA: jaegeuk@kernel.org
> =E6=8A=84=E9=80=81: linux-f2fs-devel@lists.sourceforge.net; linux-kernel@=
vger.kernel.org; =E7=89=9B=E5=BF=97=E5=9B=BD (Zhiguo Niu) <Zhiguo.Niu@uniso=
c.com>
> =E4=B8=BB=E9=A2=98: Re: [PATCH v3] f2fs: reduce expensive checkpoint trig=
ger frequency
>
>
> =E6=B3=A8=E6=84=8F: =E8=BF=99=E5=B0=81=E9=82=AE=E4=BB=B6=E6=9D=A5=E8=87=
=AA=E4=BA=8E=E5=A4=96=E9=83=A8=E3=80=82=E9=99=A4=E9=9D=9E=E4=BD=A0=E7=A1=AE=
=E5=AE=9A=E9=82=AE=E4=BB=B6=E5=86=85=E5=AE=B9=E5=AE=89=E5=85=A8=EF=BC=8C=E5=
=90=A6=E5=88=99=E4=B8=8D=E8=A6=81=E7=82=B9=E5=87=BB=E4=BB=BB=E4=BD=95=E9=93=
=BE=E6=8E=A5=E5=92=8C=E9=99=84=E4=BB=B6=E3=80=82
> CAUTION: This email originated from outside of the organization. Do not c=
lick links or open attachments unless you recognize the sender and know the=
 content is safe.
>
>
>
> Jaegeuk,
>
> Any comments?
>
> On 2024/1/11 16:17, Chao Yu wrote:
> > We may trigger high frequent checkpoint for below case:
> > 1. mkdir /mnt/dir1; set dir1 encrypted 2. touch /mnt/file1; fsync
> > /mnt/file1 3. mkdir /mnt/dir2; set dir2 encrypted 4. touch /mnt/file2;
> > fsync /mnt/file2 ...
> >
> > Although, newly created dir and file are not related, due to commit
> > bbf156f7afa7 ("f2fs: fix lost xattrs of directories"), we will trigger
> > checkpoint whenever fsync() comes after a new encrypted dir created.
> >
> > In order to avoid such condition, let's record an entry including
> > directory's ino into global cache when we initialize encryption policy
> > in a checkpointed directory, and then only trigger checkpoint() when
> > target file's parent has non-persisted encryption policy, for the case
> > its parent is not checkpointed, need_do_checkpoint() has cover that by
> > verifying it with f2fs_is_checkpointed_node().
> >
> > Reported-by: Zhiguo Niu <zhiguo.niu@unisoc.com>
> > Tested-by: Zhiguo Niu <zhiguo.niu@unisoc.com>
> > Reported-by: Yunlei He <heyunlei@hihonor.com>
> > Signed-off-by: Chao Yu <chao@kernel.org>
> > ---
> > v3:
> > - Recently, Zhiguo Niu reported the same issue, so I repost this patch
> > for comments.
> >   fs/f2fs/f2fs.h              |  2 ++
> >   fs/f2fs/file.c              |  3 +++
> >   fs/f2fs/xattr.c             | 16 ++++++++++++++--
> >   include/trace/events/f2fs.h |  3 ++-
> >   4 files changed, 21 insertions(+), 3 deletions(-)
> >
> > diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h index
> > e2e0ca45f881..0094a8c85f4a 100644
> > --- a/fs/f2fs/f2fs.h
> > +++ b/fs/f2fs/f2fs.h
> > @@ -279,6 +279,7 @@ enum {
> >       APPEND_INO,             /* for append ino list */
> >       UPDATE_INO,             /* for update ino list */
> >       TRANS_DIR_INO,          /* for transactions dir ino list */
> > +     ENC_DIR_INO,            /* for encrypted dir ino list */
> >       FLUSH_INO,              /* for multiple device flushing */
> >       MAX_INO_ENTRY,          /* max. list */
> >   };
> > @@ -1147,6 +1148,7 @@ enum cp_reason_type {
> >       CP_FASTBOOT_MODE,
> >       CP_SPEC_LOG_NUM,
> >       CP_RECOVER_DIR,
> > +     CP_ENC_DIR,
> >   };
> >
> >   enum iostat_type {
> > diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c index
> > 8198afb5fb9c..18b33b1f0c83 100644
> > --- a/fs/f2fs/file.c
> > +++ b/fs/f2fs/file.c
> > @@ -218,6 +218,9 @@ static inline enum cp_reason_type need_do_checkpoin=
t(struct inode *inode)
> >               f2fs_exist_written_data(sbi, F2FS_I(inode)->i_pino,
> >                                                       TRANS_DIR_INO))
> >               cp_reason =3D CP_RECOVER_DIR;
> > +     else if (f2fs_exist_written_data(sbi, F2FS_I(inode)->i_pino,
> > +                                                     ENC_DIR_INO))
> > +             cp_reason =3D CP_ENC_DIR;
> >
> >       return cp_reason;
> >   }
> > diff --git a/fs/f2fs/xattr.c b/fs/f2fs/xattr.c index
> > f290fe9327c4..cbd1b88297fe 100644
> > --- a/fs/f2fs/xattr.c
> > +++ b/fs/f2fs/xattr.c
> > @@ -629,6 +629,7 @@ static int __f2fs_setxattr(struct inode *inode, int=
 index,
> >                       const char *name, const void *value, size_t size,
> >                       struct page *ipage, int flags)
> >   {
> > +     struct f2fs_sb_info *sbi =3D F2FS_I_SB(inode);
> >       struct f2fs_xattr_entry *here, *last;
> >       void *base_addr, *last_base_addr;
> >       int found, newsize;
> > @@ -772,8 +773,19 @@ static int __f2fs_setxattr(struct inode *inode, in=
t index,
> >       if (index =3D=3D F2FS_XATTR_INDEX_ENCRYPTION &&
> >                       !strcmp(name, F2FS_XATTR_NAME_ENCRYPTION_CONTEXT)=
)
> >               f2fs_set_encrypted_inode(inode);
> > -     if (S_ISDIR(inode->i_mode))
> > -             set_sbi_flag(F2FS_I_SB(inode), SBI_NEED_CP);
> > +
> > +     if (S_ISDIR(inode->i_mode)) {
> > +             /*
> > +              * In restrict mode, fsync() always tries triggering chec=
kpoint
> > +              * for all metadata consistency, in other mode, it only t=
riggers
> > +              * checkpoint when parent's encryption metadata updates.
> > +              */
> > +             if (F2FS_OPTION(sbi).fsync_mode =3D=3D FSYNC_MODE_STRICT)
> > +                     set_sbi_flag(F2FS_I_SB(inode), SBI_NEED_CP);
> > +             else if (IS_ENCRYPTED(inode) &&
> > +                     f2fs_is_checkpointed_node(sbi, inode->i_ino))
> > +                     f2fs_add_ino_entry(sbi, inode->i_ino, ENC_DIR_INO=
);
> > +     }
> >
> >   same:
> >       if (is_inode_flag_set(inode, FI_ACL_MODE)) { diff --git
> > a/include/trace/events/f2fs.h b/include/trace/events/f2fs.h index
> > 7ed0fc430dc6..48f2e399e184 100644
> > --- a/include/trace/events/f2fs.h
> > +++ b/include/trace/events/f2fs.h
> > @@ -139,7 +139,8 @@ TRACE_DEFINE_ENUM(EX_BLOCK_AGE);
> >               { CP_NODE_NEED_CP,      "node needs cp" },              \
> >               { CP_FASTBOOT_MODE,     "fastboot mode" },              \
> >               { CP_SPEC_LOG_NUM,      "log type is 2" },              \
> > -             { CP_RECOVER_DIR,       "dir needs recovery" })
> > +             { CP_RECOVER_DIR,       "dir needs recovery" },         \
> > +             { CP_ENC_DIR,           "persist encryption policy" })
> >
> >   #define show_shutdown_mode(type)                                    \
> >       __print_symbolic(type,                                          \