Received-SPF: pass (google.com: domain of linux-kernel+bounces-91554-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240227192704.376176-1-e.velu@criteo.com> <827d22da-fb32-1012-422d-d283b28ce5ec@intel.com>
In-Reply-To: <827d22da-fb32-1012-422d-d283b28ce5ec@intel.com>
From: Erwan Velu <erwanaliasr1@gmail.com>
Date: Tue, 5 Mar 2024 03:22:43 +0100
Message-ID: <CAL2Jzuzf54qcsCM4CAUOLaogWrBL=Mm4ma_4pRbaf8A=dZeOFQ@mail.gmail.com>
Subject: Re: [PATCH] i40e: Prevent setting MTU if greater than MFS
To: Tony Nguyen <anthony.l.nguyen@intel.com>
Cc: Erwan Velu <e.velu@criteo.com>, Jesse Brandeburg <jesse.brandeburg@intel.com>, 
	"David S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, 
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, intel-wired-lan@lists.osuosl.org, 
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Le lun. 4 mars 2024 =C3=A0 23:10, Tony Nguyen <anthony.l.nguyen@intel.com> =
a =C3=A9crit :
> > Signed-off-by: Erwan Velu <e.velu@criteo.com>
>
> The Author and Sign-off needs to be fixed; they don't match.
>
> WARNING: From:/Signed-off-by: email address mismatch: 'From: Erwan Velu
> <erwanaliasr1@gmail.com>' !=3D 'Signed-off-by: Erwan Velu <e.velu@criteo.=
com>'

Yeah, I have a complicated email setup between my personal and
professional emails.
I'll see how I can fix that.

I was also wondering if I shouldn't subtract I40E_PACKET_HDR_PAD from
the mfs to be more accurate, can you confirm this ?

If one can have a look at what is the exact procedure to fix the MFS
size when too small, that would be lovely/ideal in addition to my
patch.