Received: by 2002:a89:2c3:0:b0:1ed:23cc:44d1 with SMTP id d3csp139271lqs; Mon, 4 Mar 2024 18:48:09 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCUf/PEytAd+A5+5YOUtwc48c6Aw2aiov69ARJ39B7HtyYa3ROWcTG74HdTe4mEGBpLD0vQUW00iYPY4o4u0LwDYggTjYFsS15sWG4SC2Q== X-Google-Smtp-Source: AGHT+IHALs8kPFRGcc0vV9r+2EQnQgaSECD0SQZVer0750maHdPH4vtS6Yp3RqzMz+IgYV/Ix/pD X-Received: by 2002:a05:6871:42ca:b0:21e:5f33:9f5b with SMTP id lt10-20020a05687142ca00b0021e5f339f5bmr688519oab.26.1709606889192; Mon, 04 Mar 2024 18:48:09 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709606889; cv=pass; d=google.com; s=arc-20160816; b=pE/p/PoOmwthEjCLDh3EWE4jHX3GMGOyYMee65npIdWxU5dVA/xW2WbEaoa4bgNOUo lDNf6tWJYFIqEV6r2OUEue8hAuZ5OdUSAfxEilSoHmlM9jIi+JobfMtxX0o+EMpcmy6i /Yj3iyaLokBxaI3deHIMBAiuaL7r+9uNCYrcN8cE+gfgDEGP1nqfqoPEBXdsS0EywEV0 /YQgscHCnZLlRmZlkPTVAvbTho/+iRGA1PYB6ANIhhlA8k5kFg2XnOy8fAlqUwL2qHf5 XOep13pY1gH1SjtN3Iud0DcRlfiokuzeusD/Li2DMEM/4zxhDhwmBS1owy6PPpRLEmaX 8YRA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=0T1Pf6i0U9jq7TnISrUd+TgQ25I5SY6Dtbz66ISnEuI=; fh=AF8u3Hq2LCAR86VDBUa9qi/2kjQJaPvHiqWvnKg4Z08=; b=Toi1Wln08lyNmlrrCxhY9mCJ0kQt159UnGYxpe0eb5uSQi8N+x6oCspmHaDZFSu3Db o2NvS1l66d6++evEI0LIjE1e1qOEWpL68O5O7yg+peVcT+hgiUpIMK7CqZbd84Mb6kKL iAeylvjHCVePa08b2UpNUF0enAmMjUeOALzj7R8vdKD0ckiJxc/yks9tyySc/DU734Ob MeQJfejIjSaJ7Z5nYf/eCqlmVHjtsWGpy3+K7Q8RvJBMi30sDl5sQUZkljBStTafCpKf amO6HIK8CEhZcVdisjcmdtYuJTSxCxz2/qsO2XDsPU/p4g8q6UvGsIvGcva4neGsM40H M0HA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=NntN6rcQ; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-91578-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-91578-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id k38-20020a634b66000000b005dc957fe128si9027475pgl.74.2024.03.04.18.48.08 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Mar 2024 18:48:09 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-91578-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=NntN6rcQ; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-91578-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-91578-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 78C87280D84 for ; Tue, 5 Mar 2024 02:48:06 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id F15CC28DB5; Tue, 5 Mar 2024 02:47:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="NntN6rcQ" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 18D3D18046; Tue, 5 Mar 2024 02:47:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709606860; cv=none; b=U0Tl68XceqY7hDKz6EoJZdCa0k30ZWNCfZabSB+Dk3NYUs9Zq93tVOOGS96yPuxCsWJDQ6Q6KtgNs09+ZU1AdE90Qux+drMSsJgG70dhbsbsN79AbmHV7fm5lkwiu6gxTo1WFUtUmXZOqRWMGKvQ6pYdIAjtGxeSCrkyZCnMPTQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709606860; c=relaxed/simple; bh=0T1Pf6i0U9jq7TnISrUd+TgQ25I5SY6Dtbz66ISnEuI=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=cnOH8Js59H4lT7WCCpPZEK/7OTUQKKo3fBxgLyZ8GKBxNB6grnONegb5ysT97rVIcwV5Dgoh3vkGhtSHJtwWiSOfLK9Ea0rf3+iqo0lRDuEzrFp0M7fbk7QXJAVrdtUh6sC8MLueQfrEUKfC+MDeEJlNzqgnaL4+/Qu1O7frKHc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=NntN6rcQ; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8BBFCC433F1; Tue, 5 Mar 2024 02:47:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1709606859; bh=0T1Pf6i0U9jq7TnISrUd+TgQ25I5SY6Dtbz66ISnEuI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=NntN6rcQrBzH+ryrj/O7wjmTpVTbXFR6scbPvOAVGwp8pyy9wCL/Q6TM5UzuXim7R 5RhzKsRZyp9/sauT3Z2R9Nxr4epg6SDfH3ysSmAQINHlhpRnlbJgdXG5s9m1eza7UZ 5/IyXBss8WTcXet09VmIAO9AwChSJqrDtOq5L/bXyjXuRNJ0dtOg1aJhlpAbPqr3gL g4/pF0lWyUP3BamLZ1Dj5t9oh9nRw4T3ByM3+Y7DZzw5+uXxSQtgUe/OCaYeq/aNAV CN5R5HR5e6tx0IrwxN/BFSaU1c6EhD/mYqHJPzmi2O/VgCuicAOypi8XE2kqSE7QmR Ywu4vPc11BmJw== Date: Mon, 4 Mar 2024 18:47:37 -0800 From: Jakub Kicinski To: Kory Maincent Cc: Florian Fainelli , Broadcom internal kernel review list , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Paolo Abeni , Richard Cochran , Radu Pirea , Jay Vosburgh , Andy Gospodarek , Nicolas Ferre , Claudiu Beznea , Willem de Bruijn , Jonathan Corbet , Horatiu Vultur , UNGLinuxDriver@microchip.com, Simon Horman , Vladimir Oltean , Thomas Petazzoni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, Maxime Chevallier , Rahul Rameshbabu Subject: Re: [PATCH net-next v9 07/13] ptp: Move from simple ida to xarray Message-ID: <20240304184737.30cac57b@kernel.org> In-Reply-To: <20240226-feature_ptp_netnext-v9-7-455611549f21@bootlin.com> References: <20240226-feature_ptp_netnext-v9-0-455611549f21@bootlin.com> <20240226-feature_ptp_netnext-v9-7-455611549f21@bootlin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 26 Feb 2024 14:39:58 +0100 Kory Maincent wrote: > +static DEFINE_XARRAY_FLAGS(ptp_clocks_map, XA_FLAGS_LOCK_IRQ | XA_FLAGS_ALLOC); Why _IRQ? anything on the fastpath hopefully has a pointer to the clock already, I'd hope. And we often reserve ID 0 as invalid. IOW DEFINE_XARRAY_ALLOC1() ? BTW could be a standalone patch, Xarray conversion from IDA is an improvement in itself.