Received-SPF: pass (google.com: domain of linux-kernel+bounces-91386-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Feedback-ID: iac594737:Fastmail
Date: Mon, 4 Mar 2024 17:58:05 -0500
From: Demi Marie Obenour <demi@invisiblethingslab.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: linux-usb@vger.kernel.org,
	Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: usbip doesn't work with userspace code that accesses USB devices
Message-ID: <ZeZSADZlMGKs3mrz@itl-email>
References: <ZeYov0k8njwcZzGX@itl-email>
 <2024030406-kilogram-raving-33c5@gregkh>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="ilsjY3LIWibyEmY7"
Content-Disposition: inline
In-Reply-To: <2024030406-kilogram-raving-33c5@gregkh>


--ilsjY3LIWibyEmY7
Content-Type: text/plain; protected-headers=v1; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Date: Mon, 4 Mar 2024 17:58:05 -0500
From: Demi Marie Obenour <demi@invisiblethingslab.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: linux-usb@vger.kernel.org,
	Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: usbip doesn't work with userspace code that accesses USB devices

On Mon, Mar 04, 2024 at 09:04:00PM +0000, Greg Kroah-Hartman wrote:
> On Mon, Mar 04, 2024 at 03:01:51PM -0500, Demi Marie Obenour wrote:
> > Qubes OS users are reporting that MTP doesn't work with USB passthrough.
> > Fastboot (used for flashing a custom OS to an Android device) also
> > doesn't work.  Kernel-mode drivers, such as Bluetooth and USB storage,
> > seem to usually work as expected.  Since MTP and fastboot are both
> > implemented in userspace, it appears that there is some problem with the
> > interaction of usbip, our USB proxy (which is based on USBIP), and
> > userspace programs that interact with USB devices directly.
> >=20
> > The bug report can be found at [1] and the source code for the USB proxy
> > can be found at [2].  The script used on the sending side (the one with
> > the physical USB controller) is at [3] and the script used by the
> > receiving side (the one the device is attached to) is at [4].  All of
> > these links are for the current version as of this email being sent, so
> > that anyone looking at this email in the future doesn't get confused.
> >=20
> > Is this a bug in usbip, or is this due to usbip being used incorrectly?
>=20
> I'm amazed that usbip works with usbfs at all, I didn't think that was a
> thing.

If it isn't a thing, then how would one go about making it be a thing?
usbfs not supporting usbip would certainly explain the behavior we are
seeing, but this also means that usbip is not a complete solution for
our use-case.  I had assumed that usbip simply created a new USB device
that was just as functional as any device implemented in hardware.

> If you have a reproducer, or some error messages somewhere, that might
> be the easiest way forward.

Multiple users have 100% reliable reproducers, and I believe (but am not
certain) that Marek can reproduce this problem too.  Writing a
reproducer that doesn't involve Qubes OS or any USB peripherals would be
quite a bit harder, mostly because I can't think of any way to run into
this bug without either having least two machines (either physical or
virtual) or using usbip from a machine to itself (which would be rather
strange and might throw things off).  It would also be necessary to
somehow emulate the USB device in question.

> In reading the bug report, it looks like
> the "bridge" you all made can't handle the device disconnecting itself
> properly?  But that's just a guess, could be anything.

What is the proper way to deal with disconnections?  It's quite possible
that the shell scripts have a bug somewhere, but I'm not sure what it
is.
--=20
Sincerely,
Demi Marie Obenour (she/her/hers)
Invisible Things Lab

--ilsjY3LIWibyEmY7
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEdodNnxM2uiJZBxxxsoi1X/+cIsEFAmXmUf8ACgkQsoi1X/+c
IsE/2A/9H+G2h93AG01v1CtSfs0PG33pqtVXxaOkYD/6ccY2xyEw30GnX6gUwI7B
3FxdVUdb4GoSqxup+e6ZpRWIjoaBl9vkrWft0mbwP2ImNUGrdBj4E2sZY3q3vL+Z
93YUIusxM45LrSdEzIv0dJGtC4BFTfAcoc9EtZk3LP/Z5qvnDDIqpfeKhnKbKDHs
tV9AkywL0J9ZLRWYACe6yYVw7RvMyqZvAmTcZLaT4XniDt7R0dbrEyBQupND5OZl
sku8xX6MujHPxOGfBB0GuE3E4Oos208LlDN2l8BgnXY+iGY7b3l1MSjYa6RJgxRD
Iy3IxkpvoYfzB3qZGV4RY0bQcVrRBRIPaEiBRpKTVd+JlPccLu+17cRVOeVDSBMU
SpDHr56Op9cOEstYyH0Kfho2ADY8v1H2SX5c5h1uJ6te7NPYKiYkfL+PqbxWsEl6
ehgqUqfGmM9Hk9Hb7R/GAxIvDeOAanDLPf6kJGwa4f8ySxWPFgXutEP02t6k3SKT
MW3oEJex16Cjk2zp4QpCINTgRcJKhGt3HDX4tWJhxllMaCXROrr+tyt/P0eSC06a
raIsvnC1eYaYeZIN/Tk3uXThXF36qWJKO+jQY0neaq5r4QC+QSil2xXJWgjsTcPW
v5Ncczvw8LBrRUoPcn/93WptF4WJDgow2vvHRH6NfXVZHxR9Ns4=
=DPIT
-----END PGP SIGNATURE-----

--ilsjY3LIWibyEmY7--