Received-SPF: pass (google.com: domain of linux-kernel+bounces-91176-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Mon, 4 Mar 2024 19:27:18 +0000
From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Robert Marko <robimarko@gmail.com>
Cc: andersson@kernel.org, konrad.dybcio@linaro.org, andrew@lunn.ch,
	hkallweit1@gmail.com, davem@davemloft.net, edumazet@google.com,
	kuba@kernel.org, pabeni@redhat.com, ansuelsmth@gmail.com,
	linux-arm-msm@vger.kernel.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, kernel test robot <lkp@intel.com>
Subject: Re: [PATCH net] net: phy: qca807x: fix compilation when
 CONFIG_GPIOLIB is not set
Message-ID: <ZeYglnW6/k0nvmiL@shell.armlinux.org.uk>
References: <20240304192244.2924407-1-robimarko@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240304192244.2924407-1-robimarko@gmail.com>
Sender: Russell King (Oracle) <linux@armlinux.org.uk>

On Mon, Mar 04, 2024 at 08:21:36PM +0100, Robert Marko wrote:
> -	if (IS_ENABLED(CONFIG_GPIOLIB)) {
> +#if IS_ENABLED(CONFIG_GPIOLIB)
>  		/* Make sure we don't have mixed leds node and gpio-controller
>  		 * to prevent registering leds and having gpio-controller usage
>  		 * conflicting with them.
> @@ -749,7 +749,7 @@ static int qca807x_probe(struct phy_device *phydev)
>  			if (ret)
>  				return ret;
>  		}
> -	}
> +#endif

I know it makes for a bigger patch, but #if is not equivalent to if()
in terms of indentation, so the indentation also needs to be changed.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!