Received-SPF: pass (google.com: domain of linux-kernel+bounces-90401-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <33145efb-b13c-4a1c-9542-9a185fca7b01@collabora.com>
Date: Mon, 4 Mar 2024 11:12:38 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 2/4] arm64: dts: mediatek: mt7622: fix IR nodename
Content-Language: en-US
To: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= <zajec5@gmail.com>,
 Matthias Brugger <matthias.bgg@gmail.com>, Rob Herring <robh@kernel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
 Conor Dooley <conor+dt@kernel.org>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
 linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
 =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= <rafal@milecki.pl>
References: <20240301113506.22944-1-zajec5@gmail.com>
 <20240301113506.22944-3-zajec5@gmail.com>
From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
In-Reply-To: <20240301113506.22944-3-zajec5@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Il 01/03/24 12:35, Rafał Miłecki ha scritto:
> From: Rafał Miłecki <rafal@milecki.pl>
> 
> Fix following validation error:
> arch/arm64/boot/dts/mediatek/mt7622-rfb1.dtb: cir@10009000: $nodename:0: 'cir@10009000' does not match '^ir(-receiver)?(@[a-f0-9]+)?$'
>          from schema $id: http://devicetree.org/schemas/media/mediatek,mt7622-cir.yaml#
> 
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>

Is this an IR receiver, an IR transmitter or a xceiver?

While we're fixing that node name, we might as well increase readability of (and
somewhat implicitly document) this.

.. so, that might be...:

ir-receiver@xxxxx {
...

Cheers,
Angelo

> ---
>   arch/arm64/boot/dts/mediatek/mt7622.dtsi | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/mediatek/mt7622.dtsi b/arch/arm64/boot/dts/mediatek/mt7622.dtsi
> index 283fdf7d2d8b..7714775d1bd0 100644
> --- a/arch/arm64/boot/dts/mediatek/mt7622.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt7622.dtsi
> @@ -252,7 +252,7 @@ scpsys: power-controller@10006000 {
>   		clock-names = "hif_sel";
>   	};
>   
> -	cir: cir@10009000 {
> +	cir: ir@10009000 {
>   		compatible = "mediatek,mt7622-cir";
>   		reg = <0 0x10009000 0 0x1000>;
>   		interrupts = <GIC_SPI 175 IRQ_TYPE_LEVEL_LOW>;