Received-SPF: pass (google.com: domain of linux-kernel+bounces-91694-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Precedence: bulk
MIME-Version: 1.0
References: <20240301143731.3494455-1-sumit.garg@linaro.org>
 <CAFA6WYOdyPG8xNCwchSzGW+KiaXZJ8LTYuKpyEbhV=tdYz=gUg@mail.gmail.com> <f539dd73-96bd-41e7-8227-fbf1ffba068b@app.fastmail.com>
In-Reply-To: <f539dd73-96bd-41e7-8227-fbf1ffba068b@app.fastmail.com>
From: Sumit Garg <sumit.garg@linaro.org>
Date: Tue, 5 Mar 2024 11:04:19 +0530
Message-ID: <CAFA6WYORMkAmoSqxA3NSfTgfdebnVt1VjJp7i23yt8L8OquWGg@mail.gmail.com>
Subject: Re: [PATCH] tee: optee: Fix kernel panic caused by incorrect error handling
To: Arnd Bergmann <arnd@arndb.de>
Cc: Jens Wiklander <jens.wiklander@linaro.org>, op-tee@lists.trustedfirmware.org, 
	Ilias Apalodimas <ilias.apalodimas@linaro.org>, jerome.forissier@linaro.org, 
	linux-kernel@vger.kernel.org, mikko.rapeli@linaro.org, stable@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"

On Mon, 4 Mar 2024 at 22:35, Arnd Bergmann <arnd@arndb.de> wrote:
>
> On Mon, Mar 4, 2024, at 06:45, Sumit Garg wrote:
> > + Arnd
> >
> > On Fri, 1 Mar 2024 at 20:07, Sumit Garg <sumit.garg@linaro.org> wrote:
> >>
> >> The error path while failing to register devices on the TEE bus has a
> >> bug leading to kernel panic as follows:
> >>
> >> [   15.398930] Unable to handle kernel paging request at virtual address ffff07ed00626d7c
> >> [   15.406913] Mem abort info:
> >> [   15.409722]   ESR = 0x0000000096000005
> >> [   15.413490]   EC = 0x25: DABT (current EL), IL = 32 bits
> >> [   15.418814]   SET = 0, FnV = 0
> >> [   15.421878]   EA = 0, S1PTW = 0
> >> [   15.425031]   FSC = 0x05: level 1 translation fault
> >> [   15.429922] Data abort info:
> >> [   15.432813]   ISV = 0, ISS = 0x00000005, ISS2 = 0x00000000
> >> [   15.438310]   CM = 0, WnR = 0, TnD = 0, TagAccess = 0
> >> [   15.443372]   GCS = 0, Overlay = 0, DirtyBit = 0, Xs = 0
> >> [   15.448697] swapper pgtable: 4k pages, 48-bit VAs, pgdp=00000000d9e3e000
> >> [   15.455413] [ffff07ed00626d7c] pgd=1800000bffdf9003, p4d=1800000bffdf9003, pud=0000000000000000
> >> [   15.464146] Internal error: Oops: 0000000096000005 [#1] PREEMPT SMP
> >>
> >> Commit 7269cba53d90 ("tee: optee: Fix supplicant based device enumeration")
> >> lead to the introduction of this bug. So fix it appropriately.
> >>
> >> Reported-by: Mikko Rapeli <mikko.rapeli@linaro.org>
> >> Closes: https://bugzilla.kernel.org/show_bug.cgi?id=218542
> >> Fixes: 7269cba53d90 ("tee: optee: Fix supplicant based device enumeration")
> >> Cc: stable@vger.kernel.org
> >> Signed-off-by: Sumit Garg <sumit.garg@linaro.org>
> >> ---
> >>  drivers/tee/optee/device.c | 3 ++-
> >>  1 file changed, 2 insertions(+), 1 deletion(-)
> >>
> >
> > Jens, Arnd,
> >
> > Is there any chance for this fix to make it into v6.8 release?
>
> I merged the pull request into my arm/fixes branch now, will
> send the branch on once it passes CI.

Thanks.

-Sumit

>
>      Arnd