Received-SPF: pass (google.com: domain of linux-kernel+bounces-91698-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Tue, 5 Mar 2024 13:37:52 +0800
From: Yujie Liu <yujie.liu@intel.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
CC: lkp <lkp@intel.com>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>, "oe-kbuild-all@lists.linux.dev"
	<oe-kbuild-all@lists.linux.dev>
Subject: Re: drivers/opp/debugfs.c:48:54: warning: '%d' directive output may
 be truncated writing between 1 and 11 bytes into a region of size 8
Message-ID: <ZeavsDQNBA/txKyb@yujie-X299>
References: <202402141313.81ltVF5g-lkp@intel.com>
 <20240214055836.c5i3zmkhdllldwon@vireshk-i7>
 <b41c6cdb78c96d5f4a909fc13c253ef0d8576c86.camel@intel.com>
 <20240304065411.w34vbaeg2rlq6z5k@vireshk-i7>
 <ZeWGpyXXZBeYjnGW@yujie-X299>
 <20240304112102.wih3u5ny3iero47n@vireshk-i7>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20240304112102.wih3u5ny3iero47n@vireshk-i7>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?z40cLrDMdLfvGYuYzt0WnkDrZbC91PfQ2W7ZSgxVAUnSkdCdwU0rhjng8e18?=
 =?us-ascii?Q?ey+Z9wALH85/pBrNoeyt8XUAPETXLM61qMUftLdlJ4PshWfJw5GdWjHsXvnJ?=
 =?us-ascii?Q?1zRqMYYY4/5n5bnyuIfpAbb742MkvK8gny8ITrMBkSQHNKyVsRoDovkCWQwH?=
 =?us-ascii?Q?YFWFwI1a0gBs+alpq/R2+UQhlzylid2l+qrNFloq7xQaoOC7eeQbkH9JKr13?=
 =?us-ascii?Q?xrOuA71Hybc6X9fFbKHx0Wy+c4Vx07rFFzFMaiiZVtDQ/fl6azZG+XVoht9O?=
 =?us-ascii?Q?6yh5XmlySBJyQ6lDLLa8QBD5pxiKXMv/V8+acRJ0thLCd3sojG84KR5ir1vc?=
 =?us-ascii?Q?5jKeHpa2rC0Kk7HomVgFlPnY0k3XeUS447vlmtcRAG0cRJsrt02k0uAsmI9v?=
 =?us-ascii?Q?hXp4OVC+akdt0chFP+ULYnZ/2oEX4a5bknNureqr7Mx6nxsWUzSASWAGLpeN?=
 =?us-ascii?Q?bnGSmft51IwtlQzEOjluV9ra5KEyYlQrlg4OFnjMGJ9BBdGGaGE3+YQIGPqF?=
 =?us-ascii?Q?T1KprAppqp/SH+FWfpRGqF9pTtPqxMAj3hl2p2ESCeVq1+SrhV5zJb6JO7YB?=
 =?us-ascii?Q?3B/QqUityrvlG5BDRpr0yQc4y6uvb2XmIddFSmT9kO7zVxYKM4rPa6jMC3KI?=
 =?us-ascii?Q?oiMMT7xLfu/9xZOb8a4vbKfdryjus669KAc7xWrYQpwf5E1mPRS456FY6yKk?=
 =?us-ascii?Q?PX491ZET30M0yWq6u9xBNhi1X2rYrWfYHeJMWUOptgjoA+0Foc48Eiqd5T9E?=
 =?us-ascii?Q?yR+t7GJsPSh7Uyr/FaERKhog6pHugi0nMtPs+qAEt4ZeSA3uQ2YZbF4pEzgC?=
 =?us-ascii?Q?qf31WdaoAGokqGOkqNxOFWuq5dAn3EtDCpzGs2R93O44N0tzgVbFcp6DciK3?=
 =?us-ascii?Q?q0fgg/g84N9LdTgF3shsSm9AY5EI34t+M+EoPnxQbW6v6t1AQy0R54mo0IKi?=
 =?us-ascii?Q?0VRkMIQcKPIhRzQLPiNRba6+sZe7PHv6aXkXcxjkB2T+hESqADTqlcEa9W0b?=
 =?us-ascii?Q?zRwA+Z3qE8XI5b7ZO+0QYSjryj0Mb/2QtUKZCbQadN8c3rQvb0tFvznTyPzO?=
 =?us-ascii?Q?8YCnnZW9mwQfNwPFFB6cN8w2kEbYsA/k9c5d2uP+alrEA5D4tX4cUF57mmxW?=
 =?us-ascii?Q?ccSldeUXrvi58B9ORnWCcNJiqhk6mJu3QI5pniku8qZk32bwXaz2PJWuncnb?=
 =?us-ascii?Q?qRifOklvbaEZmPa9TXAwexfVfqNk3O1Am2Dv37folusLa0QdS0wz8RWxXW/C?=
 =?us-ascii?Q?na3MUsqEFrpwZu7PkN2IoKEdZCnmjX6lbMA7R+XO282U0hFaL+cCYIHkfUXF?=
 =?us-ascii?Q?B7WvIYuaLnfe7rSZbAzBS2+R5rax3Aof8LwEWzakCzqLCVzIQqUtxIWJ2XYC?=
 =?us-ascii?Q?F1+Uk0KHbuXOwijBDIoQxcpuBx3WXUCK9g1xfw86/p+BkO2/ItYAaHKZkprD?=
 =?us-ascii?Q?qzKV8yUO9v1aY6NmWIujfkYAxLqAEDp9kX6s/8IKsNIlN3PmGO40I0UZ05Km?=
 =?us-ascii?Q?TP/Q+VvYQQswSqRAAhN08FAB9wvODA+zUn/M3lyCy3lMgtNdzsUx5Hcxtotf?=
 =?us-ascii?Q?//hEP4Ge8GCJ+FALhB/I4+Tu+fTOwvIfOzQIgxP6?=
X-MS-Exchange-CrossTenant-Network-Message-Id: c3cbc420-ac40-4acd-d08a-08dc3cd75a78
X-MS-Exchange-CrossTenant-AuthSource: CY5PR11MB6392.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Mar 2024 05:44:41.4240
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: HpQQSKiMogXBBx3Y8+mQCOqOjK0eXTQIhTRoB40hAHWrbi7BEfUMjvXgdIC33LmMBLlIMdvwIfUn0L+40UOJOA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4805
X-OriginatorOrg: intel.com

On Mon, Mar 04, 2024 at 04:51:02PM +0530, Viresh Kumar wrote:
> On 04-03-24, 16:30, Yujie Liu wrote:
> > This fixes the warning for "supply-%d". Seems there are other remaining
> > warnings as shown below. Would you like to take a look as well?
> 
> How about this instead to fix all warnings (drop the earlier change
> please) ?

We see the following errors after applying the new diff:

  CC      drivers/opp/debugfs.o
drivers/opp/debugfs.c: In function 'opp_debug_create_one':
drivers/opp/debugfs.c:92:57: error: 'snprintf' output may be truncated before the last format character [-Werror=format-truncation=]
   92 |                 snprintf(name, sizeof(name), "rate_hz_%d", i);
      |                                                         ^
In function 'opp_debug_create_clks',
    inlined from 'opp_debug_create_one' at drivers/opp/debugfs.c:164:2:
drivers/opp/debugfs.c:92:17: note: 'snprintf' output between 10 and 20 bytes into a destination of size 19
   92 |                 snprintf(name, sizeof(name), "rate_hz_%d", i);
      |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/opp/debugfs.c: In function 'opp_debug_create_one':
drivers/opp/debugfs.c:107:56: error: 'snprintf' output may be truncated before the last format character [-Werror=format-truncation=]
  107 |                 snprintf(name, sizeof(name), "supply-%d", i);
      |                                                        ^
In function 'opp_debug_create_supplies',
    inlined from 'opp_debug_create_one' at drivers/opp/debugfs.c:165:2:
drivers/opp/debugfs.c:107:17: note: 'snprintf' output between 9 and 19 bytes into a destination of size 18
  107 |                 snprintf(name, sizeof(name), "supply-%d", i);
      |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~


An integer has positive and negative limits, and the range is from
-2147483648 to 2147483647 in decimal, so it seems that an integer can
have 11 digits at most.

> 
> diff --git a/drivers/opp/debugfs.c b/drivers/opp/debugfs.c
> index ec030b19164a..a9ebfdf0b6a1 100644
> --- a/drivers/opp/debugfs.c
> +++ b/drivers/opp/debugfs.c
> @@ -37,10 +37,12 @@ static ssize_t bw_name_read(struct file *fp, char __user *userbuf,
>                             size_t count, loff_t *ppos)
>  {
>         struct icc_path *path = fp->private_data;
> +       const char *name = icc_get_name(path);
>         char buf[64];
> -       int i;
> +       int i = 0;
> 
> -       i = scnprintf(buf, sizeof(buf), "%.62s\n", icc_get_name(path));
> +       if (name)
> +               i = scnprintf(buf, sizeof(buf), "%.62s\n", name);
> 
>         return simple_read_from_buffer(userbuf, count, ppos, buf, i);
>  }
> @@ -56,11 +58,11 @@ static void opp_debug_create_bw(struct dev_pm_opp *opp,
>                                 struct dentry *pdentry)
>  {
>         struct dentry *d;
> -       char name[20];
> +       char name[] = "icc-path-XXXXXXXXXX"; /* Integers can take 10 chars max */
>         int i;
> 
>         for (i = 0; i < opp_table->path_count; i++) {
> -               snprintf(name, sizeof(name), "icc-path-%.1d", i);
> +               snprintf(name, sizeof(name), "icc-path-%d", i);
> 
>                 /* Create per-path directory */
>                 d = debugfs_create_dir(name, pdentry);
> @@ -78,7 +80,7 @@ static void opp_debug_create_clks(struct dev_pm_opp *opp,
>                                   struct opp_table *opp_table,
>                                   struct dentry *pdentry)
>  {
> -       char name[12];
> +       char name[] = "rate_hz_XXXXXXXXXX"; /* Integers can take 10 chars max */
>         int i;
> 
>         if (opp_table->clk_count == 1) {
> @@ -100,7 +102,7 @@ static void opp_debug_create_supplies(struct dev_pm_opp *opp,
>         int i;
> 
>         for (i = 0; i < opp_table->regulator_count; i++) {
> -               char name[15];
> +               char name[] = "supply-XXXXXXXXXX"; /* Integers can take 10 chars max */
> 
>                 snprintf(name, sizeof(name), "supply-%d", i);
> 
> -- 
> viresh