Received-SPF: pass (google.com: domain of linux-kernel+bounces-91700-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Content-Type: text/plain;
	charset=utf-8
Subject: Re: [PATCH] tracing: Remove precision vsnprintf() check from print
 event
From: Sachin Sant <sachinp@linux.ibm.com>
In-Reply-To: <20240304174341.2a561d9f@gandalf.local.home>
Date: Tue, 5 Mar 2024 11:17:49 +0530
Cc: LKML <linux-kernel@vger.kernel.org>,
        Linux Trace Kernel <linux-trace-kernel@vger.kernel.org>,
        Masami Hiramatsu <mhiramat@kernel.org>,
        Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
        Linus Torvalds <torvalds@linux-foundation.org>
Message-Id: <C6A44F79-8A0A-496C-82D2-2214BCC34C62@linux.ibm.com>
References: <20240304174341.2a561d9f@gandalf.local.home>
To: Steven Rostedt <rostedt@goodmis.org>
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
MIME-Version: 1.0


> On 05-Mar-2024, at 4:13=E2=80=AFAM, Steven Rostedt <rostedt@goodmis.org> =
wrote:
>=20
> From: "Steven Rostedt (Google)" <rostedt@goodmis.org>
>=20
> This reverts 60be76eeabb3d ("tracing: Add size check when printing
> trace_marker output"). The only reason the precision check was added
> was because of a bug that miscalculated the write size of the string into
> the ring buffer and it truncated it removing the terminating nul byte. On
> reading the trace it crashed the kernel. But this was due to the bug in
> the code that happened during development and should never happen in
> practice. If anything, the precision can hide bugs where the string in the
> ring buffer isn't nul terminated and it will not be checked.
>=20
> Link: https://lore.kernel.org/all/C7E7AF1A-D30F-4D18-B8E5-AF1EF58004F5@li=
nux.ibm.com/
> Link: https://lore.kernel.org/linux-trace-kernel/20240227125706.04279ac2@=
gandalf.local.home
> Link: https://lore.kernel.org/all/20240302111244.3a1674be@gandalf.local.h=
ome/
>=20
> Reported-by: Sachin Sant <sachinp@linux.ibm.com>
> Fixes: 60be76eeabb3d ("tracing: Add size check when printing trace_marker=
 output")
> Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
> ---

This fixes the reported problem for me.

All the ftrace selftests complete without any fails.
# of passed:  121
# of failed:  0
# of unresolved:  6
# of untested:  0
# of unsupported:  7
# of xfailed:  1
# of undefined(test bug):  0

Tested-by: Sachin Sant <sachinp@linux.ibm.com>


=E2=80=94 Sachin