Received-SPF: pass (google.com: domain of linux-kernel+bounces-91762-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <1d3dbc08-654c-46f6-a53d-43deeda5c14f@kernel.org>
Date: Tue, 5 Mar 2024 16:06:47 +0900
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] block: move capacity validation to blkpg_do_ioctl()
Content-Language: en-US
To: Li Lingfeng <lilingfeng@huaweicloud.com>, axboe@kernel.dk,
 min15.li@samsung.com
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, hch@lst.de,
 yangerkun@huawei.com, yukuai1@huaweicloud.com, houtao1@huawei.com,
 yi.zhang@huawei.com
References: <20240305032132.548958-1-lilingfeng@huaweicloud.com>
From: Damien Le Moal <dlemoal@kernel.org>
Organization: Western Digital Research
In-Reply-To: <20240305032132.548958-1-lilingfeng@huaweicloud.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 3/5/24 12:21, Li Lingfeng wrote:
> From: Li Lingfeng <lilingfeng3@huawei.com>
> 
> Commit 6d4e80db4ebe ("block: add capacity validation in
> bdev_add_partition()") add check of partition's start and end sectors to
> prevent exceeding the size of the disk when adding partitions. However,
> there is still no check for resizing partitions now.
> Move the check to blkpg_do_ioctl() to cover resizing partitions.
> 
> Signed-off-by: Li Lingfeng <lilingfeng3@huawei.com>

Looks good.

Reviewed-by: Damien Le Moal <dlemoal@kernel.org>

But I wonder if this needs a Fixes: 6d4e80db4ebe ("block: add capacity
validation in bdev_add_partition()") tag and Cc-stable...

-- 
Damien Le Moal
Western Digital Research