Received-SPF: pass (google.com: domain of linux-kernel+bounces-91771-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
From: Jia Jie Ho <jiajie.ho@starfivetech.com>
To: Herbert Xu <herbert@gondor.apana.org.au>,
	"David S . Miller" <davem@davemloft.net>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>,
	Vinod Koul <vkoul@kernel.org>,
	linux-crypto@vger.kernel.org,
	devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	dmaengine@vger.kernel.org
Subject: [PATCH v4 3/7] crypto: starfive: Skip unneeded key free
Date: Tue,  5 Mar 2024 15:10:02 +0800
Message-Id: <20240305071006.2181158-4-jiajie.ho@starfivetech.com>
In-Reply-To: <20240305071006.2181158-1-jiajie.ho@starfivetech.com>
References: <20240305071006.2181158-1-jiajie.ho@starfivetech.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?WSK97gnCq20HiXuRxQ+s9a47iNe8TnnLf0YRIINTy05ov7Fceh/YAjM3uw/7?=
 =?us-ascii?Q?mf5zALICS+NSYbUbzVk5F68Lq6QabIRvtOvIjJNVB/1JWP5HgOjX8xo0xZzt?=
 =?us-ascii?Q?9q9X219RPiy2krkVs3+HBbuJQ390mYkOCW2zDBDcPcwvyXKLHwJfCOnPrvdu?=
 =?us-ascii?Q?nySUh6xA3//lAbuSn+jsoTrKSIN6K91s2V+HlJkcCvwSMoqP2PNhF0mOvKIK?=
 =?us-ascii?Q?chAu5w6v4tXkemX+GQ4JvXjUKlnQdy2i711X5pxxfyiFCOjvUpRNa+ceEcjd?=
 =?us-ascii?Q?nX3XDzLJGaEjejvRILhS38HKF81yGWzzETwaFNuVh4N0N4K30/dZx+08Rx0u?=
 =?us-ascii?Q?sGQZpPgJ2bEiuQ6RMDqw+k+V2NBacwGLr3GV7CAukQY+n2Y+P6I5mrce54jz?=
 =?us-ascii?Q?RGglwREkVHP6uqX7QiCxi4Tj5prsl0mD4uId8RcCO07HXO03qPVzozaOn8gI?=
 =?us-ascii?Q?Zs+zPWh7HDcLXcVMq/dUlwlIkyb5wt+jg7nLh4wWUbPHP2tQohIMO03t6Zpp?=
 =?us-ascii?Q?QOqVGdkR5A1yF9csHpzP7a4vYlMubKcgJrUlgLHlTuBvIqwFohJ6dXUuV/1V?=
 =?us-ascii?Q?wNLT6CZxY4nPi9C0CNbRnOmBAZbKneA40Hz3z8FncJOJxfcS6DfqWqaEhz9x?=
 =?us-ascii?Q?QyfNImLqNQDpfk6N/UqV4ahdGTmSq6QHNXMlt95PmG59LG9GRh212rxyI0X8?=
 =?us-ascii?Q?3dIPlrMzMF4U2dZHV6pLhztWqwOPr2qdaLc8XOkuBzrTdDAqt84nTLdBLKFL?=
 =?us-ascii?Q?EKOK/FOi8g/HFeXA1oHyxKz84UGll1HnOlLXvmCZEh1WtVpzfLTBgrBfnChz?=
 =?us-ascii?Q?uc88Bj/X/tAJwueGEaIp6wFxNmDfIBWlydjNQQI/SaQrRP8j9C9lMG8mLQ1t?=
 =?us-ascii?Q?GfxiSE/IncTTrjHVSlVpZKHvwvNgQ9CBh4Jcl8JfdI/mgVy4QglnzRPjLTwB?=
 =?us-ascii?Q?mZQ4zweg1qajKzrGROEgKIAYYiVksI6QnMFbBn2r8h9wYl6a6SmwCo9HOYmn?=
 =?us-ascii?Q?4tfU3HwlCNq9DQUyL+oHZg5uwRR7SBIy+0x/WRHvMzWVZXmhFZxCRCskIURW?=
 =?us-ascii?Q?tRM/kFNsNA1w25qKsOz2Jh3GqSLlKGTGTnQr3rBM6HRaSQVOd6x5Et9LxZ/E?=
 =?us-ascii?Q?ApLpsc3+hFd2VLzUTfzXI2t0EQcgnP7XZ9xm74l8MBuuEM8zDiU2xpkbZAeW?=
 =?us-ascii?Q?ZM3rWf1a9+dexKE4i/W8lhlsMUrE5odKli5Hv5fLjTXQ/FosV5bpixhuqD3a?=
 =?us-ascii?Q?zevMU4UPUMnnUWwa2dSakyH1zOLesaG7Om++ArmPKsY06ynIIyhlHOnbzSWn?=
 =?us-ascii?Q?3g1+faGNlMzn5tCn+LMfOXwTsuoS7xtV2pJo1sPXgz5NT6TM1iVDIWSbtsum?=
 =?us-ascii?Q?3wlGAfNqurNLdReHKnho8OD51Bh9h/XZRBWZFNGpzFl/h1JdQv6HhSgDB5dg?=
 =?us-ascii?Q?GcZVwcO68sPqLJD7XAp5QnifEGAhvP+3be82jaZWbjQnSKFVdYuuXeFZaymf?=
 =?us-ascii?Q?NswPrvBmKrXPV0z9qRz/TUQU7WlFwvzVS1VMlGfF76W3Th47rXWh9ddGzJDw?=
 =?us-ascii?Q?zlqf4eiYMJiDNrnTIWtzNvf3rb6a1I0LWDwCQkB5YO/+uH4de7LNegeAlH3d?=
 =?us-ascii?Q?sQ=3D=3D?=
X-OriginatorOrg: starfivetech.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 95dec5cd-4a0d-4e40-de3b-08dc3ce35550
X-MS-Exchange-CrossTenant-AuthSource: SHXPR01MB0670.CHNPR01.prod.partner.outlook.cn
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Mar 2024 07:10:26.8524
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 06fe3fa3-1221-43d3-861b-5a4ee687a85c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: QNrm+uZ5GMUhYUFVgRa6Lo6siRBaLT0mj4AlKf+gZ57ihYSazKTtB0iG9x7FD7zZMNuiETPfnqImE5ywpAbcm0QnnzMxiBd4ZlaQ1FJUmok=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SHXPR01MB0462

Skip unneeded kfree_sensitive if RSA module is using falback algo.

Signed-off-by: Jia Jie Ho <jiajie.ho@starfivetech.com>
---
 drivers/crypto/starfive/jh7110-rsa.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/crypto/starfive/jh7110-rsa.c b/drivers/crypto/starfive/jh7110-rsa.c
index cf8bda7f0855..e642e948d747 100644
--- a/drivers/crypto/starfive/jh7110-rsa.c
+++ b/drivers/crypto/starfive/jh7110-rsa.c
@@ -45,6 +45,9 @@ static inline int starfive_pka_wait_done(struct starfive_cryp_ctx *ctx)
 
 static void starfive_rsa_free_key(struct starfive_rsa_key *key)
 {
+	if (!key->key_sz)
+		return;
+
 	kfree_sensitive(key->d);
 	kfree_sensitive(key->e);
 	kfree_sensitive(key->n);
-- 
2.34.1