Received-SPF: pass (google.com: domain of linux-kernel+bounces-91831-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID:
 <SEZPR06MB6959FF8B9FBD5EA7502B468896222@SEZPR06MB6959.apcprd06.prod.outlook.com>
Date: Tue, 5 Mar 2024 15:48:25 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH net-next v6 10/11] net: hisi_femac: remove unused
 compatible strings
Content-Language: en-US
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
 Yisen Zhuang <yisen.zhuang@huawei.com>, Salil Mehta
 <salil.mehta@huawei.com>, "David S. Miller" <davem@davemloft.net>,
 Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>,
 Paolo Abeni <pabeni@redhat.com>, Rob Herring <robh+dt@kernel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
 Conor Dooley <conor+dt@kernel.org>, Andrew Lunn <andrew@lunn.ch>,
 Heiner Kallweit <hkallweit1@gmail.com>, Russell King <linux@armlinux.org.uk>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
 devicetree@vger.kernel.org
References: <20240228-net-v6-0-6d78d3d598c1@outlook.com>
 <20240228-net-v6-10-6d78d3d598c1@outlook.com>
 <11d0bf3a-3341-4c7f-9a1a-e7c7bc078725@linaro.org>
From: Yang Xiwen <forbidden405@outlook.com>
In-Reply-To: <11d0bf3a-3341-4c7f-9a1a-e7c7bc078725@linaro.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SEZPR06MB6959:EE_|SEZPR06MB6206:EE_
X-MS-Office365-Filtering-Correlation-Id: 47fdb7a1-7af8-44be-16a1-08dc3ce8a640
X-MS-Exchange-SLBlob-MailProps:
	dx7TrgQSB6ctpbu0D5OXN8ruBkhA8DzsNKLHInsk+f3IfIwEYj65f0IuDP0Y/WaME0slUJEEu9AQCCPchUCQm09FVGrxXh1cog/ZuKO5m37nMOd2MrPuU9Bzk6nfqk5fM5b0frEbkGLbVy/Xr0KDNzOUeNo2qxXPHQzdR1rfgbCzrR38qh62pet3sN3TD8ZoNx3s74WDwKpisroentR+fhr+o8Yd+jTIcRm4KCtVF4joaeO98yrzGBwlM7sZByQKB5AI3wXVhaYJ++TBfpqKIgnqg64Z1wPnilIJCh/x3Ho3/TTa9zpq77epOdjTkDLI32tt+te5/dFjpq8Rj2iXuEnAY3jqG3SKsSW7Iw/5tVdPMtpoKmHmtISq3pYdHyQKC+V+U5HDsO+PY3mGEoE8eBHKcoEn12ADgrGWRUW9I9YqAKh+JsxG3Oo2PGRDBEZMrfuYqnm+4ZrAVSYCURTljrMoE9yzeDbzjFcxVYradxx8lgru3MF9ugaQyNCP1bvtEn/Wb3WFxLtW345cOpGygBA+caNqpqd/QyIKS9rvt/8zHOCwMe1sDGIzRVgTjx+HFfrHS8pXWgKYmrrDvENt+hTEEre8DA/COOWJi9VgX8FtBBECAaL8VNvEqi3FvHYIKStilSK9d1MWHsfADUi3YUEtBYWgRwLZLIhcrjV1d7b4l9mOAM2ypordhU+6TpOdDCFSrpRnr2vkmVFNUdy4K3v88AaWaszYJi6v6sXfPAy6CrJZio+a1zgC4tWn7zs2umpCCAZU14k=
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	dGOdFIH1a/aboYIKfNf3YzmZ6YtUO5LNmwYYPnUMZCQg6FcmWxMyJPmfrN552wGlfbYyAhmraMQeNcd3QUjqV+3ikqB6APk4cChwWCPWjAh3p90epN24sS5dLGYJJQEbiDF2dJDK9c5lhzj6ktoTepKT/ODkIFjtbhFjWvR2nZdAeM/2UOBFXyTUo/CMm4ARKs4Wu3wrLEXKyMUxcI822i4n0Ptn8gY+j9wVQbQD2KTUusCSv84OE25k1vzYEDW+83x3fvpqrjk4lP4KhKSHXHHQe1X5KP8wp6c1orDy6Q7b5C+Rfz91blyezi58KGf0lnsi/OgJZP5noG75Fe+sslbbURhVLuwVp4xlcPFTXtKObPIl3qjOGxYZ6xmXtNChOI3kPCTbTZrWGoU28s2yL4PitQ/691pR4UdY9WUAfq8GY4RTIAUHIhgGU0qt1T1f90kdNCmQErsGgAQOBT7v0oC/IC5x5gdmDeNIgZzrfla45epT9LiWGaczDrKptU+mh9LLWhxwHAr7PC1O8mkj7ntFjC2KmG7bNwocxNE3fi7m7JQNsduvn51fDryCuJnK
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?VkRjYVZRczZuWVBUT2lFeWJNcHZIWDZYcTFXK1NsekNlMFdsWUU1OHlpMVRE?=
 =?utf-8?B?cGpYaHlqc2tBNEZvZ3dVS012b0szQ3BQNG5pTVcwMEJXd1crRVJKMHNubnVT?=
 =?utf-8?B?SmZoVEV0SVVvTng4eG96OERxTHBGWUZYUmZGTzNUWlVsODBNVTNZOHhjVTB5?=
 =?utf-8?B?a2NER0NnbzF0UDJ6dWZSbVVRR1UwRVFGV3NyeHRtbFNlMmxYNzNDQVpVVlFG?=
 =?utf-8?B?eGVYTGVUSGJERVhUNXJpUlIyOUZZaktEVnF2M0RTRWllVGxsdStrcFNEc1dB?=
 =?utf-8?B?ZGVXNGFLMW1vWjVQZDVjYW11MVdTREp5UjR1R25GdDYyV0RHbGZ0ZVJuOWFO?=
 =?utf-8?B?dGJSTmpFeE1OTEtueXdkbm9CQXZ3eWp1TEdrQlBoTjVMd2RnMkVKNC9aaFg5?=
 =?utf-8?B?VTlxTVRUa21YZnpKOFkvR05HMCtBaE1Fa3c3Zm50M29vKzQ5MjFmc0VoeGJv?=
 =?utf-8?B?U0k5eXlFNWQwb2ZXSDczTkpNV3NMM096dUVrbk5UWE1zSkJjWTRDcllRL2xa?=
 =?utf-8?B?RHoveHN2NSszR3JtVkRBWTg2VHZjeTZIVnhRWUNwWjllQUtGOE9RMjNvVE9Y?=
 =?utf-8?B?VU56aytVWFJSa3lYeWErdWtFQzdkYzFkdHhpNHNwNklQanl2ZytBZmR5NWlE?=
 =?utf-8?B?NjZSeGJKSVVlSEtaaXdkZjVMNk9jS0tWdEFxNHExRWlEWmFXV1VKSzlocWd2?=
 =?utf-8?B?TjFZdUpvYWlMNWZESUFpOGtxNGxQVEtLc3RLRnF1a0lmaE02RnZEd2x5dWxZ?=
 =?utf-8?B?NUM3TTJvUXIvSk80eHlkWmZQeVB6a05vZUpQT3JXR1U4cTZic01IcXpKcXZq?=
 =?utf-8?B?TWpZcGFtc01uU1JPMmZ4SWhJcVJxYWVyd2pjWldtd3ZzclI4NHEvRVhaM25U?=
 =?utf-8?B?NEtxTVFFQ0FDd3ZyVTR5NGovc01NYWtXMngvUWptSkJwTUg5VGk5SnVlaXNQ?=
 =?utf-8?B?ZkFtKytCQ2ZoN2lMTk9qWmxlSnVhQ0wrREYrTG1rNXo2TnZDdHJnODU4eU9Z?=
 =?utf-8?B?Q1B0eE5MdmpwVnNCV204Sm9JalZaT29VWFhRa3V2bFJuWEIrSzU5bXQwSXY3?=
 =?utf-8?B?L0c2OE9zRlIxRGpuRURaUHhSTFpEckN3ckNlVjdLV2t1TnQvK2hKOGw0cGxZ?=
 =?utf-8?B?Y1BYM0N6bHhCcDNkWk5obzZlNThxSExTN0lWVjhrVDZ6Slk1b3dTK1Y0c0ZS?=
 =?utf-8?B?anV5SHMwOTYyMDRPeGdTdkYyS3FNc0RjNXJkZU9Jejc0elFTVVNFeThBYnBO?=
 =?utf-8?B?dVVzbld6WHpRdGJjeWp6QTlybHVlY0hiRHlweUxLOGlUQnNJN0FGZElDdFhN?=
 =?utf-8?B?c291RVE0OGNBVTZvV0VaYkw4N09YZm1ybjAwb2VCUEs2ZW1MVitkKzRBWHRy?=
 =?utf-8?B?TmNRWGY3cUp3OFphaTlHMHlvLzNQbEQ2L1pzTHB4R3RrRW9xeEc4S0dQeHRp?=
 =?utf-8?B?MlN1K3E4aWxjLzZ3VEZLOS9mQmNONXdBVTZWN0E2aFN1SXRSZHh4alJjL1Zp?=
 =?utf-8?B?cVpFZDFUbnRlc3h6ZWVKSm5KQ09qMDZ4TGxNZmtjQ0pPTC9KT3ZwMUVUeUFa?=
 =?utf-8?B?Z2tlaEJML0V2ZzR5cUR6RzdaVEhtQnhmWHFZaENLWXhmQTljMTBUNnkyeTA2?=
 =?utf-8?B?ZS8vT1pveVBMSDl5djZIT3FnM0ZSQXlMVjF4alhSQmN3SFllaTNTWEowdWVG?=
 =?utf-8?B?b1prVXhoUnVKL3JkNG5tdzFVTGN6WHp2b1hwMDhzZWF2ak9QUWl1UjlySzBS?=
 =?utf-8?Q?qFrrxouVnrG+s6z82z8OWusd82RgC9A2PYdvfJY?=
X-OriginatorOrg: outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 47fdb7a1-7af8-44be-16a1-08dc3ce8a640
X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB6959.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Mar 2024 07:48:30.1070
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg:
	00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SEZPR06MB6206

On 2/29/2024 4:07 PM, Krzysztof Kozlowski wrote:
> On 28/02/2024 10:02, Yang Xiwen via B4 Relay wrote:
>> From: Yang Xiwen <forbidden405@outlook.com>
>>
>> It's hard to get the version number for each FEMAC core and it's unknown
>> how the version can be used. Remove them until it's really needed.
>>
>> Signed-off-by: Yang Xiwen <forbidden405@outlook.com>
>> ---
>>   drivers/net/ethernet/hisilicon/hisi_femac.c | 3 +--
>>   1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/drivers/net/ethernet/hisilicon/hisi_femac.c b/drivers/net/ethernet/hisilicon/hisi_femac.c
>> index 2406263c9dd3..3c5c095dad05 100644
>> --- a/drivers/net/ethernet/hisilicon/hisi_femac.c
>> +++ b/drivers/net/ethernet/hisilicon/hisi_femac.c
>> @@ -945,8 +945,7 @@ static int hisi_femac_drv_resume(struct platform_device *pdev)
>>   #endif
>>   
>>   static const struct of_device_id hisi_femac_match[] = {
>> -	{.compatible = "hisilicon,hisi-femac-v1",},
>> -	{.compatible = "hisilicon,hisi-femac-v2",},
>> +	{.compatible = "hisilicon,hisi-femac",},
> Drop and just use SoC compatibles.


Will be fixed in v8.


>
>>   	{.compatible = "hisilicon,hi3516cv300-femac",},
>
>
> Best regards,
> Krzysztof
>

-- 
Regards,
Yang Xiwen