Received: by 2002:a89:2c3:0:b0:1ed:23cc:44d1 with SMTP id d3csp242607lqs; Tue, 5 Mar 2024 00:00:21 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCXwwufzIBmEa46eTozliCVADtIimPx+RHsjHhS+dney1183bWGXG08KXoxfF4XHYDl6UD/gYAd71ElvUEu57BUwrdq0M8dSBaCMrscIqA== X-Google-Smtp-Source: AGHT+IHYdmH9NoIv9WY1zzVrtTtbCzk0eeeajLOo5+Py+3uujW6Hme8Rp3vkPc+qwKg9Z+bhqK5C X-Received: by 2002:a17:90b:3c85:b0:29b:6a20:8dc8 with SMTP id pv5-20020a17090b3c8500b0029b6a208dc8mr336248pjb.26.1709625620927; Tue, 05 Mar 2024 00:00:20 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709625620; cv=pass; d=google.com; s=arc-20160816; b=q9slB7AvQ2Kjsv0WZM+6oo3o3uUApjq92kpOpDIkXLmQwDVV7zVmzhdg+Erl3dSgUP lhMWw5Cy/18YEjbYgH3kpyrZK3N5E/RW7us47XucWZ42SRFkentNO3Nt8ah4M0Ggjkwg F1l5cnyz0Xz3z3D+40jBynNHJkhBj1pOJXL+2CqMu1u5QQSeKcF9eUdrms4LKRxJDNJj 1UtqCbtYwvf8rgSUuIFCJVrMNKgg7eerwkGM9Cd16ujVuqbUe8sfqjo115l1sz/d50Qb dUYBkpZahV7J0RTgu6BebsWCdw2LV8qeueoA1p1R3uhS91ZUfSjWqct7s8KBIiuLYeTk tGhg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature:dkim-signature:dkim-signature:dkim-signature; bh=PyH7PV9Y+HU6YteN7n/jOhE0Tv1Rk9CDVFNqMbqJmnM=; fh=RymfTjZCcjoLZ4QyuoC8uFkgj4QNYM/VblY/3wFaCcc=; b=W0uXrClcOrTsVXzBN2gbsIP3mB8JTzIogLNTL2bYHJeDj5RB/JTO+4mdTxmwp4QQrz KHTu/4Z9znYJCzOKhq68CmZ8TEvKJ9QUZqmI8o5SrOlrld9QdfGLXVnQPkh2dqW9zcRP Vcrt6XuQfy/KNOULoziZbrzvuRE+sjO4hGOFl1pRhU29kV2Ax0yzpZbuuoTsoCNXuOYS +C+uzCplMfhZkOgtREu2tX6Mg/7jL9cUZEG9wJ6if/iMqkEq4UR2N0baxU7Q9ECyatdF PrDLhcofKL2LDMya1Q5V4tZyLc59F1Xb8QOGs/nLA8jrQrIz2ulapjZQoqSD2SktvLN3 nqcg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=ErCAgTyZ; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=ErCAgTyZ; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519 header.b=ydUnvDrl; arc=pass (i=1 spf=pass spfdomain=suse.de dkim=pass dkdomain=suse.de dkim=pass dkdomain=suse.de dmarc=pass fromdomain=suse.de); spf=pass (google.com: domain of linux-kernel+bounces-91857-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-91857-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id on1-20020a17090b1d0100b0029aca7a6b88si9774445pjb.118.2024.03.05.00.00.20 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Mar 2024 00:00:20 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-91857-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=ErCAgTyZ; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=ErCAgTyZ; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519 header.b=ydUnvDrl; arc=pass (i=1 spf=pass spfdomain=suse.de dkim=pass dkdomain=suse.de dkim=pass dkdomain=suse.de dmarc=pass fromdomain=suse.de); spf=pass (google.com: domain of linux-kernel+bounces-91857-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-91857-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id CF84028879F for ; Tue, 5 Mar 2024 08:00:19 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id CD09A7EF07; Tue, 5 Mar 2024 08:00:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="ErCAgTyZ"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="ydUnvDrl"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="ErCAgTyZ"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="ydUnvDrl" Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 629027E112 for ; Tue, 5 Mar 2024 08:00:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709625613; cv=none; b=VoX2PRjRs5VW9rZCQsTSohsUvm8JsQ4O6z9q+jGdc/hom5l4N0713jlOakAenD6tIu8YaAQl07U3mXANn7B4kNNLeptU39NBwrkLdiVa/2hKWXgzXiyr3Mze2GRVyC38kfKZGVyWjpHcyUPfVoUCZGt4ACOH4aYRLjxsFW/usN4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709625613; c=relaxed/simple; bh=E3ZdWQOv8NqX78M7lCfxK9sqyigsipCJUOCaDqYMdio=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=VJU2fQvg1QXJLsI+5w+np002O2rrMTxuSVPC4ALOnUEXvP+GXVlBU2xgujkQyVl9VgHgI73jLyr40Ig6j9nAa5S/N+TdhEzCUwEEqf/qB+jE0KdZbvWdY1gYa0xWh+2lJ+sJm6MmU64Sgx/ivckPGsXQfExMkB67Vf5tbbnHBR0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=ErCAgTyZ; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=ydUnvDrl; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=ErCAgTyZ; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=ydUnvDrl; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Received: from imap2.dmz-prg2.suse.org (imap2.dmz-prg2.suse.org [10.150.64.98]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 68A233F43B; Tue, 5 Mar 2024 08:00:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1709625609; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=PyH7PV9Y+HU6YteN7n/jOhE0Tv1Rk9CDVFNqMbqJmnM=; b=ErCAgTyZpz4FpeJ3QMYYYx3CgqYSjF8Y20d61DWBcnYOwIYQylS4UFWDsrKF6q0Y+Df+qU pso82TAmA3c2DM8lxanaxAxHhlrNa1B+LYdHDNiB88hIAwFgCXfN+gje7gPSajfY7WmlMC l3JlGkafoNZ75IZF3jZ7mLCnwPLfGKo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1709625609; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=PyH7PV9Y+HU6YteN7n/jOhE0Tv1Rk9CDVFNqMbqJmnM=; b=ydUnvDrlzBbBfLyN+NLQ3muK0ZhGfLQgNscsYM11TtqubEV12eQxWA7EgKOFCPBLzEIPUL TI/97O0P9yginIAQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1709625609; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=PyH7PV9Y+HU6YteN7n/jOhE0Tv1Rk9CDVFNqMbqJmnM=; b=ErCAgTyZpz4FpeJ3QMYYYx3CgqYSjF8Y20d61DWBcnYOwIYQylS4UFWDsrKF6q0Y+Df+qU pso82TAmA3c2DM8lxanaxAxHhlrNa1B+LYdHDNiB88hIAwFgCXfN+gje7gPSajfY7WmlMC l3JlGkafoNZ75IZF3jZ7mLCnwPLfGKo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1709625609; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=PyH7PV9Y+HU6YteN7n/jOhE0Tv1Rk9CDVFNqMbqJmnM=; b=ydUnvDrlzBbBfLyN+NLQ3muK0ZhGfLQgNscsYM11TtqubEV12eQxWA7EgKOFCPBLzEIPUL TI/97O0P9yginIAQ== Received: from imap2.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap2.dmz-prg2.suse.org (Postfix) with ESMTPS id 4E8CC13A5D; Tue, 5 Mar 2024 08:00:09 +0000 (UTC) Received: from dovecot-director2.suse.de ([10.150.64.162]) by imap2.dmz-prg2.suse.org with ESMTPSA id 1ROaEgnR5mW1UQAAn2gu4w (envelope-from ); Tue, 05 Mar 2024 08:00:09 +0000 From: Daniel Wagner To: James Smart Cc: Keith Busch , Christoph Hellwig , Sagi Grimberg , Hannes Reinecke , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, Daniel Wagner Subject: [PATCH v3 0/2] nvme-fabrics: short-circuit connect retries Date: Tue, 5 Mar 2024 09:00:03 +0100 Message-ID: <20240305080005.3638-1-dwagner@suse.de> X-Mailer: git-send-email 2.44.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Authentication-Results: smtp-out1.suse.de; none X-Spam-Level: ** X-Spam-Score: 2.81 X-Spamd-Result: default: False [2.81 / 50.00]; ARC_NA(0.00)[]; SUBJECT_ENDS_SPACES(0.50)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_MISSING_CHARSET(2.50)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; BROKEN_CONTENT_TYPE(1.50)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; RCVD_COUNT_THREE(0.00)[3]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; RCPT_COUNT_SEVEN(0.00)[8]; MID_CONTAINS_FROM(1.00)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_ALL(0.00)[]; BAYES_HAM(-1.39)[90.79%] X-Spam-Flag: NO I've picked up Hannes' DNR patches. In short the make the transports behave the same way when the DNR bit set on a re-connect attempt. We had a discussion this topic in the past and if I got this right we all agreed is that the host should honor the DNR bit on a connect attempt [1] The nvme/045 test case (authentication tests) in blktests is a good test case for this after extending it slightly. TCP and RDMA try to reconnect with an invalid key over and over again, while loop and FC stop after the first fail. [1] https://lore.kernel.org/linux-nvme/20220927143157.3659-1-dwagner@suse.de/ changes: v3: - added my SOB tag - fixed indention v2: - refresh/rebase on current head - extended blktests (nvme/045) to cover this case (see separate post) - https://lore.kernel.org/linux-nvme/20240304161006.19328-1-dwagner@suse.de/ v1: - initial version - https://lore.kernel.org/linux-nvme/20210623143250.82445-1-hare@suse.de/ Hannes Reinecke (2): nvme-tcp: short-circuit reconnect retries nvme-rdma: short-circuit reconnect retries drivers/nvme/host/rdma.c | 22 +++++++++++++++------- drivers/nvme/host/tcp.c | 23 +++++++++++++++-------- 2 files changed, 30 insertions(+), 15 deletions(-) -- 2.44.0