Received-SPF: pass (google.com: domain of linux-kernel+bounces-91878-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
References: <20240213055554.1802415-1-ankur.a.arora@oracle.com>
 <20240213055554.1802415-27-ankur.a.arora@oracle.com>
 <65e3cd87.050a0220.bc052.7a29@mx.google.com>
User-agent: mu4e 1.4.10; emacs 27.2
From: Ankur Arora <ankur.a.arora@oracle.com>
To: Joel Fernandes <joel@joelfernandes.org>
Cc: Ankur Arora <ankur.a.arora@oracle.com>, linux-kernel@vger.kernel.org,
        tglx@linutronix.de, peterz@infradead.org,
        torvalds@linux-foundation.org, paulmck@kernel.org,
        akpm@linux-foundation.org, luto@kernel.org, bp@alien8.de,
        dave.hansen@linux.intel.com, hpa@zytor.com, mingo@redhat.com,
        juri.lelli@redhat.com, vincent.guittot@linaro.org, willy@infradead.org,
        mgorman@suse.de, jpoimboe@kernel.org, mark.rutland@arm.com,
        jgross@suse.com, andrew.cooper3@citrix.com, bristot@kernel.org,
        mathieu.desnoyers@efficios.com, geert@linux-m68k.org,
        glaubitz@physik.fu-berlin.de, anton.ivanov@cambridgegreys.com,
        mattst88@gmail.com, krypton@ulrich-teichert.org, rostedt@goodmis.org,
        David.Laight@aculab.com, richard@nod.at, mjguzik@gmail.com,
        jon.grimm@amd.com, bharata@amd.com, raghavendra.kt@amd.com,
        boris.ostrovsky@oracle.com, konrad.wilk@oracle.com
Subject: Re: [PATCH 26/30] sched: handle preempt=voluntary under PREEMPT_AUTO
In-reply-to: <65e3cd87.050a0220.bc052.7a29@mx.google.com>
Date: Tue, 05 Mar 2024 00:11:28 -0800
Message-ID: <87frx514jz.fsf@oracle.com>
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?i/MoUUmL17oujdhf3J1J5VWjFcrkt2WAN2mYov+A4dg9Zpe+rUrVww1YXxbE?=
 =?us-ascii?Q?xsiA/l8XTIZwSM3QY5HPMS992otaGvwcdWO1oXE6qsUMBvq/t6p381uYqqPv?=
 =?us-ascii?Q?+SjIFBN3YwtxPdfJEuy2Onnt94AZTKIaqdpyHQzTGL4IANmzx5lEO/DdHFYr?=
 =?us-ascii?Q?noMa9QNHlfA2361OOA29u2QnfRxZd5yKMhCc4tpZfNVCEeW0oy2dS8kAMy89?=
 =?us-ascii?Q?LQTaJVRK1R5olJrAlAXEd4EiqCuF38Nq4cbsUB+jRhP4fK0cejOc/m9HWcyb?=
 =?us-ascii?Q?olUJbwJ4l44gjc4J98ADyWMeCavsZJHwgvI/1ry4tblwB7xYXz4YCEkxX03a?=
 =?us-ascii?Q?G9NzPL3y0OQzaTvSIdEzYPqbjG/kpzo2DjAtACcKUAK7riyXM84Jw7HE+FW3?=
 =?us-ascii?Q?ytj7Fp9exZrkoHjnWG+r0J6GKqgNmmSEmMcA9LDbXNSYiUF9plLh4WoHPB3f?=
 =?us-ascii?Q?GX3rMu4NkV8m/gJrEBvX/E3pYA5EgYyu6IHevoW2QtjtUvMM2my1noexKIgA?=
 =?us-ascii?Q?IR64ICeFB/vdpU70kEEPBTkFtja1Fh7b9xNEaoWqWwrhqZH3kxIRlrxy4sdR?=
 =?us-ascii?Q?RsREPi1/z2pjv9EE8evcrIbY7JAtXyWFmsbG+cgwv4uJiMHIEmvzsVbBoqiJ?=
 =?us-ascii?Q?ZXGF+6yQAR9u1SEZLx6WWHPcvCmK6BR0G4iie/VehcUljYDxGmBPuqTx4QxC?=
 =?us-ascii?Q?SYH4kL1cgxJ3JJ8au8SwAGuM3W4kqCAGu2qGG+jccvU1JD0y2h7DTL/Ota8J?=
 =?us-ascii?Q?ok2juS8S0NIHW9SvdEpHnFOLpXj86a0JOJB6WE/3kVa5OWBobH/3fEBXFKYW?=
 =?us-ascii?Q?tm0huoYBAzf2zrLHx01xusFwG5EJrPitDHseKxRUUi8V7ONznANJYxz0BAzw?=
 =?us-ascii?Q?4+YtIx7QqbTTZkBhQeH15J0i6V/tAeeIpE1ca7KLePrMPyzFfuc1rKyEkAft?=
 =?us-ascii?Q?t+EowfK2iaz3XBoWny/8LacCYqC3szkdGPSCLXGWfegofnj1DJ/vUdS4GY58?=
 =?us-ascii?Q?SiNbPTffNqqMcpt54Kk49Q9UTssonzUz1KSFQcnrgT/kuI+dBIKshoK8dJ97?=
 =?us-ascii?Q?JB8QW6iLZ7qXu6tcPgQ6aoFUevfnwEFNDe8ciSU2/1ytHbJFDDlXpYwejE09?=
 =?us-ascii?Q?fI2NSehPkfJhwIqwm9zfnUxutNjQyqoyjjDWoeXDC1Vsbis5JutqqhsAiDd4?=
 =?us-ascii?Q?HWg+Vb7E2ZoLrqRXz8hqzn9fdPoes45cwbYGnjlb3LMMOAwfMAu12Fu/GMN3?=
 =?us-ascii?Q?MveBjZhZ/yjMb53GpXe6ZTTUvaLR53dIs9PaZo4lNbJRvtIcO9Lbq5NGO2DE?=
 =?us-ascii?Q?Gz5RhumhSWzQWwmWSFwH7PrnrZx1xhEcWqlyMiCpHH59EbEur58r7eZAXgk5?=
 =?us-ascii?Q?qdKP7f+dIX+8LC4gnNRxFLcgWgTJ15yk+c8yqstL2JNYLT0xDfTx4xety7nt?=
 =?us-ascii?Q?7wVSwv/PdrstYhYaRBhs2KTO1Sf7/1U7rUnxFMk9W5qSXrQk+7L1r6+y5eh2?=
 =?us-ascii?Q?ERnJh+6Qgve7exmzWg1pBy4WkKj3/0IpOUe2gaxpXZAZ/Vno4EPZu36eyoOz?=
 =?us-ascii?Q?dwFmTWgn1ag6oANYtsKyhQttq6pYV5HlFDy5SpvJ?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	RUkvmydenSTcLiEQ9xeZBVORiUZdCCO6Zb//SCtPo2RTkKoH2ll1yDQLcgV/c02fa9aJNXB3rrAH8zvuBKBKdZkqklDsImuyf0pejB3pCdqWcz9qv9l4R0FjGZeIFr2lG8kxE1ogG0WAPYdJDFM/hg8/2o8/O74yO6DVLdB1vjK+zWrazexaN8WjK+67RMJn6g9ocrd2YjqEKSFE5RJw1qR6BT5OyDwg9z9JrdB9kDvYVvbyUUbNUMTKZOkGJ9hIaBGhFa4HVOmP9yH4l16KmrxmIsspskSuhJqhGC2PSfuUOfVVrnb8IWbnkp1A9lvn2wVFFGOKWfG71hdLXQX3e665Tyhls49RFep1E0Eym7DwmU+0/1lHkHiOvOtEscIxRdBE8XNNDvf1f9SA8Ahb27bz1pY2/jU/QUo29XEqgJZC2fRuFjn/OdaaCXaaLmp+iRrHK7qKb04ga2zWL+0S62SG3aVvPAXHH9cQuGDxe+lDaWiWj1+ZpuJnekMXQ0BBFKKtCNAc37nlORw+RjJewV/2bd5BWTrbqI24/Yt4/UWMR6OzvEhUmfUCr47lqUI/fVqhLz5mmJ/tQOtNjmLfURoJmpGwT26fRLlCjNTnVpo=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 45cec29b-98eb-460d-f130-08dc3cebcb27
X-MS-Exchange-CrossTenant-AuthSource: DM8PR10MB5416.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Mar 2024 08:11:00.6663
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +VnQAz3jVOUmEhoe+9Cp1TXb0MNM8PW0/uHuNhxi19S/ZuLOJTDldN4AMZebeuDZrjTtCOLE1Az34jCIN8MGtTLFUH1ua65NltdNpOKAfbc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR10MB5791
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-03-05_05,2024-03-04_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 mlxlogscore=952
 adultscore=0 phishscore=0 spamscore=0 mlxscore=0 bulkscore=0
 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2311290000 definitions=main-2403050063
X-Proofpoint-ORIG-GUID: s3RtsY4g-VGe7_iSf3m5SqiyOu0f99S-
X-Proofpoint-GUID: s3RtsY4g-VGe7_iSf3m5SqiyOu0f99S-


Joel Fernandes <joel@joelfernandes.org> writes:

> Hi Anukr,
>
> On Mon, Feb 12, 2024 at 09:55:50PM -0800, Ankur Arora wrote:
>> The default preemption policy for voluntary preemption under
>> PREEMPT_AUTO is to schedule eagerly for tasks of higher scheduling
>> class, and lazily for well-behaved, non-idle tasks.
>>
>> This is the same policy as preempt=none, with an eager handling of
>> higher priority scheduling classes.
>
> AFAICS, the meaning of the word 'voluntary' has changed versus the old
> CONFIG_PREEMPT_VOLUNTARY, with this patch.
>
> So the word voluntary does not completely make sense in this context. What is
> VOLUNTARY about choosing a higher scheduling class?
>
> For instance, even in the same scheduling class, there is a notion of higher
> priority, not just between classes. Example, higher RT priority within RT, or
> earlier deadline within EEVDF (formerly CFS).

Agreed. The higher scheduling class line is pretty fuzzy and after the discussion
with Juri, almost non existent: https://lore.kernel.org/lkml/ZeBPXNFkipU9yytp@localhost.localdomain/.

> IMO, just kill 'voluntary' if PREEMPT_AUTO is enabled. There is no
> 'voluntary' business because
> 1. The behavior vs =none is to allow higher scheduling class to preempt, it
> is not about the old voluntary.

What do you think about folding the higher scheduling class preemption logic
into preempt=none? As Juri pointed out, prioritization of at least the leftmost
deadline task needs to be done for correctness.

(That'll get rid of the current preempt=voluntary model, at least until
there's a separate use for it.)

> 2. you are also planning to remove cond_resched()s via this series and leave
> it to the scheduler right?

Yeah, under PREEMPT_AUTO, cond_resched() will /almost/ be not there. Gets
defined to:

static inline int _cond_resched(void)
{
        klp_sched_try_switch();
        return 0;
}

Right now, we need cond_resched() to make timely forward progress while
doing live-patching.

> Or call it preempt=higher, or something? No one is going to understand the
> meaning of voluntary the way it is implied here IMHO.

I don't think there's enough to make it worth adding a new model. For
now I'm tending towards moving the correctness parts to preempt=none and
making preempt=voluntary identical to preempt=none.

Thanks for the review.

--
ankur