Received-SPF: pass (google.com: domain of linux-kernel+bounces-91906-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Tue, 5 Mar 2024 09:26:22 +0100
From: Johan Hovold <johan@kernel.org>
To: Krishna Kurapati PSSNV <quic_kriskura@quicinc.com>
Cc: Bjorn Andersson <andersson@kernel.org>,
	Wesley Cheng <quic_wcheng@quicinc.com>,
	Konrad Dybcio <konrad.dybcio@linaro.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
	linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org,
	linux-kernel@vger.kernel.org, quic_ppratap@quicinc.com,
	quic_jackp@quicinc.com
Subject: Re: [PATCH] usb: dwc3: qcom: Remove ACPI support from glue driver
Message-ID: <ZebXLkA9kXzx6qNi@hovoldconsulting.com>
References: <20240305042143.3455101-1-quic_kriskura@quicinc.com>
 <ZebFKlae0a-deBKl@hovoldconsulting.com>
 <0c2c039e-b49e-4172-9c7f-24061e3ac5c6@quicinc.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <0c2c039e-b49e-4172-9c7f-24061e3ac5c6@quicinc.com>

On Tue, Mar 05, 2024 at 01:47:05PM +0530, Krishna Kurapati PSSNV wrote:
> On 3/5/2024 12:39 PM, Johan Hovold wrote:
> > On Tue, Mar 05, 2024 at 09:51:43AM +0530, Krishna Kurapati wrote:

> > You should update the Kconfig entry for USB_DWC3_QCOM as well and drop
> > the ACPI dependency.
> 
> Missed it. Thanks for the catch. The following is the one right ?
> 
> diff --git a/drivers/usb/dwc3/Kconfig b/drivers/usb/dwc3/Kconfig
> index 5fc27b20df63..31078f3d41b8 100644
> --- a/drivers/usb/dwc3/Kconfig
> +++ b/drivers/usb/dwc3/Kconfig
> @@ -131,7 +131,7 @@ config USB_DWC3_QCOM
>          tristate "Qualcomm Platform"
>          depends on ARCH_QCOM || COMPILE_TEST
>          depends on EXTCON || !EXTCON
> -       depends on (OF || ACPI)
> +       depends on OF

Right.

> > Looks good to me otherwise.
> 
> Thanks for the review. Wanted to reply to your comments on multiport 
> series depending on how this patch goes in upstream.
> 
> Can I push out v2 or wait for a couple of days (as a standard practice 
> before putting a new version) ?

I think you can send a v2 straight away in this case.

Johan